Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Fri, 20 Oct 2023 10:55:01 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     "Tian, Kevin" <kevin.tian@intel.com>
Cc:     Nicolin Chen <nicolinc@nvidia.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: Re: [PATCH v4 08/17] iommufd: Always setup MSI and anforce cc on
 kernel-managed domains
Message-ID: <20231020135501.GG3952@nvidia.com>
References: <ZSnkiKoCspmG1+/j@Asurada-Nvidia>
 <BN9PR11MB52763227866603ED7795AA068CD7A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20231016115736.GP3952@nvidia.com>
 <BN9PR11MB5276FDC375685CE04A7AD93B8CD6A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20231017155301.GH3952@nvidia.com>
 <ZS7nb+mKanGFXhZY@Asurada-Nvidia>
 <20231018165113.GB3952@nvidia.com>
 <BN9PR11MB5276B9994AD06E91E07B7EF08CD4A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <20231019235350.GY3952@nvidia.com>
 <BN9PR11MB5276A64DA68586AEFB6561148CDBA@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <BN9PR11MB5276A64DA68586AEFB6561148CDBA@BN9PR11MB5276.namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVh1L2J0alBQbnRkZUxSSkRMTXgrMGI4VEpsYVhSNHhTMnJNd2VqN3Vta05F?=
 =?utf-8?B?dExYUDRPVjE1S29zSVZVd3FkMkxrQ0dNQlZ3S0RieWZGeVFRa0JYaXIySzZ1?=
 =?utf-8?B?YmxKeW8wZTNyQzRNbEhzcVgyWmI0b0Ezdjc5QlNnMTMxZlBWN24zQ09ESldU?=
 =?utf-8?B?OXVlYlVRSWpJUUt1VG9VeDR1Y3gwZlNCT2IrZ0hqS3FpcUJlV2JTOWlMQlB5?=
 =?utf-8?B?TnR5c1F2SVZET0F4MFFqTittVXAxNFd2TWJHb0FHUDBsT1pJa3QrZ3RGVFhQ?=
 =?utf-8?B?UzBOVXprMWtRbkFFdy9QOFdhNnpLZjNLVk8yYmNyZ05kaWVYR2dISjMwR1dh?=
 =?utf-8?B?SDYrTk4rR0VpQjN4dzhvZ2NYOUxVbGdVYWozTmZpOUd1TFJnT2wwbXU1QnhF?=
 =?utf-8?B?eFR1QlJqek1qU1VrSWVrREovY041TDJXNEdDS0lwU0VJY3p4VG9FMDdrUWRu?=
 =?utf-8?B?QU52dVBPY01uVEtoclQzMXl1RkdnLzBvV0wyWk44bC94SEo3aGRzdm9VdWJI?=
 =?utf-8?B?UUlzSkgxQ0NFdk5tTGgxem1sNS9pSGVGQWcrbWRFMThVb1dSLzJjQUMyNFNY?=
 =?utf-8?B?emcwZHhqTUMrSkdiVzJUT3pxM3ZyNW93MzVQbERKaXVzTGEvM21wUmR2bUt2?=
 =?utf-8?B?b21DdFhwSXdFMVpPR2QyTnlpUTY0OWJlN0pxSnd4K3ZJNk9LeGl0ZjVCTlZk?=
 =?utf-8?B?aGpOVVV1aDdHckxDL3J1dVdPZjJKVDlUc1ZuWnNuRjhmdkgzZ2NDZFpzS0Ez?=
 =?utf-8?B?cVpzUDA0RDk2QWpod0Zzb09sNVoxVHN6Mi9iWk44cEt5TTlKajBGcFpYeFF2?=
 =?utf-8?B?MjMvSUVTQ1RLUTBkd2xndWdEckJ6VS9DcFQ3NWlJRUtYTC82cEwwbjR6RUNp?=
 =?utf-8?B?Y2tsei9hT2dubStMb0p5N2wvYWc2R3BoZTVFUkhpbWNmQ1FSZ2hGS0FEOGNs?=
 =?utf-8?B?MEk1Zk1jekFybGhPZzJ6N1YzVDc1WFZ2L2ZzdStTSlVndFdZOTFzZVU5RmFZ?=
 =?utf-8?B?UTlhazRqTFV4QlljeVM1U3hoMTNoWlNRWDErN1pFejZLUC9iQnlzN0ZJNzkr?=
 =?utf-8?B?T2oxWFFsa3BvZ0JSekRzQVFBU2RxSUZ6Vko4NElSZXo2OXJaRE5JczVpeGR1?=
 =?utf-8?B?NTVFdk9pU21VTmc0M2NTTkRydkNPQVdtUFN0bElDL1NJTUlNK01kQkdOTkdT?=
 =?utf-8?B?Rm95b0t3NmE1SWRIemRqemo1a0tXdkZPT0haaHU3L3RuNUZSWG0vbm1aRHZU?=
 =?utf-8?B?Ry9hbk16RFFSSGVyVC9COVZxZDl5T0ZwcXM5N3N4OHdSeXY1eXlqTk9rUHdk?=
 =?utf-8?B?SnM1VGpSVnhRSHhBbGpLTVIxTEF3OEpLVTg2c01YdTdCV0NFYm5hMTFvVWxk?=
 =?utf-8?B?VEFXWkMwWE1UT2NKS1pKYjNxOTB3T2FiRVNYRWRTcW9IS3Zsa3RqSnVGK1lD?=
 =?utf-8?B?Wi92OFI1ZnZRWFM4Z2VWK3BWcDBlMjB5dG1tTWxxWCtsLzRCQXV3Mmo4UGV4?=
 =?utf-8?B?QTZNd3NlT3hRaktyTm1rM085ODZRUjN4dHl6NzBkaW9NMFZuOGQrd1JvcGZU?=
 =?utf-8?B?bGlpNmhxa2JmamtoVHZpcE9oL3kyc3RYcnJsc21WU1c1Z2JqQUJiSFV6U3dR?=
 =?utf-8?B?WlVJcWRhY2hSbk9oWVloNTlxdFVsN25TQ2wvKzRqeHJDREZFOURNMDZPUGhG?=
 =?utf-8?B?eFdtUkxtblhWLzZkSEh2Rk9PVURXNFhUbko1enl6a002MmQyeThnc0M0L1pR?=
 =?utf-8?B?TE5HdnpCM2N1bGFIL21wN0tHUXJiSjZvVE82dXQzeDgyeEFsakM0b2FoSXRQ?=
 =?utf-8?B?WkFxRnF6by9aeS9DR1BEWUxYQmtPQUZuaHBJSDZKdk5ROHB6R2RlR2VYMTdu?=
 =?utf-8?B?ckxOMUs0cWJGM25kVXRFWHJZVFIvdFJ5Si9LK1hHY1pNd01WMkoyRHJ1RmJ0?=
 =?utf-8?B?bEhjZVFzM2JLeGIxbFllOHVnamVudlYzZ3FsS3hDS1JFNlVpVWNGcVpSaEs2?=
 =?utf-8?B?dTd6eFZ3MXkrcS8yN05aUTFwa1FOVWtucVRmZDhUZHNVVk5sKzZBUjRTVVFh?=
 =?utf-8?B?blphTVlNaGJNUHQzQTQ5azZsWEhBdWtERUN2RjNRQlJialdFSEFFT1JHVm9R?=
 =?utf-8?Q?lsQyRjNUh8op1UeKVedOg8vnT?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 47d0c505-381e-4b87-21ae-08dbd1742869
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 13:55:02.8593
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dyrhWTiOI2K22Z7x9wX56U1ItKhwy0Q9x+XwnJ+oJje5DDGueh+D4hJ7qPmhG03q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5071
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 20 Oct 2023 06:55:26 -0700 (PDT)

On Fri, Oct 20, 2023 at 02:43:58AM +0000, Tian, Kevin wrote:

> What we want to prevent is attaching a non-CC device to a CC domain
> or upgrade a non-CC domain to CC since in both case the non-CC
> device will be broken due to incompatible page table format.

[..]

> Who cares about such consistency? sure the result is different due to order:
> 
> 1) creating hwpt for dev1 (non-CC) then later attaching hwpt to
>     dev2 (CC) will succeed;
> 
> 2) creating hwpt for dev2 (CC) then later attaching hwpt to
>     dev1 (non-CC) will fail then the user should create a new hwpt
>     for dev1;

AH... So really what the Intel driver wants is not upgrade to CC but
*downgrade* from CC.

non-CC is the type that is universally applicable, so if we come
across a non-CC capable device the proper/optimal thing is to degrade
the HWPT and re-use it, not allocate a new HWPT.

So the whole thing is upside down.

As changing the IOPTEs in flight seems hard, and I don't want to see
the Intel driver get slowed down to accomodate this, I think you are
right to say this should be a creation time property only.

I still think userspace should be able to select it so it can minimize
the number of HWPTs required.

> But the user shouldn't assume such explicit consistency since it's not
> defined in our uAPI. All we defined is that the attaching may
> fail due to incompatibility for whatever reason then the user can
> always try creating a new hwpt for the to-be-attached device. From
> this regard I don't see providing consistency of result is
> necessary. ????

Anyhow, OK, lets add a comment summarizing your points and remove the
cc upgrade at attach time (sorry Nicolin/Yi!)

It is easy to add a HWPT flag for this later if someone wants to
optimize it.

Jason