Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp1116181rdb; Fri, 20 Oct 2023 08:51:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTyMvpu5WoDqVw0UVaNIx5eRp6zibuwiePGoomXQVAE8cGSAJ1dnhl+23fncKSXt17KFHr X-Received: by 2002:a17:902:d506:b0:1c2:1068:1f4f with SMTP id b6-20020a170902d50600b001c210681f4fmr2107125plg.17.1697817075005; Fri, 20 Oct 2023 08:51:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697817074; cv=none; d=google.com; s=arc-20160816; b=JyXJOmMnmJKspDS7S7kUfjgA4ZlQcAO+ESubOIO7hALT898XqrZaIDogd58ikjeKT5 reMBIiOoKxPMJyZhm67EQlmuP19P9+d0TJCCON1X5pOP77p/FKqoWdgpS7z3dI3tXLqo 04RgGhpwpO7iXcjPmQN962fF2kiv285KNYlYligfGfvlM4W+vkTGouiCrLPx3jMlzcP1 XEO8/KiPf2IhsjHadczM5qolmXDg04dLtFcIF7/7htznZ/SMIivkrYoCkejWPfAMGn+K +MPxov1T9CzMHHs5JaNjp2aoPpQoyiYtVZEm5sk8IVLme7oOG3to/UX742ktMqZPhuka dO1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=z7Unt13qEslS+WpNaJrnD/5CwOiBRKQDbQgXxuuTjBI=; fh=lIE7kbreK4ykrymgxWxkOyzPeY1aq5Et0wn/kfpcPwU=; b=h1X1Rpk3sKoc2mDRjogHpepdLj51fUod5FXUbi+wQ/7QT2RPF50bsAl1fSi7M0pgZ7 I3/YULx1BiqmUQucgMmuusy9qnIOGW5Ynd+y2XVJKDBXvNvc8UvNj9JNkNEM/HY23adn W19WsdXUsMKCvo37KR4fYKzmCid2LRNPLeMKsamdzsSlY+Uc+g65vYYxEA3JAZPqY4Y0 hBe9ZxLjKBr88o3jDAZPRjLQ1W9NdiGX1cQ+DzQjGiVqHJ68/1+HBoqQ78gaPVFmyosF 2itG+CzxsO0r8NSvZw/B/5ItCpC2JqyXSGiPGinH6sID2x0McQ+siGOUZ2SNXnWEflq4 5Ewg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=ImrYmy1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id u15-20020a170903124f00b001c589ba4a08si2165638plh.1.2023.10.20.08.51.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 08:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=ImrYmy1Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8F307803B35B; Fri, 20 Oct 2023 08:51:00 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377765AbjJTPut (ORCPT + 99 others); Fri, 20 Oct 2023 11:50:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377787AbjJTPur (ORCPT ); Fri, 20 Oct 2023 11:50:47 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1C1D60 for ; Fri, 20 Oct 2023 08:50:45 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c50cd16f3bso14083851fa.2 for ; Fri, 20 Oct 2023 08:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1697817043; x=1698421843; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z7Unt13qEslS+WpNaJrnD/5CwOiBRKQDbQgXxuuTjBI=; b=ImrYmy1YDMKRmIN3zC6DTT9kjnPHlkSWAAtTzfLeI+pVF3zCi3qXtJxcydG+7AA2O0 2whBTX+KZWeAJ6bH8d8MiKrrCuCvTKaQ/i3z+ZWy4Z7t9oVJ17ZQnMmwlC2ry0x7ve7j afQDom1NPXTAOXU/JOEiC3lY07joBtoBQBgyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697817043; x=1698421843; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z7Unt13qEslS+WpNaJrnD/5CwOiBRKQDbQgXxuuTjBI=; b=nljgHytBigJyn8nU4yFDqqjJloHrTryHc40nkzoJTxFlQHMnBrxRD1S6kg+BmiTxv9 dhbOt01Xi6LUiI1JtBCvLfkMXBlIiwM5LYu1QSszkfoot863FzbxxO4PKOjuSVjZb/XQ 25lb5bs3pJv9bvw7rd3i6iHjw+4rmya54js3L6M8vL63uYcPQWv+mr4ChwZU8h3npsxN 9MXqf/6Y1gY18/yo6wW+dFwLPEIy9DCnpcItpw9noWJg71sVJxjWsTEiL7wtH6IKZ2Ob KCLBj6pgHHghyIQSJknFn3SZknepnNDuFxYzreL843GpWnHgEchknhdptBDavenP4+oW WyJQ== X-Gm-Message-State: AOJu0YzDkep31HfGBTbKYSK44awUdrmbtopop/XlZlTgdETzMw+7Wa84 4lDuRW1JayPC/NCWORT5rmwl/tsbluFsxwGXPcySuQ== X-Received: by 2002:a2e:bc07:0:b0:2c5:9e2:ed14 with SMTP id b7-20020a2ebc07000000b002c509e2ed14mr2601912ljf.39.1697817043155; Fri, 20 Oct 2023 08:50:43 -0700 (PDT) MIME-Version: 1.0 References: <20231020014031.919742-1-joel@joelfernandes.org> <20231020014031.919742-3-joel@joelfernandes.org> In-Reply-To: From: Joel Fernandes Date: Fri, 20 Oct 2023 11:50:32 -0400 Message-ID: Subject: Re: [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance To: Ingo Molnar Cc: Vincent Guittot , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , "Vineeth Pillai (Google)" , Suleiman Souhlal , Frederic Weisbecker , "Paul E . McKenney" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 08:51:00 -0700 (PDT) On Fri, Oct 20, 2023 at 9:57=E2=80=AFAM Ingo Molnar wrot= e: > > > * Vincent Guittot wrote: > > > Even if your figures look interesting, your patch adds regression in > > the load balance and the fairness. > > Indeed - I've removed it from tip:sched/core for the time being. Sorry we should have marked it as RFC. We still feel there are issues in the newidle balance code and the fix is in the right direction, we'll continue discussing with Vincent on the other thread and try to come up with a proper solution. Thank you Ingo and Vincent! - Joel & Vineeth