Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Fri, 20 Oct 2023 19:03:37 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Frank Li <Frank.li@nxp.com>
Cc:     alexandre.belloni@bootlin.com, conor.culhane@silvaco.com,
        imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join
 failure since timeout errory
Message-ID: <20231020190337.13ef5638@xps-13>
In-Reply-To: <ZTKhJOAAz4CaupEf@lizhi-Precision-Tower-5810>
References: <20231018155926.3305476-1-Frank.Li@nxp.com>
        <20231018155926.3305476-7-Frank.Li@nxp.com>
        <20231019084452.11fd0645@xps-13>
        <ZTFNvrsSoHOS3P2g@lizhi-Precision-Tower-5810>
        <20231020160645.67e678ee@xps-13>
        <ZTKMTwU6cVAfGCKG@lizhi-Precision-Tower-5810>
        <20231020163525.66485920@xps-13>
        <ZTKTGG7J55Sj19Nd@lizhi-Precision-Tower-5810>
        <20231020172006.5de0998b@xps-13>
        <ZTKhJOAAz4CaupEf@lizhi-Precision-Tower-5810>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Frank,

Frank.li@nxp.com wrote on Fri, 20 Oct 2023 11:47:48 -0400:

> On Fri, Oct 20, 2023 at 05:20:06PM +0200, Miquel Raynal wrote:
> > Hi Frank,
> >=20
> > Frank.li@nxp.com wrote on Fri, 20 Oct 2023 10:47:52 -0400:
> >  =20
> > > On Fri, Oct 20, 2023 at 04:35:25PM +0200, Miquel Raynal wrote: =20
> > > > Hi Frank,
> > > >=20
> > > > Frank.li@nxp.com wrote on Fri, 20 Oct 2023 10:18:55 -0400:
> > > >    =20
> > > > > On Fri, Oct 20, 2023 at 04:06:45PM +0200, Miquel Raynal wrote:   =
=20
> > > > > > Hi Frank,
> > > > > >=20
> > > > > > Frank.li@nxp.com wrote on Thu, 19 Oct 2023 11:39:42 -0400:
> > > > > >      =20
> > > > > > > On Thu, Oct 19, 2023 at 08:44:52AM +0200, Miquel Raynal wrote=
:     =20
> > > > > > > > Hi Frank,
> > > > > > > >=20
> > > > > > > > Frank.Li@nxp.com wrote on Wed, 18 Oct 2023 11:59:26 -0400:
> > > > > > > >        =20
> > > > > > > > > master side report:
> > > > > > > > >   silvaco-i3c-master 44330000.i3c-master: Error condition=
: MSTATUS 0x020090c7, MERRWARN 0x00100000
> > > > > > > > >=20
> > > > > > > > > BIT 20: TIMEOUT error
> > > > > > > > >   The module has stalled too long in a frame. This happen=
s when:
> > > > > > > > >   - The TX FIFO or RX FIFO is not handled and the bus is =
stuck in the
> > > > > > > > > middle of a message,
> > > > > > > > >   - No STOP was issued and between messages,
> > > > > > > > >   - IBI manual is used and no decision was made.       =20
> > > > > > > >=20
> > > > > > > > I am still not convinced this should be ignored in all case=
s.
> > > > > > > >=20
> > > > > > > > Case 1 is a problem because the hardware failed somehow.   =
    =20
> > > > > > >=20
> > > > > > > But so far, no action to handle this case in current code.   =
  =20
> > > > > >=20
> > > > > > Yes, but if you detect an issue and ignore it, it's not better =
than
> > > > > > reporting it without handling it. Instead of totally ignoring t=
his I
> > > > > > would at least write a debug message (identical to what's below=
) before
> > > > > > returning false, even though I am not convinced unconditionally
> > > > > > returning false here is wise. If you fail a hardware sequence b=
ecause
> > > > > > you added a printk, it's a problem. Maybe you consider this lin=
e as
> > > > > > noise, but I believe it's still an error condition. Maybe, howe=
ver,
> > > > > > this bit gets set after the whole sequence, and this is just a =
"bus
> > > > > > is idle" condition. If that's the case, then you need some
> > > > > > additional heuristics to properly ignore the bit?
> > > > > >      =20
> > > > >=20
> > > > >                 dev_err(master->dev,                             =
         =20
> > > > >                         "Error condition: MSTATUS 0x%08x, MERRWAR=
N 0x%08x\n",
> > > > >                         mstatus, merrwarn);
> > > > > +
> > > > > +		/* ignore timeout error */
> > > > > +		if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT)
> > > > > +			return false;
> > > > > +
> > > > >=20
> > > > > Is it okay move SVC_I3C_MERRWARN_TIMEOUT after dev_err?   =20
> > > >=20
> > > > I think you mentioned earlier that the problem was not the printk b=
ut
> > > > the return value. So perhaps there is a way to know if the timeout
> > > > happened after a transaction and was legitimate or not?   =20
> > >=20
> > > Error message just annoise user, don't impact function. But return fa=
lse
> > > let IBI thread running to avoid dead lock.=20
> > >  =20
> > > >=20
> > > > In any case we should probably lower the log level for this error. =
  =20
> > >=20
> > > Only SVC_I3C_MERRWARN_TIMEOUT is warning
> > >=20
> > > Maybe below logic is better
> > >=20
> > > 	if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) {
> > > 		dev_dbg(master->dev,=20
> > >                         "Error condition: MSTATUS 0x%08x, MERRWARN 0x=
%08x\n",
> > > 			mstatus, merrwarn);
> > > 		return false;
> > > 	}=20
> > > =09
> > > 	dev_err(master->dev,                                    =20
> > >                 "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n",
> > >                  mstatus, merrwarn);=20
> > > 	....
> > >  =20
> >=20
> > Yes, this looks better but I wonder if we should add an additional
> > condition to just return false in this case;  =20
>=20
> What's additional condition we can check?

Well, you're the one bothered with an error case which is not a real
error. You're saying "this error is never a problem" and I am saying
that I believe it is not a problem is your particular case, but in
general there might be situations where it *is* a problem. So you need
to find proper conditions to check against in order to determine
whether this is just an info with no consequence or an error.

> > something saying "this
> > timeout is legitimate and has no impact". =20
>=20
> Add comments "this timeout is legitimate and has no impact" or dev_dbg
> print that?

No I'm talking about the additional heuristics.

Thanks,
Miqu=C3=A8l