Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <13365827.uLZWGnKmhe@kreacher> <8282829.T7Z3S40VBb@kreacher> <63b7f4da-8ddb-443c-8074-66b7b0c6cd84@arm.com>
In-Reply-To: <63b7f4da-8ddb-443c-8074-66b7b0c6cd84@arm.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 20 Oct 2023 19:19:08 +0200
Message-ID: <CAJZ5v0j9aZ-TGWj5oKeG3+pdDwpYv4y28-k3UtUMiyAroDMN5Q@mail.gmail.com>
Subject: Re: [PATCH v1 2/6] thermal: trip: Define for_each_trip() macro
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Zhang Rui <rui.zhang@intel.com>,
        Linux PM <linux-pm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Oct 20, 2023 at 7:14 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
>
>
> On 10/6/23 18:41, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > Define a new macro for_each_trip() to be used by the thermal core code
> > and thermal governors for walking trips in a given thermal zone.
> >
> > Modify for_each_thermal_trip() to use this macro instead of an open-
> > coded loop over trips.
> >
> > No intentional functional impact.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> >   drivers/thermal/thermal_core.h |    3 +++
> >   drivers/thermal/thermal_trip.c |    7 ++++---
> >   2 files changed, 7 insertions(+), 3 deletions(-)
> >
> > Index: linux-pm/drivers/thermal/thermal_core.h
> > ===================================================================
> > --- linux-pm.orig/drivers/thermal/thermal_core.h
> > +++ linux-pm/drivers/thermal/thermal_core.h
> > @@ -116,6 +116,9 @@ void __thermal_zone_device_update(struct
> >                                 enum thermal_notify_event event);
> >
> >   /* Helpers */
> > +#define for_each_trip(__tz, __trip)  \
> > +     for (__trip = __tz->trips; __trip - __tz->trips < __tz->num_trips; __trip++)
> > +
> >   void __thermal_zone_set_trips(struct thermal_zone_device *tz);
> >   int __thermal_zone_get_trip(struct thermal_zone_device *tz, int trip_id,
> >                           struct thermal_trip *trip);
> > Index: linux-pm/drivers/thermal/thermal_trip.c
> > ===================================================================
> > --- linux-pm.orig/drivers/thermal/thermal_trip.c
> > +++ linux-pm/drivers/thermal/thermal_trip.c
> > @@ -13,12 +13,13 @@ int for_each_thermal_trip(struct thermal
> >                         int (*cb)(struct thermal_trip *, void *),
> >                         void *data)
> >   {
> > -     int i, ret;
> > +     struct thermal_trip *trip;
> > +     int ret;
> >
> >       lockdep_assert_held(&tz->lock);
> >
> > -     for (i = 0; i < tz->num_trips; i++) {
> > -             ret = cb(&tz->trips[i], data);
> > +     for_each_trip(tz, trip) {
> > +             ret = cb(trip, data);
> >               if (ret)
> >                       return ret;
> >       }
> >
> >
> >
>
> LGTM
>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Thanks!