Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <999161da-4f03-42db-b444-d9f094163479@intel.com>
Date:   Fri, 20 Oct 2023 10:21:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 net-next] net: microchip: lan743x: improve throughput
 with rx timestamp config
Content-Language: en-US
To:     Vishvambar Panth S <vishvambarpanth.s@microchip.com>,
        <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <kuba@kernel.org>
CC:     <bryan.whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <richardcochran@gmail.com>
References: <20231020185801.25649-1-vishvambarpanth.s@microchip.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020185801.25649-1-vishvambarpanth.s@microchip.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGVjb2xMTW9senRpSTlqK2pOd3U5UGtTV2F5dkIzaHRTNjZLclBUV0Z5NEZY?=
 =?utf-8?B?ZkljdjlRaFQvaGN2dmFWbDQwZVd4enNjdWhCK0dZTEJ0anNBZ1BnL0NuSndR?=
 =?utf-8?B?ZUtSRnVnUHJhc1VJMEJFUHYxaTY3OHhmb0p5aTNlV21kay9GNDZoTlNMcWpx?=
 =?utf-8?B?Q2o3WWtYRzJtV1ZWZzBCeFNyNElRSXRUTE5TVC9mYmJUaHN3NXlyaVc4bmtl?=
 =?utf-8?B?L1BFK0tqR1E2bUl5TUNjNWw0cXNxK044eWhuR295R1NiYWwrS2JlOVQ1bDZE?=
 =?utf-8?B?dENqVDFHQlJDNDF0dlFJSlFnVmJ2OVc5NEIzZWN4Z0xvY3RNOEdYdVFUckli?=
 =?utf-8?B?TzRseXIyTWgvSjZSc21MQmRYUEUzQzhtdTQ2QmpIZENhUGt4dTA0dFloMkk5?=
 =?utf-8?B?MUhlQkFwalZteHcyaWR4MTR6bUZOM25qTUlNaGNCYkpBL0dVMnhucUgyQ3hw?=
 =?utf-8?B?U25DVE1jUHJOeDdWZzZvZk0yalF6N2h5T2Jibzl0cVFydnpQczZDR3dmNzhJ?=
 =?utf-8?B?NE13NG52YjYzaVBPdVpjdFYvQksyN1paVXNDblIyT1V2a3RSMlNoRWZQaVIx?=
 =?utf-8?B?NFhyRThRNHhjRmxDY1JMclRmZkwxVkF3QzQxd3VER2FKQ2FOYUE2Q0ZsZjAr?=
 =?utf-8?B?SzZtWjEwTW1vb3M3OFMzNzBiM01GODF3b2JxSjVWUnNyVVI4dnIzSm5DYktr?=
 =?utf-8?B?eEdmYmFmdlBwWWJ0eWt3MWhidlJRQmEvdHdpa2Iwb1FRNXVqektCb0h1aUNh?=
 =?utf-8?B?WngrRFE4YzgzN1daUURIUG14Z1pycUFzeTIvcWt1MnRhaUFCUXdVZVpFdENU?=
 =?utf-8?B?THpweVd1WEN6Mlp0TFhPS2RKMXBEeGQweEFac09yVnBuSk9TT1J2bmxKcS8r?=
 =?utf-8?B?Z1JYaU9LaU9sWW1LcFN4SHVvNGtqSmViam5BZUJpUlhrZm1abWlMRDdCc0ZJ?=
 =?utf-8?B?U1dEcHVkWTJiMGlxVFBkaUpCclVKZU9TUGlKZ0NJa0pWR2NlRytiZmdzc2dD?=
 =?utf-8?B?Q2FWQXlqQnRhUEhWUGRZbWxIWldjQTBacmJ5TGdXcnFaMWp4SWhOVStiemkr?=
 =?utf-8?B?WkgvQ2FGVWx6Q3ZlVDBkVUZ4KzZ0MEVDTzN2WURlNW0wWGlGQWNtLzJyc1pG?=
 =?utf-8?B?dUJ4ZEl4MUdTSnlxTEFGcHFTSEgyZTFxR2h0K3lqOWs1NjNYTTRYWGY0Mmp0?=
 =?utf-8?B?MCtHb1R5REZOZXhhVDcrdW9tblIyZ2dVQStHbzVtaFJhVG1aL3VWdHcrTEFQ?=
 =?utf-8?B?RE5lcTR4UTZXTkV6SWlvcERNT3g3WG80aGZwTTQzVWg3MHdja2pveHZ0c0Mv?=
 =?utf-8?B?UmQzWHczb2xodHJQclBEcmI5dFpUQTJuMHovZUNQeWFWZmFLS09iK1FDR0Ro?=
 =?utf-8?B?UHBLZytPTk1aV2FVcG10NXBlT1NhcHZaQ3M4Q205ZkMvVTVLWTd5bXorM3M5?=
 =?utf-8?B?UHhVdEgydTlpam4rYTg1QXhkcnRyMnIxSUlYTWR3djNPcythV3gwNU9jVDQr?=
 =?utf-8?B?bE5pc0N6UjJyb0g0S3QvN29NNzR3VXB2UThOWFJEcVJ1cmJySnVVZXArQyth?=
 =?utf-8?B?V2NndjZxWVlVengyelpocElpM1VobW5kRU42U1FqOEFrZ0pzbkhvWUZqYkhi?=
 =?utf-8?B?TUZXYUtGVjdtWHFhR2t2YTF5bDZtUEt2cm1EYzdvK05yWlhPaEx6TzRNR1pm?=
 =?utf-8?B?dTB2RVZTQ1dscVQ2RDllSWwrR1FUZzB5OGoxVGZBZUFFdUJtTS8wNWIyRzJv?=
 =?utf-8?B?cmkxK3krRzd3T01FM2liUzRYNW83RzNISTVNVlQweFl0MXU5UjhCN1R1WG5E?=
 =?utf-8?B?aERvRlZIdDN0dUNjcE9xMEc2WE1VWE5RNEVCQ0Z0VWsybzlOd3Fjd0Y1d1Er?=
 =?utf-8?B?THhuamJROUsvOGNTWHZaNjlUWWdScEEvbW14cktudjkyMHV0RzBnaHRhRjIy?=
 =?utf-8?B?ZUFXMnpRaEl2eUZteGUvbDhXNG1jM2lMemQrYy9LMzJBMjZRTzhQNTlXbFZY?=
 =?utf-8?B?U1hVRmd2dkRhL3UvdG5mTllGdmp4SS93SCswUitOQUo5b0x3aWQyM1ZteU8x?=
 =?utf-8?B?MmE2WU8wNnhoeTZoZ1lZOGNGQW9ITkJKQUdhZDVzUUxUaXI5S2lZQXFnenJs?=
 =?utf-8?B?NnZrQU1Hekd4WVhzbUlURTNYTWdibUhEalltVXo0eFNIZXYwajVtUHJUb3FF?=
 =?utf-8?B?bEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d2f6bf6-298e-4c57-6f6b-08dbd190f137
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 17:21:05.6664
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfTbUzzxyrkZM4lVVx1hw0UL9/F+/Htq3gQQzxcT9ggldsdghfhl77k/GXv0EWqqr8XFyl0gTCyqYbyxBUa6jZQeysD8z/AjIFq+SMkCpZw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6761
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 20 Oct 2023 10:21:26 -0700 (PDT)


On 10/20/2023 11:58 AM, Vishvambar Panth S wrote:
> Currently all RX frames are timestamped which results in a performance
> penalty when timestamping is not needed.  The default is now being
> changed to not timestamp any Rx frames (HWTSTAMP_FILTER_NONE), but
> support has been added to allow changing the desired RX timestamping
> mode (HWTSTAMP_FILTER_ALL -  which was the previous setting and
> HWTSTAMP_FILTER_PTP_V2_EVENT are now supported) using
> SIOCSHWTSTAMP. All settings were tested using the hwstamp_ctl application.
> It is also noted that ptp4l, when started, preconfigures the device to
> timestamp using HWTSTAMP_FILTER_PTP_V2_EVENT, so this driver continues
> to work properly "out of the box".
> 
> Test setup:  x64 PC with LAN7430 ---> x64 PC as partner
> 
> iperf3 with - Timestamp all incoming packets:
> - - - - - - - - - - - - - - - - - - - - - - - - -
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.05   sec   517 MBytes   859 Mbits/sec    0    sender
> [  5]   0.00-5.00   sec   515 MBytes   864 Mbits/sec         receiver
> 
> iperf Done.
> 
> iperf3 with - Timestamp only PTP packets:
> - - - - - - - - - - - - - - - - - - - - - - - - -
> [ ID] Interval           Transfer     Bitrate         Retr
> [  5]   0.00-5.04   sec   563 MBytes   937 Mbits/sec    0    sender
> [  5]   0.00-5.00   sec   561 MBytes   941 Mbits/sec         receiver
> 
> Signed-off-by: Vishvambar Panth S <vishvambarpanth.s@microchip.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>