Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
MIME-Version: 1.0
References: <20230824091737.75813-1-davidwronek@gmail.com> <20230824091737.75813-4-davidwronek@gmail.com>
In-Reply-To: <20230824091737.75813-4-davidwronek@gmail.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 20 Oct 2023 14:42:06 -0500
Message-ID: <CAL_JsqKG0icvs1y1SMpdgk9mTk9pFziPo2YFjwhcgdkHdaV6KQ@mail.gmail.com>
Subject: Re: [PATCH v5 3/4] arm64: dts: qcom: Add SM7125 device tree
To:     David Wronek <davidwronek@gmail.com>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        cros-qcom-dts-watchers@chromium.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Aug 24, 2023 at 4:17=E2=80=AFAM David Wronek <davidwronek@gmail.com=
> wrote:
>
> The Snapdragon 720G (sm7125) is software-wise very similar to the
> Snapdragon 7c with minor differences in clock speeds and as added here,
> it uses the Kryo 465 instead of Kryo 468.
>
> Signed-off-by: David Wronek <davidwronek@gmail.com>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sm7125.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm7125.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7125.dtsi b/arch/arm64/boot/dts/q=
com/sm7125.dtsi
> new file mode 100644
> index 000000000000..12dd72859a43
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125.dtsi
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2021, The Linux Foundation. All rights reserved.
> + */
> +
> +#include "sc7180.dtsi"
> +
> +/* SM7125 uses Kryo 465 instead of Kryo 468 */
> +&CPU0 { compatible =3D "qcom,kryo465"; };
> +&CPU1 { compatible =3D "qcom,kryo465"; };
> +&CPU2 { compatible =3D "qcom,kryo465"; };
> +&CPU3 { compatible =3D "qcom,kryo465"; };
> +&CPU4 { compatible =3D "qcom,kryo465"; };
> +&CPU5 { compatible =3D "qcom,kryo465"; };
> +&CPU6 { compatible =3D "qcom,kryo465"; };
> +&CPU7 { compatible =3D "qcom,kryo465"; };

This compatible is not documented. Please add it.

Rob