Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <0329924b-a868-49b9-ab98-0b3f8bd545cb@intel.com>
Date:   Fri, 20 Oct 2023 13:13:08 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next] net: sched: extend flow action with RSS
To:     Hariprasad Kelam <hkelam@marvell.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        "sridhar.samudrala@intel.com" <sridhar.samudrala@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "David S. Miller" <davem@davemloft.net>
References: <20231020061158.6716-1-hkelam@marvell.com>
 <CAM0EoMkawLKubMdrTOAcOhYq8Jicc5XuXuytBVi-yy-_QgiTuA@mail.gmail.com>
 <PH0PR18MB4474C304575E55092A2C7377DEDBA@PH0PR18MB4474.namprd18.prod.outlook.com>
Content-Language: en-US
From:   "Nambiar, Amritha" <amritha.nambiar@intel.com>
In-Reply-To: <PH0PR18MB4474C304575E55092A2C7377DEDBA@PH0PR18MB4474.namprd18.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXVIekk5ZDF1S0d2YU9sNllTN0NQdGlVVng0aG41MXJnK1BNbko1VzFXTUFn?=
 =?utf-8?B?OUhkOUFWNU1xbVRib3NGSjFmZ0N0WCsxQnpSNW0yRDNGKy9UenM4N3Q3SUQ5?=
 =?utf-8?B?Ni9PT3Z3ZTBPekVEWjdmYlVUMW9RSWFPbFZpbWF5RXFnMnlXWDdRRzhWb2hm?=
 =?utf-8?B?TG5VWXUwdEtkTXRndlpiYXJHK1ZvdkZsL0txSUdKbFhTVGtVYzQycUNhelpO?=
 =?utf-8?B?MHgwMUt6Y3hOcGZEeXdPc2tTdVlCZzN5UW9GVk9yNm5seTVzQUNYOWJwSEdl?=
 =?utf-8?B?VGVCd2NZbmZOUWZzNUdoSUFrMXd0T0xsM2JZZ21yV1daUmd1UDlkeVVla3Ax?=
 =?utf-8?B?RDRlR1pMYWJjVlVIcXBmeUluK1pLQS9mYnRtcmt1ZkZncGY0Qm1EbGpPSW44?=
 =?utf-8?B?d3I4ZU1NZ3U4UnBZNjN2Z3ZIRWdYUExjcjZpRDNrMFFGdHNaRzNpRjFTSnVu?=
 =?utf-8?B?N1hkMFBJbUFIS3J0TG5RVHRRS2w1MUJKUGdYOVljUVVaRVFDRmp5Vlh0T2lE?=
 =?utf-8?B?TGkyYlppaFlhdUhZR2RtbWNrQmJXOEZoNjVtR2s3U0NFS2U2N0ZNYWoyaFdh?=
 =?utf-8?B?Rk93d3NETjdCQXVjbzlFQ2Y1bm9rQlVzVVZHYTQ2a0wzTlhud1VTckMzd1pQ?=
 =?utf-8?B?LzN3ei92RTFGeHg4ZWJSeUJTR2JsZElsU21pYUR6LzVPZGtIVEExb2JkeGdG?=
 =?utf-8?B?NzlpWkpIeHlrazk4UjdjdFNNY1N4bGtoYkEzc29LZjlVS0xpbS9POCs1dUxS?=
 =?utf-8?B?UjI3Y1RMSzlBalN3eEhqZmZJVjFXV2hjMExvbEh5ZjhVZXhFUmdRcTNYYldv?=
 =?utf-8?B?anFzSlZxSDhIWHplZzYzbUV6ZllxRmZwdExRd2h2Yi9tVUtKSHdEV3BTdWpq?=
 =?utf-8?B?ZXZCOGZSTTlPa3d5QXJwMVRHb2l6NEpWN1RFdnc5OFlGdzRqYkxLV3BPQm9y?=
 =?utf-8?B?MUxWaUorZjFZU0FsdGJodnhaVlJvVEtEVk1qOGtkb2RXem5JdW8xOU5ldTBG?=
 =?utf-8?B?Q2tMTHlJVkFCdFh2WmtiQ0k1TDEvRmYxcEJSRU5Jd08vdVVXMC85N245Y0J3?=
 =?utf-8?B?MUplb2lxcE1uTjN2Y2VkaC9TOUlQWmVCTWRJV2ZFbElPRU9hdmtKM051dHFJ?=
 =?utf-8?B?RTVrODZ1VGJXZEl0UkRLQm1PM1JmZ2M3aTl4ZUVzeis2NmQ3K3lvdzFmeTcz?=
 =?utf-8?B?QzJvVXlrZGZRME54SUJ0NDUrRHNid2d1VkpiSHpwNnJEUzVwczV5YlNDU21Q?=
 =?utf-8?B?bzFNbktWdEN3N0ZrbUdVTnNoYXYzdU1XQW85ZmRURHlpMmxUREN3NzRhSFdK?=
 =?utf-8?B?QWFWZ0RjTDlRWWlQV2F6UkEzbGxScXhKSjBGa0xScUh2bUFLUEsvVEw4RnhW?=
 =?utf-8?B?c0NVWHh0cno0OG9mZEJ0MXc3OFk0SXdzdUZ3c2Erb2NiMXU1U3NDbld2eC9F?=
 =?utf-8?B?c2tGbERYZi9US3d3OXlzTkZkbGkva0Rsd0pqbGw3V2tQaUFnNm9LOVBOeWt5?=
 =?utf-8?B?N1ZJdWhONVByRzh4bXZnbHJlc212Qzg5WFQ0TmE0Y1Jhd1FlWEtCcmRZeEFW?=
 =?utf-8?B?akx0YmxVVjhQa3pKcUdpYXV0eVlFWHNTcWlkK2lKTGVlMmJqNFYvYlhGdTB6?=
 =?utf-8?B?SHRtSVl6aUJOQTUvTUxuMXdXUEhGUTlpd0tZNnlyenljd01kK3hrdjBYdXd0?=
 =?utf-8?B?emFuWk9QclVHWVl2NXNZSnFnVGpzZDYvbmpCNS94KzJ2bmxQeEIyYlAzWHJU?=
 =?utf-8?B?REJmOGZKMWRBYjZkWnlSV0thaUM4cXo1MmlHbW9jbVlZYlZzdXhGV0FNSjVh?=
 =?utf-8?B?QThBOW4vNE9LZFhXRkd1VlNKMkQvL1pTVVJOSjJiY1U5djErd2dkRjUwSTU1?=
 =?utf-8?B?QmlxeGZSVFlMdHBFdWZSMHI2OHdtRUsvNWpDbEdNRklJbzhQUzNscnRBYzJz?=
 =?utf-8?B?MmV1d1A1K2ExZTlFR0gwVHp2TXoyTklPRDZyR3ZyN05EY2Q0QjJmUU5zekIv?=
 =?utf-8?B?QktzOWxseXlBa2FkZW5TbnFKQ3B3cGxHOTR6aEJlOHlxR2g4T0psTG00N2I5?=
 =?utf-8?B?Ni9HdVdrVkwrR0RGVmpsTEpKdUhxS1AwYyt2THNIOFpzVnZ3d2czWm9TcFFR?=
 =?utf-8?B?VER4VjBHVnppaERvbmN3UEpPL2dmUTlBMnhNL2wrc1ZuTkxiNXVvZHZHWi8v?=
 =?utf-8?B?Z0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b0500a3-cfed-4204-fb09-08dbd1a8fce1
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB7869.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 20:13:13.2256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1wGPJuBj/p21O8lvmX4H7FKQjeFz68AKY+khS9rL1+fdA13sK+Tlvl4q9r50XLZ7okGID2Vq/KaOIjCodG4kCyLEbKdHGGHhijOtcPV2pSg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4991
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 20 Oct 2023 13:13:42 -0700 (PDT)

On 10/20/2023 9:35 AM, Hariprasad Kelam wrote:
> 
> 
> 
> 
>> On Fri, Oct 20, 2023 at 2:12 AM Hariprasad Kelam <hkelam@marvell.com>
>> wrote:
>>>
>>> This patch extends current flow action with RSS, such that the user
>>> can install flower offloads with action RSS followed by a group id.
>>> Since this is done in hardware skip_sw flag is enforced.
>>
>> Our typical rule for TC is we need s/w equivalence for offloads. How would
>> this work in absence of offload?
>>
> [Hari]
> Our typical rule for TC is we need s/w equivalence for offloads. How would this work in absence of offload?
> 
> This patch we added as an extension to receive queue selection in hardware.
> This patch "act_skbedit: skbedit queue mapping for receive queue" enabled receive queue selection in hardware
> and skip_sw is enforced.
> 
> Adding stakeholders of this patch, to get their opinion.
> sridhar.samudrala@intel.com  amritha.nambiar@intel.com
> 
> incase of RSS, hardware makes decisions about incoming packets before they are even received in the queue.
> 

The skip_sw for skbedit receive queue action was enforced as the only 
other alternative was a new hw-only action, or changing the action 
mirred. See discussion at 
https://lore.kernel.org/netdev/20220921132929.3f4ca04d@kernel.org/

Few questions WRT this patch:
How are the rss groups created? ethtool rss contexts? Any reason to use 
TC to direct to rss contexts over using ethtool context ids?

IIUC, skbedit is meant to only edit skb metadata such as mark, packet 
type, queue mapping, priority etc. Even if this is a HW only action and 
has no use in the stack, would skbedit be the right fit here?

> Thanks,
> Hariprasad k
> 
> 
> 
> 
>> cheers,
>> jamal
>>
>>> Example:
>>> In a multi rss group supported NIC,
>>>
>>> rss group #1 flow hash indirection table populated with rx queues 1 to
>>> 4 rss group #2 flow hash indirection table populated with rx queues 5
>>> to 9
>>>
>>> $tc filter add dev eth1 ingress protocol ip flower ip_proto tcp
>>> dst_port
>>> 443 action skbedit rss_group 1 skip_sw
>>>
>>> Packets destined to tcp port 443 will be distributed among rx queues 1
>>> to 4
>>>
>>> $tc filter add dev eth1 ingress protocol ip flower ip_proto udp
>>> dst_port
>>> 8080 action skbedit rss_group 2 skip_sw
>>>
>>> Packets destined to udp port 8080 will be distributed among rx queues
>>> 5 to 9