Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
MIME-Version: 1.0
References: <ZS7PIHUZfHcrfvi4@kernel.org> <CAM9d7cjkFQU+dd8m8pq6-u6JruY9tFi_86ZyiQrXGL9js_vuuA@mail.gmail.com>
 <ZTLkWVempj1xV6CV@kernel.org>
In-Reply-To: <ZTLkWVempj1xV6CV@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 20 Oct 2023 14:15:03 -0700
Message-ID: <CAM9d7cgW7PmgSj3kAowFOVLG56L=QHVCU=PfM+p7sVfQyJrt6Q@mail.gmail.com>
Subject: Re: [PATCH] perf build: Remove stray '\' before that is warned about
 since grep 3.8
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Ian Rogers <irogers@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Fri, Oct 20, 2023 at 1:34 PM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Tue, Oct 17, 2023 at 12:02:20PM -0700, Namhyung Kim escreveu:
> > Hi Arnaldo,
> >
> > On Tue, Oct 17, 2023 at 11:15 AM Arnaldo Carvalho de Melo
> > <acme@kernel.org> wrote:
> > >
> > > To address this grep 3.8 warning:
> > >
> > >   grep: warning: stray \ before #
> > >
> > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > Cc: Ian Rogers <irogers@google.com>
> > > Cc: Jiri Olsa <jolsa@kernel.org>
> > > Cc: Namhyung Kim <namhyung@kernel.org>
> > > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > > ---
> > >  tools/perf/Makefile.perf | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf
> > > index 456872ac410df4c0..25d5ccaec22a44fe 100644
> > > --- a/tools/perf/Makefile.perf
> > > +++ b/tools/perf/Makefile.perf
> > > @@ -361,7 +361,7 @@ python-clean := $(call QUIET_CLEAN, python) $(RM) -r $(PYTHON_EXTBUILD) $(OUTPUT
> > >  ifeq ($(CONFIG_LIBTRACEEVENT),y)
> > >    PYTHON_EXT_SRCS := $(shell grep -v ^\# util/python-ext-sources)
> >
> > Do we need to change it here too?  Otherwise looks good
>
> I think I did tests and simply removing the \ in this case will comment
> out the rest of the line after the #, IIRC we would have to enclose it
> in '', like
>
>   PYTHON_EXT_SRCS := $(shell grep -v '^\#' util/python-ext-sources)
>
> But then if it works as-is, why pollute the patch? :-)
>
> In general the less lines you touch in a patch, the better, don't fix
> what isn't broken, helps reviewing, etc. :-)

Agreed, thanks!
Namhyung