Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <71530e57-49d6-4df8-8968-899c8777e86e@intel.com>
Date:   Fri, 20 Oct 2023 14:19:57 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 1/6] i40e: Remove unused flags
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231020193746.2274379-1-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020193746.2274379-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVNIUStpRllRWU9GUm5lRktIQUs0aytDM2Q4TXhEUzBybUNqdkdUWEtueGF0?=
 =?utf-8?B?YkpUeHhaZUZoTm1nUkg0TVBCSWsyVUp2U0NxYURLR01oRmV6RERhbExneEtu?=
 =?utf-8?B?SUU3bGJ3VVJXcU9zN0FDK3BkcVU1Qklvd0tydEh3MEVNUHY0K3BhZzZGZk1J?=
 =?utf-8?B?SjVOUzJuS0wxOTJYQThabDZvenJMK3g0WGFJbTR0TGJNVE5VazRtUllnYlY3?=
 =?utf-8?B?bDdkYUN4SGJ5OWluNEFRVXBxVE0wOFE0TW9saDlZM2dUa254cVcveWZyTjRD?=
 =?utf-8?B?aGRmMDNxWVJJTHFNQVovdm9ySHZjOVV1UFI2MTZwTHpPQkhQV0RhY1hGV3I3?=
 =?utf-8?B?VitKa3Q4ajA3WVhXK1dIcDFnR1lvSjgrZ002RnJEKzRXZnl3QjVNcUtVZnpv?=
 =?utf-8?B?cWhQWVVydmt2T2JjeWZ3NjBhZVRKZGJUWTRiZFN2UGVraDFyRFRORnNDYm44?=
 =?utf-8?B?Mjk0NkRXeHc0MGFpTWlQdUxUZEgycmNMNlg2WFJyRVkvV1JEazFFa1hIRDNz?=
 =?utf-8?B?OGNEVVJlZW5hTFBlRlhyS3NpSGtRUTZCb29iMDA1YWlpcFdweVR0bDlLMkJ3?=
 =?utf-8?B?cXI0dC9jaHhITDhhTXY0c3BpY2ZmNWFFU3pMZGlUZVRld1gwMEsxTW8yeTJL?=
 =?utf-8?B?N0xKZ3lZc25takw5ekloUDdhUk1UWjQ0c2txUHFBVytQR3RQREhjaW16YWJP?=
 =?utf-8?B?eTFCdmpwRGcwSFAweWRMdjBQVk54dC9hcHdXZTEzRFgxYmhtU1VqSDdISGR2?=
 =?utf-8?B?SHpMRGRCQkZCWlRZR0NuTWIrbmt5amxPWjc4Wk9rbWxxOHcraVRsN0NON2Ey?=
 =?utf-8?B?ZnJOQnZGZWdMR0JLRkVydy9hZFI1K2owMlVyWGdEdk1FWThyVHBKSlJQNzBj?=
 =?utf-8?B?VGh1cEY0QkVtSXRobHhiU0JKcC9lc2IwMkFaRjJlcFFIZGlrQ0JXMjdTaGoz?=
 =?utf-8?B?eWZjUEw3R3FaS0s1cE9JaHNEb3VkYjJKZ0NjWlN5MmRNSWwrQ3BTbG84UVNM?=
 =?utf-8?B?dzg1WXhoQkVWSmh0YTdqb0o1WVo1bVoxNGE0dUdKZ2FTZ2RZMm9FQ3A0REhE?=
 =?utf-8?B?K2NXRXNZbXJtZFgrN0VSdlhzNlhPakl5ZjdETVRqdW5pRW1PSktCUmVoR0J3?=
 =?utf-8?B?SFpEYXNIMG1UV0h5NUx4dVBlN1RJOUsyWGlNd2gyTkdWZWRwb1RwdGdieVVj?=
 =?utf-8?B?UUFndkRsNlhSRzdVU3ljSGVET1N4UUViTGVQQVU3T2tEeW9FM1VtYzRCQVZ3?=
 =?utf-8?B?ZjY4bjZLYXROZFAzcmtUZ041UDZsZ2NkOXZHSHBtSGd1bnpXc2JyRnFmcTJO?=
 =?utf-8?B?Nm9XWlphUUtFRHM0dVUzUmZES0l6NEdNT21uUmw1TDNLakMyTXNzWXM1YlAz?=
 =?utf-8?B?S2g1R3d1cys0ZzREcVUzSlY4dDBmYXgzWldPWTlnRGRXWkxVdTNzYU8zVHVz?=
 =?utf-8?B?NlFvM3pSVzhKVTUyZXFTcWNVVnNVcEFUNzVSaitEK0JjVlhTcmp4dEN4YWJs?=
 =?utf-8?B?T3FoM09LUC9PcUlDUDJEczBxUC9xSDlkbDhZekwvdUpocVdVcVpsME9pR3Bo?=
 =?utf-8?B?T1Q0cWxCODNBZzc2OURPOTRFL0h4L3gyZlFtSXdFQ1dtM3ZZQmhHK3BJWHIy?=
 =?utf-8?B?bXlaRU1MWVVFRDI2TUxmbkMvYVlUTDlhbXI5YlpqbWc1WFJiOVVqdVYxMWQr?=
 =?utf-8?B?b2F3QXNGMEpQdmlHdTJ0Wm5NNFByd3dpejhSTTg1aElOMEc2cUVMUzBseWRK?=
 =?utf-8?B?RGRBTFBmWWErYXNwT3V5dDNKU1hzRDZsRXcvWFJVcExkTSsrYW5UWjJWeFli?=
 =?utf-8?B?eU04dW84WFY3cTJGcXlLYnJpVTBYbTN2SmVVYVlvUVB6cGNDTHlvcmtyMTNS?=
 =?utf-8?B?NlFnS1RRYXRXV3phUlJreXN6NEo4V1dvaHZ4T1NuNDVCUyt4WkNpS1FBU0V4?=
 =?utf-8?B?US9jT2hkakdENWtsM3VFNFgrQUt1c2s4dHg5b2NleHlZY3M2RFdMMlRnSHIy?=
 =?utf-8?B?QmRGMDVJZllXcnhjc0RlNE5FU1hHNXRvdE0vYWczZ1d5cFM2NHdaS2FMRlRs?=
 =?utf-8?B?QmpIbldIMDdMNzVreUJkUE1xY2d1YWZvWWJEVU1EbS96ZUdRdzFMazg1TWs1?=
 =?utf-8?B?dWVtWC9zc1JHbWV4eHZOTTVnaU5ZdUR4VUVZZWVpd29RSGVsMjhFYnoxTjFC?=
 =?utf-8?B?eXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 10a89346-9f8b-4b4c-5b90-08dbd1b250c5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 21:19:59.4103
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZC4iul0yQb1xIPCqINHbsK5/TMZffEmzje2yM1MfUO1OCNzLZs1fvAbCuRFZ0aI2GrMeZa9X7bNPCfZO4AgtLkpmokSon/5QdbkyymuPIg8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5598
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,T_SPF_HELO_TEMPERROR,
	T_SPF_TEMPERROR autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:20:47 -0700 (PDT)


On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> The flag I40E_FLAG_RX_CSUM_ENABLED and I40E_HW_FLAG_DROP_MODE are
> set and never read. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

You could leave the bit positions as gaps in this patch to avoid the
clutter of re-numbering them since the series is converting them to be
automatically defined.

Not worth a re-roll over that though.

Thanks,
Jake