Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Fri, 20 Oct 2023 22:21:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Mark Hasemeyer <markhas@chromium.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Curtis Malainey <cujomalainey@chromium.org>,
        stable@vger.kernel.org,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v1] ALSA: SOF: sof-pci-dev: Fix community key quirk
 detection
Message-ID: <79d83b16-518c-4fb1-9652-662a552e3ef3@sirena.org.uk>
References: <20231020145953.v1.1.Iaf5702dc3f8af0fd2f81a22ba2da1a5e15b3604c@changeid>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bvpm8AcR9ruTek1u"
Content-Disposition: inline
In-Reply-To: <20231020145953.v1.1.Iaf5702dc3f8af0fd2f81a22ba2da1a5e15b3604c@changeid>
Precedence: bulk


--bvpm8AcR9ruTek1u
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 20, 2023 at 02:59:53PM -0600, Mark Hasemeyer wrote:
> Some Chromebooks do not populate the product family DMI value resulting
> in firmware load failures.
>=20
> Add another quirk detection entry that looks for "Google" in the BIOS
> version. Theoretically, PRODUCT_FAMILY could be replaced with
> BIOS_VERSION, but it is left as a quirk to be conservative.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

--bvpm8AcR9ruTek1u
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmUy72sACgkQJNaLcl1U
h9AxzAf/Ys7JElKki9A5mFI+I/HvoapP5WVYJNn5ppsCL/Dr6gn1KkfoZxqx7csY
OC1getUOZyrh8/6iqxWKOyyfd6M7wi/CrRYVyRVRnKngH9f9B92K8cKa8HQI3o2t
MvTmnMvg4w0Cpb3scmXznUv6XjdE7pkjHiK4A5OQ2KjiJqjXmqvo7OEOr/D4FNEn
VOMJOG7zCxIfqS121p9ko65ovDfgvrT5FeJBuHeURQkIKXphtP2W5NzwitML4c4H
wBqJd7ZwkikVYzZOSdAXRVQY6huD79jPrbERTp9bDIrEkFsDO47Q9XmxCnl1A4gs
lz5u3eUIF++Y/RxoX9dxNSj4Zh7DTg==
=Bm0n
-----END PGP SIGNATURE-----

--bvpm8AcR9ruTek1u--