Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <02bc1b64-d53b-4dad-a1b6-d992f03ba4b6@intel.com>
Date:   Fri, 20 Oct 2023 14:24:09 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 1/6] i40e: Remove unused flags
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231020193746.2274379-1-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020193746.2274379-1-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2Jjd3l4dGRnQkpNRzZLQmI1aVZDc2VleExsNEUyYlZldXhCMlE4a0RETnNT?=
 =?utf-8?B?R2JjUUpmcFZpUDAvZXNmYk44WXVoVnRiSi9Bc0RhMXJITFB2RzUrdEVzajRn?=
 =?utf-8?B?RHpJYU9sVnFqWWU4V2xyTWt3VnRzbVRQdXlYVnhkdkdCcjRscTlQK2xtVVlo?=
 =?utf-8?B?amw2em0zcEtiTUZjZEFneUV0MzFwbnVwcTBOLzkvbUFDcG02dERTMTA4QWhJ?=
 =?utf-8?B?TDY5SWFaVWlKSnVXeDJKeUc3dGYvcythKzlLSjNzVzlWRURVVk9zSHZrcWk3?=
 =?utf-8?B?bVBlNU1NbElJSXNkUW5ldytUWEtTUys0NVl5YkFaMTROaW1pOXBJVnRRb0c0?=
 =?utf-8?B?ZjJRUkhMVjZpT2hXc0EvUHZwazJOQ1Vvc0s5OFhZMW5hUktXM1FoSS9mTDVm?=
 =?utf-8?B?aEsydXFsRlRlZzdpVmliSSszVFV0MnhzdXZ6dnJtaWoyTTM3cUpQdGNOS3FO?=
 =?utf-8?B?ellOc3lUS0ZGczJTVGYyU2kzVmhhVzhFbHhZZDIvSGhxMXdScFdaSHZJZ0Za?=
 =?utf-8?B?djRlTk9zSlUrVXV5b1p0QmRhVXVvOUxCYkE2cVk0ZzNjMFA0clFpTXdPUk5v?=
 =?utf-8?B?YVJ6NUoxZ0Y5NmNTOW45emdQdERXaHNsVi9STnFJa3UrMGxoYm1qSkhmcSt0?=
 =?utf-8?B?WTlBZGdSSFAwSE1iYnhvRE5NZXdhQy9MZTcwbE1pd0FMSTBRaTRFbkJ2d0hD?=
 =?utf-8?B?UDNWQ01iaW5Ucko3WlpLU2wvdDJEZzN3U0RhMGl2TUFCb3ErNVRWa0ZmaEVu?=
 =?utf-8?B?cC9lYVFnRTRSOWdDRmlGeXVEUk1HZW5seDQrbFdTVU1CVVlpcVduOExwc3hz?=
 =?utf-8?B?SXp0OFZEb2FrM04xVmZkVHVUaUlhTC9VZzVkNVdiQVVwNTZJV3hjS29QU0hM?=
 =?utf-8?B?R2dSMXRDUmpYN01hTHU3MW53dDlRa0tJRnZxaGRHRHFwQ2pDZXd5RWVtOGEw?=
 =?utf-8?B?NWhtdWlocWpSTUtQY0NDUlNWZkRkbVd5aXhFcGorS21XQjBSSlZXbjloZjRO?=
 =?utf-8?B?dytvaHo2d2VCS1V1M0RoV2hrcEY0cncxSVpNNzd3REJwakIwV043KzhRTjVC?=
 =?utf-8?B?WWtMQzJhWTl2SVg2TDB0ZEswUTRTZ3oyTDNLcmZwaitkMzdhMzVKYmVQd20v?=
 =?utf-8?B?V0JLOC9xZlZEMDJXdTBPbnhqVmRKcXdsUU5DV0JoN2x4aGlySzFDS21rK3g3?=
 =?utf-8?B?Tmh0MmtBT2YxUDdUZEd1ZjJtNjUvcmZSSUFNd1VDKzE2Y0lOcHcySEFLSjlX?=
 =?utf-8?B?WDlCOE5rZGZHVzkyMEpZbC9KL0d3akJEbEcxTFRqZFBCVllqZG1Ecm9seE43?=
 =?utf-8?B?cjE1N2EvZmM2MnpIRlhGMlJqRmZJOVBjWmQ4TWI5emx1QVllM1NNQkpNOW9F?=
 =?utf-8?B?STNFcEVuOFc0bUhGZHhvRVpIVnVySG5jK1ZxdWVLUlZyOHNrWHppMzF6NnFj?=
 =?utf-8?B?cnF0dFA4VUx1MWp3U0dyVnB4U1dCZmJzWmRQOHhsbEJOa2tlc25FWFQxU292?=
 =?utf-8?B?N2dsOTdsM2pPdmZITkFPaVhtbkZrSFNWTk4vNlpoeHo1SkdzcVR3ek5obks3?=
 =?utf-8?B?UmdoS3o0cDR4bkx0M29sTUtKUWhPOTFLQWt1V0ZSdWp0WUZmVUI0RnpPQUpE?=
 =?utf-8?B?MG1od051dFZCdzBkRjBOVFhFMlVlWnhkS2VTMnlwaCttMEttdGJUSE04dHJT?=
 =?utf-8?B?aVRuN0x1N3BLM2pxZ0xGK0lUSlRkS1pVRnMxdDN5WGdrckhCcVF1WmYwN2lq?=
 =?utf-8?B?eGhoTzd4YlFvYjBycnBRekhnSW44ajY0SHI4K1dUcHd1TlIyd0cxdGp5M09P?=
 =?utf-8?B?UTUzdWpuanFaODZUZ2tla1VBNFhXRU1rNFl6YnpBSno2TGNxR2hENkRBSm14?=
 =?utf-8?B?TEdaZnNXa3E0YUtFWWhkUkZHazRRS01ERVhaUkdyOUFIaS84V0dFK3k0MkFm?=
 =?utf-8?B?OUg5S0hCRm10NkhPK1d0M3R4WE9UVUw0eVpXYndVcDVHYmNaQm5UeWhmTkJM?=
 =?utf-8?B?TDJMMXRkT1did2hjT2s0cGVtOTNOM1JkZ3FiMlNINUM1bWpHc3V2U1dBSkhq?=
 =?utf-8?B?a0lRdEp1NmsyalcwUks0Y0E5aldpRHRqRkhFSnd5a0F6cjk4bHBKNDIzbmNW?=
 =?utf-8?B?alppUW5WdEY3WnhjblV1S2FpRjVCY1BIN21QeHB2Q1ZIQXNpVzc4Z1I1YklF?=
 =?utf-8?B?WHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 283985eb-34ea-46ac-9302-08dbd1b2e6b3
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 21:24:10.9232
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FxGTVBmVM/X6i3/Ukx7bdOzv9eunhGY0+Nh8f8Z89OCLF4qBGTsQmce4sqB87sFtaO/xmcY1Pnlv/77nzE0FXhQpl7mm2OS+bMEE7MjROCs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4539
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:25:02 -0700 (PDT)


On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> The flag I40E_FLAG_RX_CSUM_ENABLED and I40E_HW_FLAG_DROP_MODE are
> set and never read. Remove them.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---

In case others are interested, both of these were literally never used
in the driver besides setting:

I40E_HW_FLAG_DROP was introduced in commit d802c760ab87 ("i40e: Add drop
mode parameter to set mac config") (v5.4) and was never used.

I40E_RX_CSUM_ENABLED was introduced in commit 41c445ff0f48 ("i40e: main
driver core") (v3.12) and was never used.

Thanks,
Jake