Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <dadb40dc-3e09-470d-9eb4-8c725249aabd@intel.com>
Date:   Fri, 20 Oct 2023 14:28:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 3/6] i40e: Use DECLARE_BITMAP for flags and
 hw_features fields in i40e_pf
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231020193746.2274379-1-ivecera@redhat.com>
 <20231020193746.2274379-3-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020193746.2274379-3-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkNRUXNKQ0VJTk5GQ3N4UXR0REh5bEltRWttOHJOemRPdDJPNTFPVm1hRTJv?=
 =?utf-8?B?Mkx5Tno2dzRTSUkvSExGT08wRjVrZ2tOcTR0VFFsYVE5cmprV0QySXdVMXE4?=
 =?utf-8?B?bFE2Sk5tbEhGamw0R3RVbG1zSTMxeFVrMElwZ2liOTljRk5hUWd2VlVDWCtP?=
 =?utf-8?B?UEFZMmh0Vk9WeDZvK0huK2NXZ2VMcXAwMFlOUDJTaFdpdmJCZUJPL1RTWW13?=
 =?utf-8?B?UGE1TnROckVyYitXTC9JQ2JXeis2S1VIMC9CYWw5eEJVd201dzZJVUcxVnlE?=
 =?utf-8?B?SzIyTkEyUUFaRkR6VGNBL2Y0a1p0azQ5bCt3bHkvdjJrckVZYStqV3lXVlBL?=
 =?utf-8?B?MXlCbkN5VzBaanhHU2NkZnBQbFdtcFR6SjlLNlJCS21DTmQxMkN2UTNmMjQw?=
 =?utf-8?B?QUFXamZmYnZ2cVh4QnQ5ZmdiWmxBeGVBdis2KzBCdDZ2RzlvOEVKcEVSbFZT?=
 =?utf-8?B?bEV5ZlI4S0p2eTBEdzlzZ04xVDcvUEdjcGhZL1VJdEZaeGV4YVE2U1FwQWlG?=
 =?utf-8?B?MkgybDgrNjRydXc4aDNPS3lzc2ExYkFNbDhCa1FJbnJpeHJDNGwyRzNML0FW?=
 =?utf-8?B?SnlRSWpGUWQ1a3hBN2lZTWNJejEwZkFHMGVvaGxETXdJTTZzRDI5R1M3YU9L?=
 =?utf-8?B?M2tlb1F4L1kvTkFlZEE1OUFHWjBBeks3dlcrUzNTenN4TzY2Mk5pR0dpd1c0?=
 =?utf-8?B?TW5uZW9WeTltdEQyQ1NzVnpVTU5INnZXY1U3ekZYSmt2NmRmT25OWVlENjZ3?=
 =?utf-8?B?UENjMTdnbklnai9HSjVoNGcyczd0QnhzNU5kT2FEbFVuS2IrdFJHSHF0YXI1?=
 =?utf-8?B?UGVZRlJiWXJtb3llYmdIUjJjTlUrWlZWN0w4VFowWTNyNGU1dlljL1Rzek1n?=
 =?utf-8?B?b1A2V3JJVEVxb3BEVVdoRG50blJUS01nTm5Od254YjRGYkl3MGN0Y3VLQ1lH?=
 =?utf-8?B?c1ZjSDdTSmZ3WGV0ekc4Z2xpS1ZHMVJsY1VmVTl6YmJBajFub3lXc0gwTGly?=
 =?utf-8?B?TVo3Y2dydmthMlRGQkt2bGsyTG4zRHhhR3JuVkFvWERjUnh3NmI3VjVKSThJ?=
 =?utf-8?B?MHIzN1ZqVTVEU254bkhpRG5xZ3BlT2hZR0pEaDF4WkRiNE1yREo0VXl4eGNM?=
 =?utf-8?B?YTQwMXN1d01uWlZoTjgzeW5LbTBidkZqV3ljb1A4dnlLWHFJSWZncGh1dCtM?=
 =?utf-8?B?Rk55K1pDamlOT3NGVXZFWDdEWWxkSllRWGlwdEZwQi9DYktIcVM4eXhZMEt6?=
 =?utf-8?B?bFZaSjk1SDlWQ2tpRUlOSkRLeEdtdWg4ZlJKVU9KYk9WcjJleFl0c2FhZFI2?=
 =?utf-8?B?TkhDUHZSYUd5V2FQdU5JZEp6WVVHQUU1MTE2YkRjbFgxWjFwQ2ZxWkhYbHY4?=
 =?utf-8?B?L3ZvNmlJdDlESVlXQ0p3dWF6YWpVNkxEN1BwQmdtRnFVYnI3dFJEekFneURR?=
 =?utf-8?B?SnhxVmFYRCtGaDljdkxIcE9lM3FGM21JbTRTd0s0SlB6bnVFNFNkaHVuaUVC?=
 =?utf-8?B?YUdsQmZiRTFORzJZK1ltQm9hQkhkWjcrV0l2Njhjc09QamVaZmZiMVZJVjAw?=
 =?utf-8?B?NUVTdzZCWGdjTzB5dGVMd0U5RkFYOFVPRVVaR3BiV0ZETTlvNGUyM01hbWpX?=
 =?utf-8?B?MitaRTRPRVlocFN1dzRNQ2pHZWdmUTVsY0gwZzBMS0FNNGJmLzJIdkp4MVBl?=
 =?utf-8?B?VkxCbW1wbm5xZkM4VEtSYUo2bkdQMS9XdkZRVHdCN01qTDN3ZHlNeUc3Vlho?=
 =?utf-8?B?N1g1aC9pU3NkWFhUZkxJOGkrYmM1VmdpbmFVTFQzbVpQWXhaNHRVT2hneHNv?=
 =?utf-8?B?emtZdlFvT25xL0dyazFpVTVRL0szWlFaRjVuTUVJRTloVHR6T1NWcE1Hb0NI?=
 =?utf-8?B?RGpTcG1acHcxTGFwY2FSSzBBbzNGbzQzeVpmZndWaEUrYUpLakFqNXo5eGlE?=
 =?utf-8?B?NTFkeTlHclFuYXQyUFlrN2tmN082L2d4WDZIbnBsR2cwcHBnT05XK0RqSVhu?=
 =?utf-8?B?YXhrNWRVR3RVNmcwMTZ6bnRQMDh5cDYxRVVjUTlPOGRWWlgvd1JtKzJHOHlh?=
 =?utf-8?B?Rk5tcXBDVTNvbG5IZXlGSFFYZVBqRU9JbkVBY1JTR0VvbkhiMzJmcnZGSStT?=
 =?utf-8?B?dGxJRHkwdER0N3dleEJ0T1ZibEdJQWl0NmpUSk5QNmZWbWRlVGhPSnk3QUw4?=
 =?utf-8?B?SUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fa47b8a8-177a-4835-4e93-08dbd1b38206
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 21:28:31.4829
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pw8kGFPum5CfFRKXeABI2/2J+y35+f/dvqCUHneXJEiH9LVdW9KKPlGK5JDRiyavLXT5gB7PAKSp06z0C3S/KIw75ovLmUc1wvHEaDnQECw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8194
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:28:56 -0700 (PDT)


On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Convert flags and hw_features fields from i40e_pf from u32 to
> bitmaps and their usage to use bit access functions.
> 
> Changes:
> - Convert "pf_ptr->(flags|hw_features) & FL" to "test_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) |= FL" to "set_bit(FL, ...)"
> - Convert "pf_ptr->(flags|hw_features) &= ~FL" to "clear_bit(FL, ...)"
> - Rename flag field to bitno in i40e_priv_flags and adjust ethtool
>   callbacks to work with flags bitmap
> - Rename flag names where '_ENABLED'->'_ENA' and '_DISABLED'->'_DIS'
>   like in ice driver

I've not been a big fan of the overly-shortened names in ice, but I
agree consistency is probably better.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>