Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <4e78e68f-139c-4a30-ae7b-60eadab9f13c@intel.com>
Date:   Fri, 20 Oct 2023 14:29:29 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 4/6] i40e: Use DECLARE_BITMAP for flags field in
 i40e_hw
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231020193746.2274379-1-ivecera@redhat.com>
 <20231020193746.2274379-4-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020193746.2274379-4-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUlPM1R1QzFDVm8zaldMS0FmSDB2LzZ4eUd1KzRDaXcvcm9MZXh6MzdibzBv?=
 =?utf-8?B?TU9qUWdFNTc0NEdsaVlCUzF5RDk5S0RoUENRV2ZLbVRxREpVYnZDbmhlVXhk?=
 =?utf-8?B?STlNRldFd3ovS0lUeXQ4Rk9MeEppajI1TnhScWVmNGVCbWRBTXd3Q1ZnS3VX?=
 =?utf-8?B?Qk9uY0d2R2dZTGxweERVcHZ6ajk3dGZGYk5weTAyM3dTVG1mS2lFRVluMWNh?=
 =?utf-8?B?TFhJV0c3cGxlZXY4WmZnbmFjOUxVWVdnL3RBTHMxY3JMYVlWdUt4QWdWZTNM?=
 =?utf-8?B?Z2pOOXpNT1h0STl2SlVQek9WWENHc1RaU1MwT3hlZUgzK1dTa1JBUVNwUTly?=
 =?utf-8?B?SUZ1UCtaVDFnSUUvRjlRdlVyRTI5YkpEZlRNRi94SzljbzVXemhLendBWGNa?=
 =?utf-8?B?aVg4eVRmN0lwZDdNQ0xXRWEvMktmZEtyM0lZQ0FlZGc0RktPa2lKNVFsaFY5?=
 =?utf-8?B?ZGZLQllSSGdYL0E1ekNMMm52Zjl6eDN2R0pTRktVNXY1QUxkOUlKSkV5ZGVu?=
 =?utf-8?B?SzJXOHk5Nk5vOFVoS1UwMmwybUtoS1hDK0gyaHNHeUFBMUVIU28yNk9Xd0dZ?=
 =?utf-8?B?TlI5NmY2b1NpRkQyNHJQQTdJSkpRVEpyZmJLMnloR2xRelB1NG5GSTdZTEd3?=
 =?utf-8?B?eHV5TEVBbTMrNUtDRmxQU2pLSkViVnVPa2dmQ294NldXUmZ4eVpydTB3K3dm?=
 =?utf-8?B?VzBOczBWY0w1cytlVjc4REF3Q0JSZStiNFlUcjNmMS9hOWp5N284N1A3RkRX?=
 =?utf-8?B?UFlTd3ZlWWxCdmVMVWJBOFhKNlk1ODQyK0d3ZUJXZUg4aHN6V1ltMGJ6U0xM?=
 =?utf-8?B?aTZGUHlJaVF4ZTQ1eUY5S0MrM3JheGpUK0VRVDU0aitsZnRqWGZ3VGdGRHF4?=
 =?utf-8?B?SmxybjRyRUMyTjFQWHRNWFcrMlBIZGR1SytsZEV2Wmh1THh1RkhRemlCenJ2?=
 =?utf-8?B?aWtmUExEMjRKTlh0Q2Q4YUJ3RVYxdjltZTJtUGdSZ1RTZVpnUmhhL2hKSytn?=
 =?utf-8?B?bVdHWWZTVEFUaGk2dnErT2xobkxCaU9jZ0RHN2ppOVZUd0xQNDNTNEJqOGJT?=
 =?utf-8?B?UUZHMlBaRXJrMHF2c3VRN245WmlSRW9GbW5GS3JrQmk3QTRZTDFCSlh5R2Mx?=
 =?utf-8?B?bkJSTFhWQnFxcjZZaU1iTDRIMDNuQnNsTWxOQ1BxVE1QNlZCdjVKYVRzenFs?=
 =?utf-8?B?MmloMHFuQi9NVHIwUlN3QkJPWnJlNGRyUTV5VjAyem56N2FSTnNoUnBhV3Fo?=
 =?utf-8?B?UHluQ0M0U00wK09nUE9keXBsZ09HMGFrcVJQcFVDV2UvZGxaYXpZdWY4TE5m?=
 =?utf-8?B?Wk1UbWNvUjlNLzBreVJjckd6MGl2TUVYWjcyUm51dy9ZZUdXbW9nTndCSzR3?=
 =?utf-8?B?Umx2SjhBZmpEQ1JUSzVqVE5aQTBwV2lTYXc0UEl5Yi9RMUhhV0M4MHRCK1JO?=
 =?utf-8?B?Z09HUEJ3eURQMC9pWnUxSmtDcXhDOGJ2ck1mTDNjQ0crYlpPdC9mN1ZkSkxY?=
 =?utf-8?B?eGpNZitPSFF1MTYzQVBEN2IvZEFqakwyRmxJcHlGOTIvdUY2R1RSLytmZG1s?=
 =?utf-8?B?SlFxYzNyMzVmdUxRRjlNN3U5Uyt6ZHkyR0NYQ1VIRFdpeFJZZ1M3UUVxWG5H?=
 =?utf-8?B?QXhjelcxWTJua3k4MUZ3YmF0WlNrV0s3aFNUMSswaG5LQ1VVUENsdU1kSm1U?=
 =?utf-8?B?K2N5MUo3Q0VmRWNoUkFrS0g3YWNzNlJLRTJEMFVwSUxXSUhlR0RhQWVWcGNG?=
 =?utf-8?B?VHNzaktSRG1GdC96RmRFQU45OGZLS0ZZaGhLNmR6WVNCN0pDTVVReUdsQmdq?=
 =?utf-8?B?RGFsQXJmeVJyazlUYjZFUGJwY01uK05Jenk4bW1WeUNwc1RQV3RTRGNqREFm?=
 =?utf-8?B?SVBPcHRMZXp4RjNsZHpOVlJjS29JSG04dGEydEY4ODBkNDNCbjBnSkFWOXJV?=
 =?utf-8?B?bVlPKzZ2RVFnck9qQm0yaWJnclJHWWZWT2VlWVA3WldoTDMrNTVnQW9HQW16?=
 =?utf-8?B?aFU2a3FsMTljTE1NY3FzeHRnSWxJQjBOYkZEWkFpSGl4dGYzUWcvZHRuS1NW?=
 =?utf-8?B?Sk95ZjdjM3RCRUNYc0h0N0xkRVk1NUpkNmFqdHJMYWN5TXdDakZVcWZxQTJH?=
 =?utf-8?B?NnpFSThmM256cUJGMlUvSmVDanhNWFlucjJoZkVWaUVoMjNpYlN2YjFIZDFJ?=
 =?utf-8?B?Nmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 851c1257-4d4f-4bb7-7787-08dbd1b3a506
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 21:29:30.2151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x7BucpHNFrDKzPpjFYVXfwUlPnbX/OTIkUZZLWJoFxp6Zo0dCCwfdXh1aJtmWkj8fZBoW0Oy6+JMzbnAhMHXFOyGEsBTEwMYmPbE7ZCUyxw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8194
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:29:56 -0700 (PDT)


On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Convert flags field in i40e_hw from u64 to bitmap and its usage
> to use bit access functions and rename the field to 'caps' as
> this field describes capabilities that are set once on init and
> read many times later.
> 
> Changes:
> - Convert "hw_ptr->flags & FLAG" to "test_bit(FLAG, ...)"
> - Convert "hw_ptr->flags |= FLAG" to "set_bit(FLAG, ...)"
> - Convert "hw_ptr->flags &= ~FLAG" to "clear_bit(FLAG, ...)"
> - Rename i40e_hw.flags to i40e_hw.caps
> - Rename i40e_set_hw_flags() to i40e_set_hw_caps()
> - Adjust caps names so they are prefixed by I40E_HW_CAP_ and existing
>   _CAPABLE suffixes are stripped
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>