Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <6ecee6b6-1735-4fa5-b2b4-3ba93dfc6e4a@intel.com>
Date:   Fri, 20 Oct 2023 14:34:50 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 5/6] i40e: Consolidate hardware capabilities
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Richard Cochran <richardcochran@gmail.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231020193746.2274379-1-ivecera@redhat.com>
 <20231020193746.2274379-5-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231020193746.2274379-5-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWFJNFd4Mk8wMStjYlphSDN6UXZqcnhuc0VWT2ZLWTc0Z3IzNkVXMUY1U2Q4?=
 =?utf-8?B?WDZ0eFhVcGEyNjVXQjJkMG55bDRDYnJkbStJWDR1YXMra0RRdnhhOWlDeGky?=
 =?utf-8?B?MFZTWWNuU3A3aXh1eDFSVTh1OVljRU51VzY4VG9zUEprdCttL2hEQnZiNmJK?=
 =?utf-8?B?dklMM3JjUHJuRHBkdlI1SE5Qa2RLWm9MOVdpVFdzK2t1MllFMk5HNWFQN0Ux?=
 =?utf-8?B?RXhMWExkMFV2NUFSc2VpUC9QOUxYL2x5cGNXTHMrVGVLdit6Nzh5YXgvY3Ru?=
 =?utf-8?B?K2RBOGhpV3E0WWhLRm9jOW5EYzNneno1d2NFYjVXeFE3Sms2cHJwUkhGcWRh?=
 =?utf-8?B?TnhyNXdPVkUyTFRWbzQ2Y0lzdzk2TE40T2t1RTdFZkZTZUJHZG9CYVpYM0d5?=
 =?utf-8?B?VGR2blZqaXI2UmRqMFpLWlpPSUJ2RGMyTEhTWXoxQzNhM21aNlpmS0VTM3hU?=
 =?utf-8?B?aGdGN0xuVjdGdUdKWVpSUDlCNTlqTEdCOUk4MmZ6Y3hjcWJZenpCaHJNSlN0?=
 =?utf-8?B?NUlRbXYvVmkxMmJLblJ3Y1hwVUdZN3J5K1Z6TnNyNHdpQlY3aHNtV3hacG9V?=
 =?utf-8?B?dU5HVTJBTmdaRFZXOG9ZK0k1OHNHZDRlMktBdnhuSHY5Q2swRWxoaFU3Z0pN?=
 =?utf-8?B?MUNIZnBKRzd4WlB2MVcxajdqQVlqL2IrbTZHY1h1cGJoWGJqRlBFbmltYkdX?=
 =?utf-8?B?OUVlWDY2V2xTeXBwOWIvTGRQWkRUZ2dMWDVtNVA2UlZVUHAvVUw2aHNzZDl3?=
 =?utf-8?B?RnV4L1d2ZlNFSWdEak52NmVZdlRiTitYcklwWHZEeXdDcjZUOCtqVXgwcnFx?=
 =?utf-8?B?Y1Vld1paMFJoYzc3NGlGaGRWSHM4cHlwdHlUOEs0ZjRkNHhId1lwN3VPQ3Q1?=
 =?utf-8?B?UmhXZjcvckJpOUI2ckw2VzhpdGNyaUhMU2dZaGV4R091SjBCM3pTRi84MEVt?=
 =?utf-8?B?MXFqR1FISDZaMCtQUGdJQkJIQVErWlJDR0MwUzNCeDNBMGV4anZxanBlT3dI?=
 =?utf-8?B?anpKczJtdVpkUTRjdjNwMVNVd3FONUJNSTZXblVzdUF5ZFhkcHlxTkRna3lK?=
 =?utf-8?B?THI5NHFDK0RTdS9veXNNMlFXK2cwWVQwdVJVZEhFbzZjNTltb1dUMFVKTnZW?=
 =?utf-8?B?ZjFMc1kyS0ZlNnJRbTdVVHJOUTFxaWd0b1hCdVFaUGQxanRwOTBWN3djYnhT?=
 =?utf-8?B?ZEtQZjZSZ1BzVHl4UFBVSWJWSnFGSWt6aE14ZEsrV2RkWVNORE5DdTVlaHJl?=
 =?utf-8?B?L2FZcGNEcUU4V21hRENiRHZOb1BSK1lFcW4xUFdIeHpwQkp4U3JaMEQ2SUpZ?=
 =?utf-8?B?eGZKVEJsVG9XMk9yQ0p6bXBNWVI1RlV0eVJGTTBDWjVxU0pNL1puNTdpQ0x2?=
 =?utf-8?B?dUZRMjE3blI0OEsvdHVYYTc5bGJSTDNjQ2xWc0Mydk5FLzA0ODR0bE5Tc1g0?=
 =?utf-8?B?MmJ1TXZxMFVyQUg4KzMyY2ZMTVg0U3NnK0lQVWlFNVFaNmVEamVDaFpkQml2?=
 =?utf-8?B?ZU84VkY0OU9wd0hoaXdKV1M4czJ2aHUzQ0FWd2YxdWZ3V1Jvdk1RN1Bjb2Vq?=
 =?utf-8?B?OHN2U0wvZ01CcE5qNVRFeE1MemZJa25OM3lPSDVhbHFEQjJrayt3TkN6UEIy?=
 =?utf-8?B?VldxNityTnhnR1JVVnhBSzFNbEVIZlh3MVRhL0E3ZUlDMGl1L29oTVVXcXBP?=
 =?utf-8?B?ZllKTUhySGZSbExZbkp6T1R4aWN6STA4QWp2ZWpINy9IYk9iUDhrUG9YRFBM?=
 =?utf-8?B?T3c4V2kxOURnQjF3UVNTVFVlMTFQbjAybVNEVkZZV1hOeHMxUERhZ2ZlMDNQ?=
 =?utf-8?B?dllTR0xydTY1RTVDbS9NSXNMZG5vMUR2SXo5M3NjdG0rOTJ1ZlFhN2RjR3BJ?=
 =?utf-8?B?dkYzNERDVFZ6RlZEQ1E5UVM3NVBUSUhib1B2aXU1SG9oQzFaeVdzbk5NbHJD?=
 =?utf-8?B?WnJkL2FkU25ZZzlyQlFkNlJwZVNpYVhvRmk0T2txbzRxeHRZWWUwL09YZVRM?=
 =?utf-8?B?ZzlPTVFPR3hRM0JjMmc5MkRvS0ZIMXNMSmJlMjM0SjNTWkhpR0t1MHhPTFBI?=
 =?utf-8?B?dFAvRklaK1J4dVFVbzFPNVJUVGZRNjcrRkZTelAwY3pKRmFwSjExK092VmpL?=
 =?utf-8?B?L3Zoc0RBMFZaYUcvc2Q0N01oc0p4RUZXb3FSWUtuazdtZHpTQ2ZacDNrM2xR?=
 =?utf-8?B?Q0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4101b218-927e-49ba-5355-08dbd1b465d8
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 21:34:53.6895
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VoAATO9mJZLZkUkVnSYwCb1vh5xkDZ+3EmDxJkCObnYlb9Bfx+s9bcJw6goB4vRMLj8iXq5lNdbVtwEzt91Qf0ELih5FKGfFVrlO3eyKrtE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4543
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:35:35 -0700 (PDT)


On 10/20/2023 12:37 PM, Ivan Vecera wrote:
> Fields .caps in i40e_hw and .hw_features in i40e_pf both indicate
> capabilities provided by hardware. Move and merge i40e_pf.hw_features
> into i40e_hw.caps as this is more appropriate place for them and
> adjust their names to I40E_HW_CAP_... convention.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

The hw features values were originally introduced by commit b74f571f59a8
("i40e/i40evf: organize and re-number feature flags") (v4.15), and were
previously part of the normal flags back then.

The hw flags field was used since 07f89be81fa5 ("i40e: Fix basic support
for X722 devices") (v4.5), and appears to have been extended a few times
since its original.

Its good to clean these up and keep them together conceptionally. Thanks!