Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp1300477rdb; Fri, 20 Oct 2023 14:42:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyhhHbhEzXlYtjzsTdoYm5yOZK4PX+QinBiLJ1jk3gFzTT9PMoY4wTAHPSRIi99Ww16UNQ X-Received: by 2002:a92:dacc:0:b0:351:211c:fec2 with SMTP id o12-20020a92dacc000000b00351211cfec2mr3181141ilq.15.1697838170943; Fri, 20 Oct 2023 14:42:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697838170; cv=none; d=google.com; s=arc-20160816; b=ykoB/ANvNnKL+4C0mYsbaox+bVAbh7dt0de3CG3n6eCovJ6vje2HHuV+2dl2xhItjL iUHbMGTeOLBTd7wCwvMwpNyWewxWnxNcp9PLe6zp1VhtCJ0tiCe53tZ0JLZoOWuGwXXd BmEjHee4fhqPsI329/Xl+OBytJ4vutB6Dj///ZHy8+xytcRbhOFsmqY/OL+oM4BXvdcb obkW89npaFE7FwD/eNxMzZ7JZNwcGnShMUD17UC2nIsYdUIrD1xd+SSP5yw/moZZgdx6 ndICuQNUeMWys0CocmBTcPVwe7X5e8KtH1gSkHVtaehEmmSZLWleD+pvdPRxKepSO8dE roLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TknwrUUxoMhQrll7HrSv2xV0NraS4Bmkq6cAn/1c1wQ=; fh=7TruTFrjlqujQ0HWWBOBPomtarDWTxBLC6uiePTBcN0=; b=dPKV6SyhcWX0p98PoI5WvRFRTFemIOY8wpDHP4/fxbJGEPqGGT8phWXOeWClETyqMW 1sSPbGNfpQDrAW5jz+VevAPvr3P/OWglXCcCIk4zqiZRLKPanteggtZTQqPaY4qPE72P 8lTdX4WBMtqaZWIxH+Y4wi8Sk0tZCObRMg2fzti7fOw4k75V6UQHjDSnZ+VFH+dCzWjQ M3jZ0VlxZVHzAaJ427JPoZ1sibeqKCaN1AuYiPHjhnS1UvesMkCLzODyPtRynsDqSwY2 HJbceg4pwkflYOkxSOZ0QbdExzJeUAEWXTrReBhI6JB1VHB+h+s53gqPHSWIq6e4D7lh G3Cg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gIxS0X0e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z186-20020a6333c3000000b005b7e70085dcsi2508043pgz.433.2023.10.20.14.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 14:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=gIxS0X0e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id EC1328331E35; Fri, 20 Oct 2023 14:42:10 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345614AbjJTVl5 (ORCPT + 99 others); Fri, 20 Oct 2023 17:41:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345344AbjJTVlZ (ORCPT ); Fri, 20 Oct 2023 17:41:25 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0161A10C4; Fri, 20 Oct 2023 14:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=TknwrUUxoMhQrll7HrSv2xV0NraS4Bmkq6cAn/1c1wQ=; b=gIxS0X0e1zyUPPkiIxIQASLrI5 XWYOErfwjkwOL6JU8ilDyp0RbMdHpZjW/XBVW4CV98q5hw0PfjailbTJTeHjcBBr3nAOmaokLB4O/ n72T5aXF/cqeEETKhYffeP7O4KXV7Je3OCSpOl2D6zUyqZ+voHol8zLY7WWqwLj4VKzw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qtxEz-002owx-MK; Fri, 20 Oct 2023 23:41:09 +0200 Date: Fri, 20 Oct 2023 23:41:09 +0200 From: Andrew Lunn To: Oleksij Rempel Cc: Vladimir Oltean , Woojung Huh , Arun Ramadoss , Florian Fainelli , kernel@pengutronix.de, devicetree@vger.kernel.org, "Russell King (Oracle)" , netdev@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Eric Dumazet , Rob Herring , Krzysztof Kozlowski , Jakub Kicinski , Paolo Abeni , "David S. Miller" Subject: Re: [PATCH net-next v6 5/9] net: dsa: microchip: ksz9477: Add Wake on Magic Packet support Message-ID: References: <20231019122850.1199821-1-o.rempel@pengutronix.de> <20231019122850.1199821-1-o.rempel@pengutronix.de> <20231019122850.1199821-6-o.rempel@pengutronix.de> <20231019122850.1199821-6-o.rempel@pengutronix.de> <20231019172953.ajqtmnnthohnlek7@skbuf> <20231020050856.GB3637381@pengutronix.de> <20231020082350.f3ttjnn6qfcmskno@skbuf> <20231020083438.GD3637381@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020083438.GD3637381@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 20 Oct 2023 14:42:11 -0700 (PDT) > > Ah, yes, it is from get_wol(). Maybe a ksz_switch_macaddr_tryget(ds, port) > > which returns bool (true if dev->switch_macaddr is NULL, or if non-NULL > > and ether_addr_equal(dev->switch_macaddr->addr, port addr))? > > Ack, something like this. > I'll send new version later. And maybe add a comment. Seems like everybody got it wrong what is going on here. Maybe i should not of suggested it :-) Andrew