Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp1328185rdb; Fri, 20 Oct 2023 15:57:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXrIn8jidOldT+jq7V6f50p/PYDTwq1Re3quL0L+u9ZiIqogg1wn7/FkNPZXFEiOEWusuQ X-Received: by 2002:a05:6358:9895:b0:142:fd2b:d165 with SMTP id q21-20020a056358989500b00142fd2bd165mr3575679rwa.13.1697842662711; Fri, 20 Oct 2023 15:57:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697842662; cv=none; d=google.com; s=arc-20160816; b=s19h3rQZVpQL0pJzzvzCNkuoumCv4yAdLkfSoxgO3dkswKdfT5ishUJyRjLr4ixBaW ZZnAo4t2Hw/OpkyvU8IngnSwNJCX1HdkUSLM3mVVLpoNB/1Nphh/UhqGAx5amzznVWLZ NqF6332pzBLzRWTdXSnsAKAYg1nHfSdqnkKiGMq6Pwy1Z9b+q9TqtcoLhPAm0cxKA+kL WcJAToZ+QoOx7VgCttuzkXwoLIkZ5gB72UgjPjZbnTMIJ3RHJrs4UPU4jR28FTvHX04i BnKP0zv2fiP8qT54eqClHK38xFhsbawate9in8Rngn8AjcAqU6GNdwstSINukWjUcO57 t3EQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=dNY4ZF2n8N6ah98yjA9kQ3X3A+H1xwxHdfH72nN4Guw=; fh=m1iD6bljjKk90+27JiMlgJhv+T0nzoxGzscexH4sQVw=; b=N9ZVhbzt6th3WP6twf/+B3SbBpd0H9A4WUi6aInELY793Tbme0Hh+Xe3CoTadzHpjY rejBeAL9VX/Fjlv1wh6KmcGxB3Ncflg4hag32KRm20HyS4ksvJ0tp85TlsCSrrTMkUw/ d0FOe/dV20JfjdK+JmtQMlyFTux56CVx3FnEaZ951BGAiW91Qv7fGmKRou3L1bw0uNd/ 8WwapNsgFtwdElpooQyGTmSNMXSR55ohnb2e7sqr/yGhqvpOm4e5GxN0gmcoOHxBnkdt QxCMsF44zfKay/Hg3j72D8V/4hKZr7tyWb+32CBv7gy4Y014A3y5TCtpcAuuukMXOgQc 3T/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=F9Oy77UI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id a23-20020a637057000000b005a9debd7854si2648935pgn.828.2023.10.20.15.57.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 15:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=F9Oy77UI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id BE6A58087DD6; Fri, 20 Oct 2023 15:56:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjJTW4i (ORCPT + 99 others); Fri, 20 Oct 2023 18:56:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbjJTW4h (ORCPT ); Fri, 20 Oct 2023 18:56:37 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A099ED68 for ; Fri, 20 Oct 2023 15:56:35 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5a7af53bde4so20444107b3.0 for ; Fri, 20 Oct 2023 15:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697842595; x=1698447395; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=dNY4ZF2n8N6ah98yjA9kQ3X3A+H1xwxHdfH72nN4Guw=; b=F9Oy77UIUgGjzE5W9CQizQXuktkOPXYnJDGUNgIoR4/SsXktgzXiL+858DhY+ALhzo 7J9iUUhNJ0pEB96e4m1IFhdcGQ0RNEJ2cuAM5yUevr6wNEDO0IUxypOEpi0AYpTCYB4F t1/PD3sff3r8Zd4R4Jnb3kgKVJi6Uw7/Z2tHhNj0cILTBKurt7ZdoPYo3QkUyUuEuIXu PoasIMqT7SIUIzaqsttJeNAFpP56tiqGUIhxa38aeU/4KIIMrMIYowrx+Svbxiu1pRfM j0SRjPLkHcH1eJnpOWD1AhcoZkHHKnxTZLcumoYPyagbe//21UtJw0NyWQXMwA0jnnVb TafQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697842595; x=1698447395; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dNY4ZF2n8N6ah98yjA9kQ3X3A+H1xwxHdfH72nN4Guw=; b=e/xOrtyg/G4aZ07wRHUxiHkxr21HAMxzwrsmTsBih1762ZyKsFvMLoHYyjem6hJ07l 2dC0Zxj7P4wW/X+cjw1RiTt0Lju1xM4Jf5or8l75MSxsMt7O+2GSQHGlhK22eFif9WwT Xg8YSVbv1hCTE+BHwZJtiLQOvLp0bQWWeaq8XOwEc8k9gNMwjP6p5FaGp7aqb8FAyzQc NfobhbZW8c691Ks8OIP/N3IwZ80Mt2Wbs/kiXE9xa7WoPZ8ll1DsYiGhJ9wNFtdEwHko fjbmln0kuvcaKigX4y/V4wzcgJTAW045a5sssOcydznQKE64qcWezASfiL9t038xvT0L aljg== X-Gm-Message-State: AOJu0YyzS8bo+JLKMOVBa5ab3Y8M4d5GmtsIHQXy68dQbq4n+Uk5P0ms w2mfCRDUlAwczhq71WdQpjocg5op8Sg= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:928e:0:b0:59b:f493:813d with SMTP id j136-20020a81928e000000b0059bf493813dmr75633ywg.1.1697842594914; Fri, 20 Oct 2023 15:56:34 -0700 (PDT) Date: Fri, 20 Oct 2023 15:56:19 -0700 In-Reply-To: <20231001213637.76686-1-dongli.zhang@oracle.com> Mime-Version: 1.0 References: <20231001213637.76686-1-dongli.zhang@oracle.com> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <169766221626.1905946.10575066014082098174.b4-ty@google.com> Subject: Re: [PATCH 1/1] KVM: x86: remove always-false condition in kvmclock_sync_fn From: Sean Christopherson To: Sean Christopherson , kvm@vger.kernel.org, x86@kernel.org, Dongli Zhang Cc: linux-kernel@vger.kernel.org, pbonzini@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 20 Oct 2023 15:56:58 -0700 (PDT) On Sun, 01 Oct 2023 14:36:37 -0700, Dongli Zhang wrote: > The 'kvmclock_periodic_sync' is a readonly param that cannot change after > bootup. > > The kvm_arch_vcpu_postcreate() is not going to schedule the > kvmclock_sync_work if kvmclock_periodic_sync == false. > > As a result, the "if (!kvmclock_periodic_sync)" can never be true if the > kvmclock_sync_work = kvmclock_sync_fn() is scheduled. > > [...] Applied to kvm-x86 misc, thanks! [1/1] KVM: x86: remove always-false condition in kvmclock_sync_fn https://github.com/kvm-x86/linux/commit/2081a8450ef8 -- https://github.com/kvm-x86/linux/tree/next