Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp1328456rdb; Fri, 20 Oct 2023 15:58:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGr/0NzR0kOjLj5cLhcAXE1LWdY5/laHQNcmuHCmg6RX6jc361zBzte2s/thu6AG27yxFwD X-Received: by 2002:a17:90b:8ce:b0:27d:4d6d:8379 with SMTP id ds14-20020a17090b08ce00b0027d4d6d8379mr2905644pjb.48.1697842712426; Fri, 20 Oct 2023 15:58:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697842712; cv=none; d=google.com; s=arc-20160816; b=COUpRpO46shanTs55yz41VyFT2PJrXmFix4O2tzrB8D4yOw/hPCB8aIlO7aJDBMRYU jpP4F70oRvJwZGFxMVZqyS0g/vFduC3bO8WD7CzMFODQYayTIbeFbEZnsGuIGU089s1l qWnKYnsjxYfU+ibrMdE6ydB9aFXguftIX+U2vKqTmPnFHLvxQ8yeOCIrIOOrHOLs7Txf fWc/P9Cncj2N1Bz+Yf6oFX/ibD1r5+88lhLgKjdboro1fhHhhcGW1rHVTqr9jWNxQn9y m0/3c+6lrOelrhhZPkLeB5lYvWdmmzRSmCwjG8Pcqc0vCxy200xk/NWrevMed/B7jHTo gfzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=3YJUbXLc41eB4MhMk4dwKPTxYx78Ax4qZ5YkFcbOnrU=; fh=sKdBsvP50hTwNv5P95bpdnf1pFSiKeF8WmluKvTx73I=; b=qeSQmI4pROTkjMtkd5nSgWEEHUo72Tieota+UpuKYwlIc/7w8Mo1//EaNZK9zx+Lqw lm95Rjcw1gS8ujRme/ZbpVagn4o6lxRd8MxfRRCd2VLhWMScgg7VxtuNjW+IqVqFU5sI zibdUo95ig476wItIrgtiHMXqxyFVB+0VKMmPvecnrBIDen9hEWh/FXzYmgh8bmOivmu jDAAINYmSlRG+vfY9qDouA0kmuwXxunqUo08LM6d+9fv9xj7HACI+6Al1V4qksKGu2iX 8ae6g3KTcqYNQkFrQKfCfT2wNh6Fzc3ESxDg1BTP+frxN3KGTIV55U84prxCylv3MnjT pCTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=g52c0ASO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id b3-20020a17090a12c300b0027d33155aefsi2766724pjg.99.2023.10.20.15.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 15:58:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=g52c0ASO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1361083D9B5A; Fri, 20 Oct 2023 15:58:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbjJTW6H (ORCPT + 99 others); Fri, 20 Oct 2023 18:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230188AbjJTW6F (ORCPT ); Fri, 20 Oct 2023 18:58:05 -0400 Received: from mail-pj1-x1049.google.com (mail-pj1-x1049.google.com [IPv6:2607:f8b0:4864:20::1049]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A6881D79 for ; Fri, 20 Oct 2023 15:58:02 -0700 (PDT) Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-27e293ff6daso438a91.3 for ; Fri, 20 Oct 2023 15:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697842682; x=1698447482; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3YJUbXLc41eB4MhMk4dwKPTxYx78Ax4qZ5YkFcbOnrU=; b=g52c0ASOETzdo/gVmHylVla5THW3yVGVj08JVffS735RQPUzH0/F2tbA1xZ+MWz+YS QCXTvJT/ylvBacMZUATKxaI7EAkn5zglv0t82S0oKDvCIsUjY6LTlyrXcqVJY2Pp638H 3MhbBWzbXO2RcImP75cK0yOnSfYFsvFMxHqWGSyyu3Zn33qAOhF9R6TG6zbQ9e/uC8O+ cK35FJl+AmCFkZatdzqM67tcChmr1Rwrp4g5GcvmKg7Ny/bMfj3CdPrcDYnEsy4WuiYf cbF55Up3i4jQnSmYF0mY72Z7ZXZ4dnvw9v083Z/GZ2zqCrPYYcusxhLByEVe9EIsZbl2 Y48g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697842682; x=1698447482; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3YJUbXLc41eB4MhMk4dwKPTxYx78Ax4qZ5YkFcbOnrU=; b=GMpeVbyNf6C/Z9BLt+7b50g+6JIuZr3mIiDYvAIbykWOl7AYranTGbuRE7VGVMHMaS ddyd1kI7BbrEi1pC5nSxVOKdd5NYGD4WFP6YuEf0enUy8s9BiKFJyYL1QUq0+5eAMUvp 9l8CUu9G6PKIId5VdPM87FaAbB5Gf1oXaBBXpmaSNhKUhpAHFvU5rpD3NDWgjx/oPjhO dLWJJWOi0g5puJcnUD8DTcL63n4HP7sXfP+bWmT29vuSYdBgh5/VlcJClltZIQmBzFnc DzrxiIrD8bKvjEMr6DP7/YaYq7CXPXk+e4pwHgpuOZUqdcEGZfcRGvdsur+B6GcYc8kH yFQA== X-Gm-Message-State: AOJu0YziZidKfWvHzY6Uvj+ZI6BU/dUaE/xkyy4W3408MxXKfJ2klBzh lZO/e8cKuWZgXCmtE98I7Oc05Le6N0o= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:3788:b0:27d:3b44:86fc with SMTP id mz8-20020a17090b378800b0027d3b4486fcmr74085pjb.7.1697842681955; Fri, 20 Oct 2023 15:58:01 -0700 (PDT) Date: Fri, 20 Oct 2023 15:56:25 -0700 In-Reply-To: <1ce85d9c7c9e9632393816cf19c902e0a3f411f1.1697731406.git.maciej.szmigiero@oracle.com> Mime-Version: 1.0 References: <1ce85d9c7c9e9632393816cf19c902e0a3f411f1.1697731406.git.maciej.szmigiero@oracle.com> X-Mailer: git-send-email 2.42.0.655.g421f12c284-goog Message-ID: <169773243871.2018423.1481448432661434673.b4-ty@google.com> Subject: Re: [PATCH v2] KVM: x86: Ignore MSR_AMD64_TW_CFG access From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , "Maciej S. Szmigiero" Cc: Tom Lendacky , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 20 Oct 2023 15:58:30 -0700 (PDT) On Thu, 19 Oct 2023 18:06:57 +0200, Maciej S. Szmigiero wrote: > Hyper-V enabled Windows Server 2022 KVM VM cannot be started on Zen1 Ryzen > since it crashes at boot with SYSTEM_THREAD_EXCEPTION_NOT_HANDLED + > STATUS_PRIVILEGED_INSTRUCTION (in other words, because of an unexpected #GP > in the guest kernel). > > This is because Windows tries to set bit 8 in MSR_AMD64_TW_CFG and can't > handle receiving a #GP when doing so. > > [...] Applied to kvm-x86 misc, thanks! I added a paragraph at the end of the changelog to capture the gist of the discussion on why we agreed that having KVM eat MSR accesses is the least awful option. I also tagged this for stable. Paolo, holler if you want to grab this for v6.6 and I'll drop my copy. [1/1] KVM: x86: Ignore MSR_AMD64_TW_CFG access https://github.com/kvm-x86/linux/commit/2770d4722036 -- https://github.com/kvm-x86/linux/tree/next