Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Fri, 20 Oct 2023 16:00:37 -0700 (PDT)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Robin Murphy <robin.murphy@arm.com>
cc:     will@kernel.org, mark.rutland@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        jeremy.linton@arm.com, ilkka@os.amperecomputing.com,
        renyu.zj@linux.alibaba.com
Subject: Re: [PATCH 3/3] perf/arm-cmn: Enable per-DTC counter allocation
In-Reply-To: <849f65566582cb102c6d0843d0f26e231180f8ac.1697824215.git.robin.murphy@arm.com>
Message-ID: <fa35f25b-2db8-daa1-1817-3ac256fc27ec@os.amperecomputing.com>
References: <cover.1697824215.git.robin.murphy@arm.com> <849f65566582cb102c6d0843d0f26e231180f8ac.1697824215.git.robin.murphy@arm.com>
Content-Type: text/plain; format=flowed; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0gFFkd7ppf0yJdSAQHMZidXlyEeYIk4LNERjH6TPEAltITw0f0TwU//HLW5B?=
 =?us-ascii?Q?vgkH11U6ad9Rlpl7GFxt/SUxJmxM0EvdMYDOGy6r3MGZIXL6eiO2WTwIeACt?=
 =?us-ascii?Q?xC8GTpTjIX73GVUcnqwWpEulRB1KRXBbJPTPCbuy0Kh0GZclHLL+FsR1m2XJ?=
 =?us-ascii?Q?WaI2LpXbYbyoVkQAhik6hH+bq5Q0+/23EwE75QYDACnI891pncdw37xoVpmC?=
 =?us-ascii?Q?hdHIZOGWsevGFN0o4F9Mkv1OdeO311Q4Y83EqVo/Gs2Y+qppHODeCVcx8xD9?=
 =?us-ascii?Q?anBF+kZIAStyBDOhruiEnQiCb0fJOMx6QsQ8gvMahyqJanTEYk2EiiEwQtpy?=
 =?us-ascii?Q?BqZd+ivFHbXcshM/e0Q85scktW/KSnULdzNcx3Y6WakuKbJSfR2uYYZg8szh?=
 =?us-ascii?Q?tMSgssLdQNuSzl65lpVtVNaaon7kHHoo3Uf8cQGXJS2Hg7da6wfB06YB0/fB?=
 =?us-ascii?Q?JitAz6JMNvzeBu+rn7ETscIhWgIW5Suwg4uwZ1GCwCD2rBqiQX37dt0rjjFf?=
 =?us-ascii?Q?hA7N//N9WXF2ielExd+R9eEvmu4uf0KZBbI7HrNUgWQ/V4Og4ionS7CizPBe?=
 =?us-ascii?Q?uI2/cZK3vC9Wd5lOnvOJOC3hwfQgqdU2yC3ghYAwruhIUEbbERPXJr8RR1WT?=
 =?us-ascii?Q?SuNEbISAVh+rYsVVl9I7eZjLOIVXxAMAxxLwGmx4Y5t+tGKzLWvtpyq2q4di?=
 =?us-ascii?Q?N7561Zee5KpnBoNnDhyx2MG4AP5Q1tEt6uqpMwDt2Kf2G521KO6ftD3QTmiY?=
 =?us-ascii?Q?zUmKEx9ftyCoGOBgSsB10LweaEHEOAYaQNvGCsp4zqDgF5G/t26MWjyoFYDE?=
 =?us-ascii?Q?W49+mk1YRfeXnBoXiKH10Ai9jjOdS9mw+6Ho7BQq59gFBaazBXI7/tMZeIT1?=
 =?us-ascii?Q?lW9q9rbrxgb3TRdXVpGyl2NTT0SGGllIky4EAN70F07Ze9hfAeb0AQTXjSCR?=
 =?us-ascii?Q?lbWdLtOAiszGqXb6mD7qeCYayvXEdGDiQzMRlOcndaPTW3bJNjM5YaYUFkz3?=
 =?us-ascii?Q?BeedvDUOK5cPWrziMR/FDh8rTAH9ev1dY9t0qMWgjyZCRDk6YFe65We0m2n5?=
 =?us-ascii?Q?xsFC2vkLqwQ8m3F0WnB/+mei5snKr8LRiinqvWj4WpZ8XW5K+3K+nEYBWPqH?=
 =?us-ascii?Q?4SRCSqp6UirPE2vGaOr20y5FhwkvnAhCDDoQD9RgUmZVBp8av9TJSbzYvz0I?=
 =?us-ascii?Q?qEB6sv/4tNBxkSz1Qs9VGHLm6cFQm4XZC9wZqcv0+x32K6Nuikz9kFxwX3Q4?=
 =?us-ascii?Q?MgqClqTSEjjKUKUJIGqWFOk5246PL3jQEcwLX6fwEa62+Rc5D/S0kVvhT870?=
 =?us-ascii?Q?T23wk84cOf36nB7zlm42Sag4AzGCwYhgfEgg/oz631tOOnG7iWVedUHQi5zB?=
 =?us-ascii?Q?flB42PYKHHXIPFGfe1mTIJ473A0wVaTJ9NeqXNRr1w7WJf1S400gLfO3g+/j?=
 =?us-ascii?Q?a56+o0nYg/PYhJsPH83KukC0xbaR5mT2sqL55SMLrV5NvoJYUfVEsAjsesE+?=
 =?us-ascii?Q?Q8rAoHjKkVP67gNLlicOCJ6FSm7Lp0+wJZi9biB2g+AElCUkuBhvR5Wey9eU?=
 =?us-ascii?Q?9dnBErbLodn3uX9xPF1mbzvnbjRDNAXxRv0JjNBVbrfJdNoF8SCEQb6PhWFc?=
 =?us-ascii?Q?B4Mnja+MPf1R9uyu4KA9DTc=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e049947c-c5bd-4ec2-73b9-08dbd1c06f47
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2023 23:01:03.4764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MaSGzyOD2LU9uUt8jfbzT6GDEo1sBP1S6Z/foR7ZF1oCnJbkiPsLLGL452YbKl/sgaEghWcqFelatxKM5rCPVKU/029dBJJWvpsjOmtp6jxXucjnI7eTRY+xlbvL1J1Z
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR01MB6792
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Fri, 20 Oct 2023 16:01:25 -0700 (PDT)


Hi Robin,

It seems that I somehow managed to reply to patch 2/3 second time with the 
comments that were supposed to be here... :(

On Fri, 20 Oct 2023, Robin Murphy wrote:
> Finally enable independent per-DTC-domain counter allocation, except on
> CMN-600 where we still need to cope with not knowing the domain topology
> and thus keep counter indices sychronised across domains. This allows
> users to simultaneously count up to 8 targeted events per domain, rather
> than 8 globally, for up to 4x wider coverage on maximum configurations.
>
> Even though this now looks deceptively simple, I stand by my previous
> assertion that it was a flippin' nightmare to implement; all the real
> head-scratchers are hidden in the foundations in the previous patch...
>
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>

Thanks! I had that on my task list but never had time to start working on
it.

Reviewed-by: Ilkka Koskinen <ilkka at os.amperecomputing.com>

Cheers, Ilkka


> ---
> drivers/perf/arm-cmn.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index 675f1638013e..9479e919c063 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -1570,7 +1570,7 @@ struct arm_cmn_val {
> 	u8 dtm_count[CMN_MAX_DTMS];
> 	u8 occupid[CMN_MAX_DTMS][SEL_MAX];
> 	u8 wp[CMN_MAX_DTMS][4];
> -	int dtc_count;
> +	int dtc_count[CMN_MAX_DTCS];
> 	bool cycles;
> };
>
> @@ -1591,7 +1591,8 @@ static void arm_cmn_val_add_event(struct arm_cmn *cmn, struct arm_cmn_val *val,
> 		return;
> 	}
>
> -	val->dtc_count++;
> +	for_each_hw_dtc_idx(hw, dtc, idx)
> +		val->dtc_count[dtc]++;
>
> 	for_each_hw_dn(hw, dn, i) {
> 		int wp_idx, dtm = dn->dtm, sel = hw->filter_sel;
> @@ -1638,8 +1639,9 @@ static int arm_cmn_validate_group(struct arm_cmn *cmn, struct perf_event *event)
> 		goto done;
> 	}
>
> -	if (val->dtc_count == CMN_DT_NUM_COUNTERS)
> -		goto done;
> +	for (i = 0; i < CMN_MAX_DTCS; i++)
> +		if (val->dtc_count[i] == CMN_DT_NUM_COUNTERS)
> +			goto done;
>
> 	for_each_hw_dn(hw, dn, i) {
> 		int wp_idx, wp_cmb, dtm = dn->dtm, sel = hw->filter_sel;
> @@ -1806,9 +1808,9 @@ static int arm_cmn_event_add(struct perf_event *event, int flags)
> 		return 0;
> 	}
>
> -	/* Grab a free global counter first... */
> +	/* Grab the global counters first... */
> 	for_each_hw_dtc_idx(hw, j, idx) {
> -		if (j > 0) {
> +		if (cmn->part == PART_CMN600 && j > 0) {
> 			idx = hw->dtc_idx[0];
> 		} else {
> 			idx = 0;
> @@ -1819,10 +1821,10 @@ static int arm_cmn_event_add(struct perf_event *event, int flags)
> 		hw->dtc_idx[j] = idx;
> 	}
>
> -	/* ...then the local counters to feed it. */
> +	/* ...then the local counters to feed them */
> 	for_each_hw_dn(hw, dn, i) {
> 		struct arm_cmn_dtm *dtm = &cmn->dtms[dn->dtm] + hw->dtm_offset;
> -		unsigned int dtm_idx, shift, d = 0;
> +		unsigned int dtm_idx, shift, d = max_t(int, dn->dtc, 0);
> 		u64 reg;
>
> 		dtm_idx = 0;
> -- 
> 2.39.2.101.g768bb238c484.dirty
>
>