Received: by 2002:a05:7412:f690:b0:e2:908c:2ebd with SMTP id ej16csp1363184rdb; Fri, 20 Oct 2023 17:26:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEb7uweRQ+4/VTvMTGEupscevnd1WY/n40Dc1u+GpU4NwqKWFJOloRJb4TeQtF2P71TsweQ X-Received: by 2002:a17:90a:1a10:b0:27d:5ef6:2862 with SMTP id 16-20020a17090a1a1000b0027d5ef62862mr3119444pjk.13.1697848013764; Fri, 20 Oct 2023 17:26:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697848013; cv=none; d=google.com; s=arc-20160816; b=Cj2lxFxpEFF6Y6Jad7O1h6fEwPQtS++Bbo/KsBYVDZE3MFz18PCAGOqc3qHTcuS5lz Oq2Gq8qpwsLqHTKpBdgiJIxW6LddgAF70MFCtjlhNh+tuJAVGfvAP0Do0cK6UPhNOV6C Iq20tudFDdIDHZWBvoUq1tOenoq+FDX8UUyrCzMIKYaeZqXQoQauvBaCjlxgFpcGlVi8 1nPkoQP1EvOxzi0wJw+OV0HcNNe7majBRg3f4aU+FLr6vA/Wmz4tBhg9dq8SyeOFqJhO pq9lMkg2WeG3QorDRzVOcpscor+t5CSbCVJNsOr0ILa8dAN0eI/YmurQljxJv71++wpL Fg9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=XLajY2EgsRMhFXb021iDhWt7wlyo3S6J5z4JRl54ma8=; fh=e5b2UcnN4Hvp9bvOQUtHiXwDZJAlE/kT7G1+4jee5Ek=; b=gSq3ugACYP2rd/xB39cszCW+6RrEVQEKo8ax0QnJyPklCTNw8Oq/Q3n1DfS3ZTDblE Mrg06Sx/0gPjsJXdYjxDPKMFENeqSDxBriZn6y40Hq5np2T0weUBYuLDPeyMJ11+jzSX Dj2VehlCd19yzVyvKJAFPa8OBFk7O9T2ssCs9Wm+O3bMvH1A3W+t63t02Rm+GrIphBhA nzKWFUkz39OHkZPku32dnuy2xmMEHRdt50xRO0UW3eDf8vgWeUsluNGZwkaQ7089fFcH ThmpqsCP+LYPN7DEpBZKQOT88JkUPA/0up1ngX6TeCgeNgomR2raGaacY6TXTwnJqkOI ChbA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=jV7LjtGg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id z21-20020a17090ab11500b002790fa91d77si5381143pjq.145.2023.10.20.17.26.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 17:26:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=jV7LjtGg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2255882C4D6D; Fri, 20 Oct 2023 17:26:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233296AbjJUA0f (ORCPT + 99 others); Fri, 20 Oct 2023 20:26:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233269AbjJUA0d (ORCPT ); Fri, 20 Oct 2023 20:26:33 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28AC2D66 for ; Fri, 20 Oct 2023 17:26:31 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-5a7b9e83b70so11571467b3.0 for ; Fri, 20 Oct 2023 17:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1697847990; x=1698452790; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XLajY2EgsRMhFXb021iDhWt7wlyo3S6J5z4JRl54ma8=; b=jV7LjtGgc+DIkKYA4foz1XDlIy2bkQ41zgmC7ZJ64J1Z58prFOql7e2IQ80cwd3odN 72tTDir6aIIaF1F4aA1cdn6FNUwhPT7Qjcoi2h4IADVRK8we0LsN+nZx7FpHPhZciVbU 2UQy9F+4nu6nqAeccpOGhWjXLQeyXFl1x4jdfII/HRhAYBa2FRDVBkAhL4C/nRJYqzwg 1WeHUkhrEfSnibL3+UoZZQkXpjYllgILjYjwOTl9QCqj1yZpmeOLeTcoEA+4REogmz46 RxW92fTjw5UKua+hTiK19APS00VG4QvTZpgqaVEpSfu2wA+hynAyxn1tkC+xo9O345IL /uKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697847990; x=1698452790; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XLajY2EgsRMhFXb021iDhWt7wlyo3S6J5z4JRl54ma8=; b=TBRKGXko0GHzsSFA69abqiewcmwGmQaTD518TDslCOx1i7LhCUIeizsYVhJ1BnDfCb T7brmeMHMPF5eL0VJBBdV3qCrPj5h3KSlGMRk2rdPc8yFbsm1sxyOyzQZy2c5/ENMhEM sAQB3Hr32ntp+t1Bl2MKYgCoD5DpQcK+jthTlLrI9t836ypg5edQ83zXo7mvLNaqk9jD rB76ERO1iSyCRZR0qRokYkj7/15T7xHarsU/SS24JaFST03vVd/Liy0ii9XMdoFAf/K+ Kbv6iM1ohEI4LqHS7uxq0om2MigFziiaHxsb28phdu/vctjLJ4O+Tk2Y+SeGLlWcwI0Q JaEg== X-Gm-Message-State: AOJu0YwsaMHb/vB/bakb1ruQ3JDTemuu+jP4jzIm3IWa2pCHQxxIAyXQ G86F7G07aKygE6Lvy2LH/ka+3K8Ilkk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a81:7815:0:b0:59b:b0b1:d75a with SMTP id t21-20020a817815000000b0059bb0b1d75amr203036ywc.4.1697847990379; Fri, 20 Oct 2023 17:26:30 -0700 (PDT) Date: Fri, 20 Oct 2023 17:26:28 -0700 In-Reply-To: <20230913124227.12574-1-binbin.wu@linux.intel.com> Mime-Version: 1.0 References: <20230913124227.12574-1-binbin.wu@linux.intel.com> Message-ID: Subject: Re: [PATCH v11 00/16] LAM and LASS KVM Enabling From: Sean Christopherson To: Binbin Wu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, chao.gao@intel.com, kai.huang@intel.com, David.Laight@aculab.com, robert.hu@linux.intel.com, guang.zeng@intel.com Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 20 Oct 2023 17:26:51 -0700 (PDT) On Wed, Sep 13, 2023, Binbin Wu wrote: > Binbin Wu (10): > KVM: x86: Consolidate flags for __linearize() > KVM: x86: Use a new flag for branch targets > KVM: x86: Add an emulation flag for implicit system access > KVM: x86: Add X86EMUL_F_INVLPG and pass it in em_invlpg() > KVM: x86/mmu: Drop non-PA bits when getting GFN for guest's PGD > KVM: x86: Add & use kvm_vcpu_is_legal_cr3() to check CR3's legality > KVM: x86: Remove kvm_vcpu_is_illegal_gpa() > KVM: x86: Introduce get_untagged_addr() in kvm_x86_ops and call it in > emulator > KVM: x86: Untag address for vmexit handlers when LAM applicable > KVM: x86: Use KVM-governed feature framework to track "LAM enabled" > > Robert Hoo (3): > KVM: x86: Virtualize LAM for supervisor pointer > KVM: x86: Virtualize LAM for user pointer > KVM: x86: Advertise and enable LAM (user and supervisor) > > Zeng Guang (3): > KVM: emulator: Add emulation of LASS violation checks on linear > address > KVM: VMX: Virtualize LASS > KVM: x86: Advertise LASS CPUID to user space This all looks good! I have a few minor nits, but nothing I can't tweak when applying. Assuming nothing explodes in testing, I'll get this applied for 6.8 next week. My apologies for not getting to this sooner and missing 6.7 :-(