Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp5326rda; Fri, 20 Oct 2023 17:53:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEIh7cWpunwam+zTEgu6J9RlHdjVDomaWHXRrwNUYZEneoTyU0U7bY8wxQ2Kmdt2QbMiKcq X-Received: by 2002:a05:6358:2812:b0:166:dcf6:cd82 with SMTP id k18-20020a056358281200b00166dcf6cd82mr3629740rwb.14.1697849617827; Fri, 20 Oct 2023 17:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697849617; cv=none; d=google.com; s=arc-20160816; b=V06qBibFoKleYYJxlXn1t5Z/+Nv3T6HvYgblszy6cBcwnyCKcVNek3ZFy+9OGjWDsm tnQZqUxtb4MIzCz2W43R85nQpXGW3oQEnoLNmcK2otkx/CqW4ZUaoLkulE8jFna8P5Yl bmvMWzIUNPFcvkyOyffM9OS4xEWtI9Cdh9rRQpUjoBeQ7eVYmxpivAfcQBS5yiJxnxOc p84EIjXVW3fAynf9CHTsn1Dt9sanIyPkpogFT72HolEbzyh7yfN3NvPxvRBYuq+lD4fD fQt4leMvXot1qvw7+t4DMdwLd/baT1yH+AsIXzCqpeIxdz+2yZDfKADl+CSpQCLehKPH BoCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=cW9upQr0nx39qtNT8QlzJIm2ehcu8t98/lXwo9ElT0g=; fh=l62ROweN4pphvDFEG2T1DJDNz5MQ2gPmf4hrosEnork=; b=q/k13C0Glrc3xghlToINOIq5+XSsY5lvxHmYnfrpbOKRbLg2vGkm671LZoRjKsJYr8 cGPVt9lGHTLSRRERJt36+5+pRO4pUQtA9xIR+EwhnKeXgDmznWtXQzz1Y56u4pSjPjNP ZYxtoqkrsdpXZ3sk7pfxTAU4CIb0myYKx33I6XvDR27yZLKlE1kKdM6rgwu42ONEjPf/ guNXxPwLW6GWvcH1ao4PPKvlGKinAzpaUhIrY2yFLnwmyAiXLx+CqR5oXOkPSyBXxSMf xeMAmKUIZq/TDGCpGoGmpEGrxV1WRUqUIusVI5vfYwCEU0rDVhUPpeOO9NGL8xiTP0kf 1Bpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RrxEtuH3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id 144-20020a630296000000b0055b43079640si2952862pgc.707.2023.10.20.17.53.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 17:53:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=RrxEtuH3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CCF5B8313344; Fri, 20 Oct 2023 17:53:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233017AbjJUAx1 (ORCPT + 99 others); Fri, 20 Oct 2023 20:53:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230318AbjJUAxW (ORCPT ); Fri, 20 Oct 2023 20:53:22 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB867D7F; Fri, 20 Oct 2023 17:53:15 -0700 (PDT) Received: from mercury (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 593116607332; Sat, 21 Oct 2023 01:53:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697849594; bh=n+cp6ATKcN+tRvhf+29E1cAWuHZDFud0FRdhecmVEyc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=RrxEtuH3C4f6Vch/+SimF3XL4qNqVaVQVY++iL8EDB+zvWHlOxoIxHQvJSrFCHetc lF364MHWTdFYSPAgAF2cvy9sKkdOGWTMmD1y9+4FNySwCs6AGC+Fl8WMYN/eAZcKAc 3UPI/eXYpAr/HR3p/+SlXTPnqclFQ7bvAz8R1/Bp+7yc0l6agFmLJrlwza7qGSgCaW UBV5+o6sk5N27Dx300e8GjbQhMaXTWVxKKy5tVgbLpvqZhOd/u21AoXmO7ZNSmWH6z vA9vs35uS5eiXWYrzbosDa57sBtMFD2RbAsspoOq0JSsIt2HXrjL5eTDpYjXdbaHlb lk0goFfEfWMmg== Received: by mercury (Postfix, from userid 1000) id 2DC55106061E; Sat, 21 Oct 2023 02:53:11 +0200 (CEST) From: Sebastian Reichel To: Sebastian Reichel , Justin Stitt Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org In-Reply-To: <20231020-strncpy-drivers-power-supply-bq24190_charger-c-v1-1-e896223cb795@google.com> References: <20231020-strncpy-drivers-power-supply-bq24190_charger-c-v1-1-e896223cb795@google.com> Subject: Re: [PATCH] power: supply: bq24190_charger: replace deprecated strncpy with strscpy Message-Id: <169784959113.1512524.17628671686184916927.b4-ty@collabora.com> Date: Sat, 21 Oct 2023 02:53:11 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 20 Oct 2023 17:53:37 -0700 (PDT) On Fri, 20 Oct 2023 18:14:47 +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > We expect bdi->model_name to be NUL-terminated based on its usage with > sysfs_emit and format strings: > > [...] Applied, thanks! [1/1] power: supply: bq24190_charger: replace deprecated strncpy with strscpy commit: b0009b8bed98bd5d59449af48781703df261c247 Best regards, -- Sebastian Reichel