Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp106018rda; Fri, 20 Oct 2023 23:52:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7CCPxd3/pgJFRx1E/zU/51kp2cn3pkbiz1LIkRruklAyfFmoesDUsl8C7n/LRMxy49+Bi X-Received: by 2002:a17:90a:7547:b0:27d:5504:4ccc with SMTP id q65-20020a17090a754700b0027d55044cccmr3973188pjk.11.1697871128005; Fri, 20 Oct 2023 23:52:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697871127; cv=none; d=google.com; s=arc-20160816; b=O91yKCO/qBgjkxgDqTfuVZ5Rxc1wPO5oGXTohRt1VEs8SrIrySIjPlQrXiDbLUR1Rl 1GPBP4x1Sb1Wn6KGH0qyzlXs4omGXVSC6ismExSMt8TEhk/TMbnlErWXhpLdUfpHDNhr acxTqFeEDUYXkGw+3NfEckvKaWtbvH6/Qqep8Dkk8GGhMiLNe6cdEVJXPJEuLM3J6fg9 B6tGFROrBoicefgs3cni5sVI1w/Yi8z7sGTtdAC7JXOiL6M+y+jXudLGm4Qa+suH40iU +7Syukk934f/p9Prfsx9DHC5X5jmBlspcdK3H2+zlBu3mjNGHp5P1au3UjYFyERlUP/k xhkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=11a/aKEUviI8GdRYhbzbJOfh3iA/VK6ux5c587n3a5g=; fh=c9kQ7b76oMMEw7O7fl1aUyHcSgDOfCkyEPyvCOQht34=; b=ACDOZijVB+KrHijTj3jfyJQPxRuDzYoqLRjTZ0xCrynXleVzdPgJkkgbkYKqQ1ZBnU 03I9xTKrnbNtuSnfSAmSgfZPPR1a05Z9CqTF/V3nXCZxuH1TcJtZoGmItFfxFGprRfHy w8D7m+2MzPdbLNmodyfE2lDCa4tYv/3TTZQi9XqW48sjK3gGgn4RoAzr1Ra37Dhhvrjl Vm5Ij0Jd32gXitT8EYzaBucR0XDh7XTOPk+CvlMIQVCxV9k4mFxafcxBQRKVc70JfJqA 44FDIvbWSYgRPgkaN91/2Sk6+efPkSGhf5hJ/GyCiJdw+l+glEZlNCh6buwuIuwBxRax McsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OOhLdhT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id s9-20020a170902ea0900b001bb993ef74bsi1558945plg.540.2023.10.20.23.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 23:52:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OOhLdhT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 7F0628096587; Fri, 20 Oct 2023 23:51:34 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjJUGu4 (ORCPT + 99 others); Sat, 21 Oct 2023 02:50:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjJUGuz (ORCPT ); Sat, 21 Oct 2023 02:50:55 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27FB913E for ; Fri, 20 Oct 2023 23:50:51 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53d82bea507so2330358a12.2 for ; Fri, 20 Oct 2023 23:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697871049; x=1698475849; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=11a/aKEUviI8GdRYhbzbJOfh3iA/VK6ux5c587n3a5g=; b=OOhLdhT6Sv0O+SumshEc+efYsZkAT2cqMocBmsEHOO3hoRa1XrG1T95NJW7pbOtieO pLV0v2c3aJbc/R+6BKYv7uQ693cul799GBJ46KuiL/eF613HELCVAkqLupTpim74JWPi jpsJ2feQVvjbcoPagAdTcStRdsXRt7imCt7/r47dL+iWq5lXN4ppYGimtv+AzWhyzAgC YfNPCpFIJdu1PycvWQESO6X/lToS037Frw42j59EX4FeN27k8v989rqFnfUzCLNcVvsT MPf5c8T3AwpSdnf8IaQEjwKcYrAAJp1OH6CZINNFyGR0RjAmb0jOgWQtEhx8D5jJ3VkU c54Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697871049; x=1698475849; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=11a/aKEUviI8GdRYhbzbJOfh3iA/VK6ux5c587n3a5g=; b=Jt45nA1sq1s3bRW+U9d8QUQj10V6G3DRB6WYrZfGc0xwT5sgRQow6m/Qx/ylPV4IEc erIlcp5AQQVtmLKic67FYEaa1oiDu8i9Av7RlzN0Sdj2QVYRGmLOWT1G/XFuqwtG9H+K fpDpNSG5R0wsMlN9dxHiZxsQ1vcDC/6FxbGdckcVmzd6H0iW9rm4qzOF6w4AkMyxldRX kA+RaB6VsFYCRqlP6AQzCXk1x31vYGLRGEgRx6tCkl6w7Yh2fBnbcPrcCIMHYhyBoHjg 18wJNqexKmlIqpq/nTYhBNLxFGpAcP8164ZV+3+NPzqvBFPTfidiaQHDeo5NzuJLpa37 rbAA== X-Gm-Message-State: AOJu0Yx6yXVYvWBWzE+z+oXVnN4w4R546auLod7H/cU47D55k9lffl30 WEkwnBvvTiwMVMSCm4E4vao= X-Received: by 2002:a50:cc0c:0:b0:53e:10a1:21d with SMTP id m12-20020a50cc0c000000b0053e10a1021dmr2431375edi.35.1697871049359; Fri, 20 Oct 2023 23:50:49 -0700 (PDT) Received: from gmail.com (1F2EF1E7.nat.pool.telekom.hu. [31.46.241.231]) by smtp.gmail.com with ESMTPSA id o2-20020a509b02000000b0053db0df6970sm2914958edi.54.2023.10.20.23.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 23:50:48 -0700 (PDT) Sender: Ingo Molnar Date: Sat, 21 Oct 2023 08:50:46 +0200 From: Ingo Molnar To: Vincent Guittot Cc: "Joel Fernandes (Google)" , linux-kernel@vger.kernel.org, Ingo Molnar , Peter Zijlstra , Juri Lelli , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , "Vineeth Pillai (Google)" , Suleiman Souhlal , Frederic Weisbecker , "Paul E . McKenney" Subject: Re: [PATCH 3/3] sched: Update ->next_balance correctly during newidle balance Message-ID: References: <20231020014031.919742-1-joel@joelfernandes.org> <20231020014031.919742-3-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 20 Oct 2023 23:51:34 -0700 (PDT) * Vincent Guittot wrote: > Hi Ingo, > > On Fri, 20 Oct 2023 at 09:53, Ingo Molnar wrote: > > > > > > ... > > > > curr_cost += domain_cost; > > > t0 = t1; > > > > Okay, I'm applying patches #2 and #3, without #1: it should be safe > > out of order, but let me know if I missed something ... > > Could you hold on for patch 3 ? As replied to Joel, the patch had > regression in the update of rq->next_balance Yeah, patch #3 is gone already from tip:sched/core. Thanks, Ingo