Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp288258rda; Sat, 21 Oct 2023 07:49:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEl3tc5eEsL7076DjFyAptBCCP72EuEIohBkwXYlVgAO6yCIr7cVOCuajl0gUbpnkHnERg7 X-Received: by 2002:a17:903:110d:b0:1c9:e508:ad43 with SMTP id n13-20020a170903110d00b001c9e508ad43mr4632049plh.8.1697899786937; Sat, 21 Oct 2023 07:49:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697899786; cv=none; d=google.com; s=arc-20160816; b=rBF51P/KFDIbw0Yv4GfXy3RzGpIesthXlKzVzvv1QkDcb6neAY2Wkgg7UxV/kjpaXT t8UO4w/G5AO/89MKR4yCrSeDOGYHq+xRhh7PQskHouXxT0YHBaJpm5lExH704e02QoKx DBowXlAzihrPuMaDNFwRe+usrqRADfEVs7Cfr/y4imLOAQnnUajW/7FT16V1a/JfAdlT jMrw+dQ79jWZd8Sk3TmmZujdIXt7VjihetjUxSvcc2n4zaNeh5VAuZy8JJ2BjLpO+Q8j x9N6NkyDpG6Hzsyf6uSuDWx5Fkig/Ha3xGZZTyPuhtCI2pzIh0ETZwAEVPnFUJ3AE3qD Ha3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=yyLPGEgSgRLGHS320ryZpZAtQHgBe1tEJpa9w8HoNtg=; fh=eHa7Z3zbFWM18AVJ5pDRDTgWoVjL+mntYwvIzfMcSJc=; b=mnFFXtJsYZ6WeOtbfv9c5gIMvlR/RasoCXTIA8olhSE+yHFC0dQrXIU+RCFxDMrT1q r4eVsHVRciyoC5iTz7YXx0gaKoUyjydZAfuiJT1Hrk/AeDAvnjLH2N1OyYGunIbZKwv4 JoekrUy0D2HHtLIwBQRnrCz72ZY93+xOh2ocCTnaICdFJXFWwt1gONXN/WmJSROS/7jC 8Rkm6YLA2VDzUbrmkf9S9aCrle1mz5UwA+Li6YB5EfvA8jU1rr71jZlCQfmtiz5gcMK9 GcjxIgPeE48rWO8U2TC2GTr5QAykr23evnRrNy9b+bXr1gWMROGjfNh/4bUxHGrK779Z jVAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bQpwkWZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z7-20020a1709028f8700b001c9ff461649si3451189plo.581.2023.10.21.07.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 07:49:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=bQpwkWZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 3F3D980942D6; Sat, 21 Oct 2023 07:49:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbjJUOtS (ORCPT + 99 others); Sat, 21 Oct 2023 10:49:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJUOtR (ORCPT ); Sat, 21 Oct 2023 10:49:17 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2705CDA for ; Sat, 21 Oct 2023 07:49:12 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1c9d4f08d7cso121865ad.0 for ; Sat, 21 Oct 2023 07:49:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1697899751; x=1698504551; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yyLPGEgSgRLGHS320ryZpZAtQHgBe1tEJpa9w8HoNtg=; b=bQpwkWZJmA7EbWbzOLHu6uDMR7R+l9SfpBsW5fi+bjxDk20zK+5sr4NofIRyA6AktG 1uuxfHsOuQIwkcODOoRYcC28V12FA7OEMNNuzU6cvN/xXtfDshFTOrefmZSW+ZMlaGdq 06rTvm1Xvxrff5nHe73s3pQk9a20ZB+Y2lBrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697899751; x=1698504551; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yyLPGEgSgRLGHS320ryZpZAtQHgBe1tEJpa9w8HoNtg=; b=vcJEywtFgG+nARniuhS/F1iSIjxZJkg1jwmGrPp6Zikcyn1xc6RZAI9wwdW5eh0vXJ g22rIQBEq5uB8Zbp2vAv72XLnxJHEt81zTWGoWJyG2ikMDjM7qZQ+dwclFF2XJR/8EWB 1jzWaUauC2zz/8ZC7lBfpeYOskCy+JpeaU4I0clrGCzUETyv6NjHDQh+UtxhUfkFwKKZ AYzlSDihCVL3bmp4MoNsn4UEZyEu3TzZAV++z5uXhDiOzQ852INE1MdoUoDnc+md0Pcu AOfXheAaVQkXCO+AvYamVLHxQURwbOBZSs14+4Pop6O9qHQaLnguonEKBDaKGVbJFJJj Biqg== X-Gm-Message-State: AOJu0YxJA14uvG8ElUFVu/cR8qCz5JUr07rJqnaaEcynvOHC6SV9L+Sv 2AGE6ZYDQx5AsAQjn32avjAgHSuEio1EOV4Cf/xN6Q== X-Received: by 2002:a17:903:24a:b0:1c4:65d5:34c5 with SMTP id j10-20020a170903024a00b001c465d534c5mr391892plh.23.1697899751177; Sat, 21 Oct 2023 07:49:11 -0700 (PDT) MIME-Version: 1.0 References: <20231020210751.3415723-1-dianders@chromium.org> <20231020140655.v5.1.I6e4fb5ae61b4c6ab32058cb12228fd5bd32da676@changeid> In-Reply-To: <20231020140655.v5.1.I6e4fb5ae61b4c6ab32058cb12228fd5bd32da676@changeid> From: Grant Grundler Date: Sat, 21 Oct 2023 07:48:59 -0700 Message-ID: Subject: Re: [PATCH v5 1/8] r8152: Increase USB control msg timeout to 5000ms as per spec To: Douglas Anderson Cc: Jakub Kicinski , Hayes Wang , "David S . Miller" , Edward Hill , Laura Nao , Alan Stern , Simon Horman , linux-usb@vger.kernel.org, Grant Grundler , =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 21 Oct 2023 07:49:42 -0700 (PDT) On Fri, Oct 20, 2023 at 2:08=E2=80=AFPM Douglas Anderson wrote: > > According to the comment next to USB_CTRL_GET_TIMEOUT and > USB_CTRL_SET_TIMEOUT, although sending/receiving control messages is > usually quite fast, the spec allows them to take up to 5 seconds. > Let's increase the timeout in the Realtek driver from 500ms to 5000ms > (using the #defines) to account for this. > > This is not just a theoretical change. The need for the longer timeout > was seen in testing. Specifically, if you drop a sc7180-trogdor based > Chromebook into the kdb debugger and then "go" again after sitting in > the debugger for a while, the next USB control message takes a long > time. Out of ~40 tests the slowest USB control message was 4.5 > seconds. > > While dropping into kdb is not exactly an end-user scenario, the above > is similar to what could happen due to an temporary interrupt storm, > what could happen if there was a host controller (HW or SW) issue, or > what could happen if the Realtek device got into a confused state and > needed time to recover. > > This change is fairly critical since the r8152 driver in Linux doesn't > expect register reads/writes (which are backed by USB control > messages) to fail. > > Fixes: ac718b69301c ("net/usb: new driver for RTL8152") > Suggested-by: Hayes Wang > Signed-off-by: Douglas Anderson Reviewed-by: Grant Grundler > --- > > (no changes since v1) > > drivers/net/usb/r8152.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 0c13d9950cd8..482957beae66 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -1212,7 +1212,7 @@ int get_registers(struct r8152 *tp, u16 value, u16 = index, u16 size, void *data) > > ret =3D usb_control_msg(tp->udev, tp->pipe_ctrl_in, > RTL8152_REQ_GET_REGS, RTL8152_REQT_READ, > - value, index, tmp, size, 500); > + value, index, tmp, size, USB_CTRL_GET_TIMEO= UT); > if (ret < 0) > memset(data, 0xff, size); > else > @@ -1235,7 +1235,7 @@ int set_registers(struct r8152 *tp, u16 value, u16 = index, u16 size, void *data) > > ret =3D usb_control_msg(tp->udev, tp->pipe_ctrl_out, > RTL8152_REQ_SET_REGS, RTL8152_REQT_WRITE, > - value, index, tmp, size, 500); > + value, index, tmp, size, USB_CTRL_SET_TIMEO= UT); > > kfree(tmp); > > @@ -9494,7 +9494,8 @@ static u8 __rtl_get_hw_ver(struct usb_device *udev) > > ret =3D usb_control_msg(udev, usb_rcvctrlpipe(udev, 0), > RTL8152_REQ_GET_REGS, RTL8152_REQT_READ, > - PLA_TCR0, MCU_TYPE_PLA, tmp, sizeof(*tmp), = 500); > + PLA_TCR0, MCU_TYPE_PLA, tmp, sizeof(*tmp), > + USB_CTRL_GET_TIMEOUT); > if (ret > 0) > ocp_data =3D (__le32_to_cpu(*tmp) >> 16) & VERSION_MASK; > > -- > 2.42.0.758.gaed0368e0e-goog >