Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp353107rda; Sat, 21 Oct 2023 10:18:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF57mFdKtKj8rV/9ZkHNticN9Ys6Obh3umN+lO0qxARvUW4WfHPK8bPklCVlQ8T710XX/Kn X-Received: by 2002:a05:6a21:47cb:b0:162:650c:76b8 with SMTP id as11-20020a056a2147cb00b00162650c76b8mr4859180pzc.45.1697908706242; Sat, 21 Oct 2023 10:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697908706; cv=none; d=google.com; s=arc-20160816; b=lPRLK3I2dcP0t8SU31vXcZE5ixFdVgOEJ5zG/vT798gTUBDg5KZo3hzoZklFJJmdES ypaSEUD85FItH6dn2iyKIokJJOkraYGWA81QFWhgLTnuRDFi5OtnIGfDXcrAchslx+sI XO02t7SWCaGOXg26fdmTZgDf302EZCwwVioWEX4E2IlwVQuef06z9VQhQ1kQXNUNGeFn XFM6C1LzpNNtlJyBeNKxQ8t9EogkDp+KKM2nhxuEFx66Av1JNCwLEax9sxlbgKYL2vS7 T6AKJT3TbBmJuPvkrpwD6FZ5nyQRtBE5Sw7yxBXFQxNi6eIxI6ON/Zx0sLoeSircCKNH nyaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7HrUqHhclSdzmKbMLivpligH/l3C9pbEQ+g3Fvh2kHA=; fh=syXcwpA1YMm8icVopdP2mefz7JROZgg25zoA3CcjkQg=; b=u/cWvOKm4v+zRA80W99fSdoKHQK1eO9HmGgco+k8PlM0Oa0vIDa31NgQlmEfLA/tp+ vL4hN2Xk5CUd0vjMEetGCEt55q7XDFmm9JoZaZTsRgv5pv8h3of7j2y+0/H7Cw/8z70i 02xjsnKZHZPFkuWE8G+3691FAW0l/j4+7/8cB/BJPoZsouER4+tUi99PnN+6yZFjeBgE H0rLjO3EQQjCcoG8zHrlRwBW63r/dciixwARjiE9fa4tFDwwZHY8UurCQnPoPSd2D9cH UvqP+srEGdEt466MtqkOYJqr8kI0bc8YftsxsqMkEpj0QLTnqqxZWTMfQA9gK7gn9Nmt qftw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aGrABgB2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bu23-20020a632957000000b005b881cc9497si2728195pgb.320.2023.10.21.10.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 10:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aGrABgB2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 24161807C852; Sat, 21 Oct 2023 10:18:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232227AbjJURSY (ORCPT + 99 others); Sat, 21 Oct 2023 13:18:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231550AbjJURSW (ORCPT ); Sat, 21 Oct 2023 13:18:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3437E5 for ; Sat, 21 Oct 2023 10:18:17 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3180BC433C9; Sat, 21 Oct 2023 17:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697908697; bh=1jJLkfQFRdwlc6uR8h0OoDnZjlKewWJVl/5PyS9siHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aGrABgB2Nz+5Gq00dyRMwIUGb+FZFyqgRQ04mSQkDcmNbc3COVMZBcXrfL1voGfeb GUcwO7DOqnsRejVNN+Vna2Si3hAUDr5JxZNOBR9wdgYDcFYFSo7yfdZqNu3slb+XPD X/w5+TPJceTtZvpEQW3SpY0Ix0KfCpqbpr2tNxtE= Date: Sat, 21 Oct 2023 19:18:14 +0200 From: Greg KH To: srinivas.kandagatla@linaro.org Cc: linux-kernel@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Miquel Raynal Subject: Re: [PATCH 4/6] Revert "nvmem: add new config option" Message-ID: <2023102100-tile-spinning-fa1b@gregkh> References: <20231020105545.216052-1-srinivas.kandagatla@linaro.org> <20231020105545.216052-5-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231020105545.216052-5-srinivas.kandagatla@linaro.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 21 Oct 2023 10:18:25 -0700 (PDT) On Fri, Oct 20, 2023 at 11:55:43AM +0100, srinivas.kandagatla@linaro.org wrote: > From: Rafał Miłecki > > This reverts commit 517f14d9cf3533d5ab4fded195ab6f80a92e378f. > > It seems that "no_of_node" config option was added to help mtd's case. > > DT nodes of MTD partitions (that are also NVMEM devices) may contain > subnodes that SHOULD NOT be treated as NVMEM fixed cells. To prevent > NVMEM core code from parsing them "no_of_node" was set to true and that > made for_each_child_of_node() in NVMEM a no-op. > > With the introduction of "add_legacy_fixed_of_cells" config option > things got more explicit. MTD subsystem simply tells NVMEM when to look > for fixed cells and there is no need to hack "of_node" pointer anymore. > > Signed-off-by: Rafał Miłecki > Reviewed-by: Miquel Raynal > Signed-off-by: Srinivas Kandagatla Why isn't this also marked for stable trees? thanks, greg k-h