Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Date:   Sat, 21 Oct 2023 19:57:47 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Herve Codina <herve.codina@bootlin.com>
Cc:     Peter Rosin <peda@axentia.se>, Stephen Warren <swarren@nvidia.com>,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Cameron <jic23@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        stable@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 1/3] i2c: muxes: i2c-mux-pinctrl: Use
 of_get_i2c_adapter_by_node()
Message-ID: <ZTQRG81wfrLYJo74@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Herve Codina <herve.codina@bootlin.com>,
        Peter Rosin <peda@axentia.se>, Stephen Warren <swarren@nvidia.com>,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Cameron <jic23@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        stable@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
References: <20231020153017.759926-1-herve.codina@bootlin.com>
 <20231020153017.759926-2-herve.codina@bootlin.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="e+2AHZSc7n833TFr"
Content-Disposition: inline
In-Reply-To: <20231020153017.759926-2-herve.codina@bootlin.com>
Precedence: bulk


--e+2AHZSc7n833TFr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 20, 2023 at 05:30:11PM +0200, Herve Codina wrote:
> i2c-mux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
> i2c_put_adapter(). These pair alone is not correct to properly lock the
> I2C parent adapter.
>=20
> Indeed, i2c_put_adapter() decrements the module refcount while
> of_find_i2c_adapter_by_node() does not increment it. This leads to an
> underflow of the parent module refcount.
>=20
> Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
> correctly the module refcount.
>=20
> Fixes: c4aee3e1b0de ("i2c: mux: pinctrl: remove platform_data")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Cc: stable@vger.kernel.org
> Acked-by: Peter Rosin <peda@axentia.se>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Applied to for-current, thanks!


--e+2AHZSc7n833TFr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmU0ERcACgkQFA3kzBSg
KbZceA//SLD4wYCVZ4MeysN0/8ZkjP3dT3AsTf6bqABvSTS23dQpmI/NDpPpy7D1
x8hpP1RtzvXgUUjTMJAhhd7/mG5zUlrKwCqLtNHEtVNuUNhwBhgULl7uRcUh7Bve
6cHP4GTLMOhttXvksLr0iUGsNB4ijlPnDi5NcPWbuXIjmhuPTU6SOFHij4xHlQ/Q
AyNt3AQE2+qNY5xUjMW5s4qa+U9tViMEy5WkjfsYneIU7LcXyJrvWdp612x1CRW7
IEuFmHzk3sQ6EEDnMfcByshPAD6FEtp3RI4QeaRPDnluraCrwtfcoyDfIHanZ8sw
MaHWbINyZxpM4tSDbpHm6ZVai0N7T4syTFXLqf7Miv26PSYxekhDmu6SOHv3Fv/E
axP7noVssPBXbwu14PYgI7OyZ9v5CRTjYsYwiPp3WVeli91y3bE7tV3Z7m1Braj9
f9bKFOYpYPmXd5suD9gf+MqOSHSAZ2uQSP7osn0ZNIZG8QrFwJi4V0AjeOU+/Lbj
lNRj4N6pfegsiHzW/06tUbAcs9Jba2UfHDTJFqzVlFb+tFxyT9jygVWFfDs6DEHV
jnAwEC8GSbltCl1PdKpUkoOwMUMHDjjFLaODFc+kDM1rVvO4PSgf6+C1UsE2T+zs
lEF5cQ1Di1zUbHiKM79sbAKT0Oaedhh7K1ITsY+gQOhkvaMN0eg=
=cyp0
-----END PGP SIGNATURE-----

--e+2AHZSc7n833TFr--