Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Sat, 21 Oct 2023 19:58:08 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Herve Codina <herve.codina@bootlin.com>
Cc:     Peter Rosin <peda@axentia.se>, Stephen Warren <swarren@nvidia.com>,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Cameron <jic23@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        stable@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH v3 3/3] i2c: muxes: i2c-mux-gpmux: Use
 of_get_i2c_adapter_by_node()
Message-ID: <ZTQRMG+IGMyM/PIf@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Herve Codina <herve.codina@bootlin.com>,
        Peter Rosin <peda@axentia.se>, Stephen Warren <swarren@nvidia.com>,
        Rob Herring <robh@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Cameron <jic23@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Allan Nielsen <allan.nielsen@microchip.com>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        Steen Hegelund <steen.hegelund@microchip.com>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        stable@vger.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
References: <20231020153017.759926-1-herve.codina@bootlin.com>
 <20231020153017.759926-4-herve.codina@bootlin.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="bKdObAA9+5DRRzFe"
Content-Disposition: inline
In-Reply-To: <20231020153017.759926-4-herve.codina@bootlin.com>
Precedence: bulk


--bKdObAA9+5DRRzFe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 20, 2023 at 05:30:13PM +0200, Herve Codina wrote:
> i2c-mux-gpmux uses the pair of_find_i2c_adapter_by_node() /
> i2c_put_adapter(). These pair alone is not correct to properly lock the
> I2C parent adapter.
>=20
> Indeed, i2c_put_adapter() decrements the module refcount while
> of_find_i2c_adapter_by_node() does not increment it. This leads to an
> underflow of the parent module refcount.
>=20
> Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
> correctly the module refcount.
>=20
> Fixes: ac8498f0ce53 ("i2c: i2c-mux-gpmux: new driver")
> Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> Cc: stable@vger.kernel.org
> Acked-by: Peter Rosin <peda@axentia.se>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Applied to for-current, thanks!


--bKdObAA9+5DRRzFe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmU0ETAACgkQFA3kzBSg
KbYotw/9H5yLe18QGWIzB99u5ZQtqYrFPqfJ97aASuvaLBJH5D2I2oMEu5VfOe3r
n5uW6mKilgM/g1Dw0jzfNXP+rzrc1beu7KeYK7WIhtmvdet7WYd+KzJYfM/Pxy/e
6izTwfCNW4p2A0xjb+T4kN0/GYnUIvG9SfbJsSpB6jlLplZ2uoTOqMMIfr0kx1bi
nkfXvaJv2KwhaNRZq9WSDekHLYPPEQNvXnOgvDKWPz7EP45IpBAodw9GAXa8Eq4c
sCn6e/0vbuCNp8r/iMGpMFZMgZVaiQe0R0tTt4bHatmzMjUe7kCJytJnu6GYt2kj
0QKX/1ubGVhkjfr0/1xxjCVNJrzFD71EX2BcR60v7N51xErhcSkMyy6kiL1JiYCt
R3HOa3MhUbcwrsFgXjkx3z1/VRHTVONijY62ayORKdo9ovdQ10+dfLNrQ3TYw4X2
KyJCPbaoSsvUyZEnLt2oMPNZZ7+L5ePsz+nNc+agcW1D0UJen53dU+7zr2TYRf3g
0TsVoA89J0z/282ycr4bKc4Mlszb3+bEOxuHmQ3VqbvjMKA5oj1zBgoMwEhjb3GK
t5M+11mb0wnpIDL0+1pY6humwzYUAdTYiAIHfiAsI3evHhww9XCJrOYpP0MChO3e
B1Wp+f1tpTqh3A/w+gmmpeCvtWoC3THouTVcHAW4KxujrbBRo3w=
=YdAO
-----END PGP SIGNATURE-----

--bKdObAA9+5DRRzFe--