Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp382394rda; Sat, 21 Oct 2023 11:45:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpS099Qc2qXAe8MHuvN9bbfC/ZJzt2vmItf0R1sdLx2RZgSR00wH5styZvP88xpsfdC6dq X-Received: by 2002:a17:90a:355:b0:273:cb91:c74f with SMTP id 21-20020a17090a035500b00273cb91c74fmr4979015pjf.8.1697913950232; Sat, 21 Oct 2023 11:45:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697913950; cv=none; d=google.com; s=arc-20160816; b=cLcXPncyIYMpIFqtgB4cEG6lnxmVWBY9Hbxa/G+ijOoEhKGSTaHrXbZuYJhTOnfLFV 0oj9jhoq/v+cQdRetIdnoeM20i18/vGs0be6telIbh9xiAnnMPxwB624GZk/ruxL6tcF f9kJ+3gH3OaDyYdz6DyABq/izvB6VkPCE0UC3sqNfl9lXxg0mRntW45XwK0E7CXIF+IO 6SAtIqDnJfaJB7it2pl6HCzLG53p2wYdJo/a2WydD05mxI+99u6ikf8/7gBdn3RkhOO0 OU3QO16evaVOihZFThUzPYtCv5aWEsfBUdYUj7Sa9+uMmKs5oGP8fY1NgMNKCKpqx1pE s0yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qDs77fJMakS8G2egzdJDv2ZMmXE3QT+k1YMh6cSGPaE=; fh=VTckFrsUTg5xXO+uHW7B47EsFJkSAUNoZm0+mAh4oh0=; b=Xf5gOFuOxMjG+w82qaNUaQ/LzM3s/IBIPmhJQ3i/FNYrZxy/QORVAehU8+Av7ouOfc Uu1Mc5HXLfipk6slRNeGFlbeGvdav6AmJJBINv8qhPL8NIcHn2ZGh0E8sG3QWBlFDGu8 mWlAEQs99DJTB3WoS3+ovtQ4SmONptApQv764cePMsHgf8toOmE/1mZHWgwxb4iNiOEr e2lp4NGmVK0SzIrJ6yRcPoBCQ18BNOTkj7bfaiJ5SATzMs7I3wr3E7B/Zwb5OUFbqc/l iqZA7Do37hNgWdOly38OKmfxqE4YhRgpPgQM5EgMiIoNb7RGSVNAxjrpBL5EdR+adcoF O09A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=S7n0BBpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id n11-20020a17090a9f0b00b0027b49f7c003si6259593pjp.15.2023.10.21.11.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 11:45:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=S7n0BBpb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id D0ABF80765EC; Sat, 21 Oct 2023 11:45:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231611AbjJUSok (ORCPT + 99 others); Sat, 21 Oct 2023 14:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbjJUSoj (ORCPT ); Sat, 21 Oct 2023 14:44:39 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5A34F7 for ; Sat, 21 Oct 2023 11:44:31 -0700 (PDT) Received: from localhost (unknown [IPv6:2a02:8010:65b5:0:1ac0:4dff:feee:236a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: alarumbe) by madras.collabora.co.uk (Postfix) with ESMTPSA id ED03C6607337; Sat, 21 Oct 2023 19:44:29 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1697913870; bh=PREi321JkX/C3dlUZw8RUfqKwYZTabiYJQ1u5AFX0vk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S7n0BBpbWhvQm7vWkO6S4Ipg8U1RKiN4r2YtIO8zYtlsankzlAGWfxg9pN31GrbVQ lFVFF7cr6rsHtFKuddqCrfNd1RNxI2gNDX1uo1spTU4zR63kfrmifAAQCGYabTCXK9 QDkMsYWFuA30XXIUUrLoshweXRx3zgw6+uNZzgJBP/pQxa9Jg8eBCQQe8Zz7mxJvR/ JbpPh5vfbw9Wr9G0IrrAU0vLQpzAiUbT23hUja41KhOYp9bOqhHygT/nijdmf4m8Il +8ExNI1drKf6GUJO4uIa2Y7HXAborrNS4fBMj3m5f7HLeZmfY/qZruKlWWNt8ylnCi 4ep+pq1ei2/Cw== Date: Sat, 21 Oct 2023 19:44:28 +0100 From: =?utf-8?Q?Adri=C3=A1n?= Larumbe To: Steven Price Cc: Boris Brezillon , Rob Herring , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: Re: [PATCH] drm/panfrost: Remove incorrect IS_ERR() check Message-ID: References: <20231020104405.53992-1-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231020104405.53992-1-steven.price@arm.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sat, 21 Oct 2023 11:45:08 -0700 (PDT) On 20.10.2023 11:44, Steven Price wrote: > sg_page_iter_page() doesn't return an error code, so the IS_ERR() check > is wrong and the error path will never be executed. This also allows > simplifying the code to remove the local variable 'page'. > > CC: Adrián Larumbe > Reported-by: Dan Carpenter > Closes: https://lore.kernel.org/r/376713ff-9a4f-4ea3-b097-fb5efb685d95@moroto.mountain > Signed-off-by: Steven Price Reviewed-by: Adrián Larumbe Tested-by: Adrián Larumbe > --- > drivers/gpu/drm/panfrost/panfrost_dump.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_dump.c b/drivers/gpu/drm/panfrost/panfrost_dump.c > index e7942ac449c6..47751302f1bc 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_dump.c > +++ b/drivers/gpu/drm/panfrost/panfrost_dump.c > @@ -220,16 +220,8 @@ void panfrost_core_dump(struct panfrost_job *job) > > iter.hdr->bomap.data[0] = bomap - bomap_start; > > - for_each_sgtable_page(bo->base.sgt, &page_iter, 0) { > - struct page *page = sg_page_iter_page(&page_iter); > - > - if (!IS_ERR(page)) { > - *bomap++ = page_to_phys(page); > - } else { > - dev_err(pfdev->dev, "Panfrost Dump: wrong page\n"); > - *bomap++ = 0; > - } > - } > + for_each_sgtable_page(bo->base.sgt, &page_iter, 0) > + *bomap++ = page_to_phys(sg_page_iter_page(&page_iter)); > > iter.hdr->bomap.iova = mapping->mmnode.start << PAGE_SHIFT; > > -- > 2.34.1