Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp421887rda; Sat, 21 Oct 2023 13:57:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXuO0x6r/9wy2ClAxBgF6tJYvNLp1ZY0HQO//8IVLv39Pc4IbAt+GLtjIsdyRxAUZ8wB5g X-Received: by 2002:a17:902:f550:b0:1ca:7086:60f7 with SMTP id h16-20020a170902f55000b001ca708660f7mr5950385plf.28.1697921857685; Sat, 21 Oct 2023 13:57:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697921857; cv=none; d=google.com; s=arc-20160816; b=sM8VnMXP7szMkf0rJIBbVzJI/zhoeeaf+RmfKGdtUBrylmDNkFCC0Z5R1jygVclEgh IvgvH0zNktowHgLIP+CZOUl5I4hSlfBSghlCazh4Sv8fsoVNGsmZAR3trmrJygFmvxg2 2Q2leuJAnQ8ZGpr9EykXBlR9Xjc4k3A7CDVEIeg8q4U1A2/ye7zfoZHD9R5ees6695SW jWOzeaNYY51gTLXMXmJk+H074zQBtVod9qaI3UkCm72L84kvlKak+c83wUOjGVraLnyH 8SXbRC15N2XLpzsl5ywG5w2SMG2H4w+nOnxZWhLTtW9h+OqqfSjLmOWEYYJ8kapVpFLt ddWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=9rPhpIvCb6cXRxrUqL1CrargUpkR6WfQyerGphsQWtU=; fh=rIiOsBplQTRKaeOPzLbRxC3ku6+P0Tk9B5ZeFBm979Y=; b=D2rFSxsiK34sA9ANLVzcmG46/WnOW4LmmiBlw0S9p8S7rx4VPofAmT4VOqXfXSQSqK q5JxRu14tWAGkMIjUUmlqVOSdAASXjSnPNSg3UmH6zpQchDyOWVzRRC2KEizk9JSNCIK iWlBErZG43HRfUiyJGF4gdr1XA4CS62Jpwa2ytkEeDmXhkfkOk/gBeICT37MDkBkibkT sxmLBpl1ZU4Zeb3NGKTmC3NfZ2ESRs4RlHUBAukS25Kyj6SJCuLL5w0vYeBVpEvCK3NV Rjq7BKKD5Wr7n7wFpjviaYagjVayiQXwScPyioYm+Dqz+mmZZpgkQrZLPylNSh1huJ7R XtIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hyttQU58; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id n1-20020a170902d2c100b001c77674ea94si4222428plc.434.2023.10.21.13.57.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 13:57:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hyttQU58; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id D9503809C936; Sat, 21 Oct 2023 13:57:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232195AbjJUU5Q (ORCPT + 99 others); Sat, 21 Oct 2023 16:57:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjJUU5P (ORCPT ); Sat, 21 Oct 2023 16:57:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1898D1A3; Sat, 21 Oct 2023 13:57:09 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A375C433C7; Sat, 21 Oct 2023 20:57:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697921828; bh=gqGmE6hmHvzhPKtWB4NehmQpHW7mbANBLZnc6WG6YJQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hyttQU58CWrhRfBzn9vkTAZne6ABof1EmVRLNkvpJdIPs5eDNlj1wKRidSFwBzBnO AcElIhIFTTsx0VKJu/qW9eKgw7AJybRw5xJZvJsZW68sWlaXzHGMP9YCkG3PZRj6hy CKVwQgMlzKAEJ1V7Fj8FhNrd6hqXCyGCHf8+e0fQ= Date: Sat, 21 Oct 2023 22:57:06 +0200 From: "gregkh@linuxfoundation.org" To: Ricky WU Cc: "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "ulf.hansson@linaro.org" , "frank.li@vivo.com" , "u.kleine-koenig@pengutronix.de" , "yangyingliang@huawei.com" , "linux-mmc@vger.kernel.org" Subject: Re: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264 Message-ID: <2023102153-paramedic-washboard-29e3@gregkh> References: <121ced554a9e4f4791018e8f6a72d586@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <121ced554a9e4f4791018e8f6a72d586@realtek.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sat, 21 Oct 2023 13:57:33 -0700 (PDT) On Fri, Oct 20, 2023 at 08:13:46AM +0000, Ricky WU wrote: > In order to support new chip rts5264, the definitions of some internal > registers and workflow have to be modified. That is fine, but that should be a single patch, right? > Added rts5264.c rts5264.h for independent functions of the new chip rts5264 And then add new support in a new patch, this is still too big as one patch to attempt to review it properly. Would you like to review this as-is? thanks, greg k-h