Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Sun, 22 Oct 2023 12:24:55 +0200
From:   Florian Eckert <fe@dev.tdt.de>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Eckert.Florian@googlemail.com, jirislaby@kernel.org, pavel@ucw.cz,
        lee@kernel.org, kabel@kernel.org, u.kleine-koenig@pengutronix.de,
        ansuelsmth@gmail.com, m.brock@vanmierlo.com,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 1/3] tty: whitespaces in descriptions corrected by
 replacing tabs with spaces
In-Reply-To: <2023102110-starlight-wispy-1f28@gregkh>
References: <20231019112809.881730-1-fe@dev.tdt.de>
 <20231019112809.881730-2-fe@dev.tdt.de>
 <2023102110-starlight-wispy-1f28@gregkh>
Message-ID: <dce966de5bec159dae67d958653aaa42@dev.tdt.de>
User-Agent: Roundcube Webmail/1.3.17
Precedence: bulk

On 2023-10-21 18:28, Greg KH wrote:
> On Thu, Oct 19, 2023 at 01:28:07PM +0200, Florian Eckert wrote:
>> Tabs were used in the function description, to make this look more
>> uniform, the tabs were replaced by spaces where necessary.
>> 
>> While we're at it, I also replaced the 'ndashes' with simple dashes, 
>> since
>> only those are supported by sphinx.
>> 
>> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
>> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
>> ---
>>  drivers/tty/tty_io.c | 102 
>> +++++++++++++++++++++----------------------
>>  1 file changed, 51 insertions(+), 51 deletions(-)
> 
> This didn't apply cleanly as portions of this patch were already in my
> tree, what did tree did you make it against?

I have already seen that I should add a base commit next time.
So I made it against the master from last week.

However, I was not sure which tree to use as I am changing
something in the tty and led subsystem-

> Anyway, I've fixed it up and taken it now.

Thank you for adopting my change and correcting my commit so that
it can be applied cleanly.

I will not add this patch in the next series, as it is already in the
tty-testing branch [1] from you?

---
Florian

Links:
[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/commit/?h=tty-testing&id=838eb763c3e939a8de8d4c55a17ddcce737685c1