Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <your-ad-here.call-01697881440-ext-2458@work.hours>
 <CAHk-=wgTUz1bdY6zvsN4ED0arCLE8Sb==1GH8d0sjm5bu7zesQ@mail.gmail.com>
 <CAHk-=wjxAk=PQBX4OvscNfGKfc+M8iKmNd6D39wOZzXV0k729w@mail.gmail.com> <your-ad-here.call-01697980674-ext-9589@work.hours>
In-Reply-To: <your-ad-here.call-01697980674-ext-9589@work.hours>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Sun, 22 Oct 2023 07:54:13 -0700
Message-ID: <CAHk-=wizgxqjSk7fhyqPuW7Nkt3qwCkr-WKE2DsRu8tK7CC2Tw@mail.gmail.com>
Subject: Re: [GIT PULL] s390 fixes for 6.6-rc7
To:     Vasily Gorbik <gor@linux.ibm.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Kees Cook <keescook@chromium.org>,
        Heiko Carstens <hca@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, 22 Oct 2023 at 06:18, Vasily Gorbik <gor@linux.ibm.com> wrote:
>
> This might work.

Hmm. Yes.

But let's fix __KERNEL_DIV_ROUND_UP itself while at it.

(And perhaps move it out of the odd location it is in now - its in
<uapi/linux/const.h> for some unfathomable reason)

And maybe we could do a helper like

    #define __if_constexpr(x, a, b) \
        __builtin_choose_expr(__is_constexpr(x), a, b)

since that is one of the main reasons for that __is_constexpr macro
(and _that_ makes sense in the const.h header file).

                 Linus