Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp812812rda; Sun, 22 Oct 2023 10:51:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0xDTS+HwF0xFUSMufdVyNILzMueBXP5Y3dah2LUMC/5CmKJG2Xoh47CqctY6U4jCJYrzX X-Received: by 2002:a05:6a21:7746:b0:15d:42d5:6cb5 with SMTP id bc6-20020a056a21774600b0015d42d56cb5mr5206174pzc.28.1697997077067; Sun, 22 Oct 2023 10:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697997077; cv=none; d=google.com; s=arc-20160816; b=pmWX7RN5xv6zglAQUe9xoBbc77uXcCoi/jC8fdOc2LHWqjQXxUNDvY23PO7F0BHYvb cKEbmlUmJ5mdFHZD+3hkewmR4GW0RfvCY1JI9nZkvPJWERzPRToLo04x3STrjMqPhzPk cHMN7N2xD53VckMsFNE32YmL0OpU+gQny9yVLixL+Kyyjkb/Um9VsZk9NWlxg3lTeXTv P0yd7/yKZ1qfNJFBflpMEs2B4ZQcTjiuhiXCe+T563CI9m7swAvOzgGzEYp8H4DPKQhG g7QgSBjuOPPKsCxsQwnjraAJdFGQPrWwaldQKs/R1ShGvVcXwVVmQneh8zuI5Gb7VWhP IGRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=R5E5cZQ2yV5lpvemFWGGWdkfaDjj1N00uX2JJzJjrwU=; fh=gJjFc3hfGqFs8/x814dNSsK1F1/DHsEkCgLEGNW2EXY=; b=1HK2in9xv5r3vvX+ayC+rnvkZh8bjO/95l1Q5V4ibiMBDwPYsUt9YoVsDEFaNUVwlJ 8yfsOjQbZxaG529rn7hhFOuJfMKpsxUevE4y5JKzML4uH1UN025oopeNcaM3//FENtYN d7dZEHiSUfwj+10fzYo98QPvmnLK1pMRhHXnr9ukbnkkln66Dj6ctyPXbg7J5l+utdyp iBelbCHHgoRidSdkVA5DsDUj/ryUiZmuV+VGEcggvry5Lue2hajpzSPZIZhbHZGu8Sz6 lZxoFYzgfT+PFD6qUHkKGflZ2i0WbZSYPnwAfp+jFObBdX6Uecp2LTIyUf9+EPjrfqux bzuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uVZvQdXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id a10-20020a170902ee8a00b001cad3a9ff1dsi2852221pld.571.2023.10.22.10.51.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 10:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uVZvQdXv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id E03F480511A0; Sun, 22 Oct 2023 10:51:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232225AbjJVRu6 (ORCPT + 99 others); Sun, 22 Oct 2023 13:50:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjJVRu4 (ORCPT ); Sun, 22 Oct 2023 13:50:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D883AE8; Sun, 22 Oct 2023 10:50:54 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC802C433C7; Sun, 22 Oct 2023 17:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697997054; bh=a7bhSUEACARdlq+uMxJTYxwH4vFhfS8krMiwwfiEKSE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=uVZvQdXvjKYi6AzOm1BWXPZChWwTpjAO2Q98PUveYzLzJTehfW/4eSjrAY97EcIH8 /rC4gT6u2sUK62SKS8PTy7TvYrQ+NReci0UwTlHQzNe5gir3J5WphZDYl5ICNvsYfg CvcxNV1xfZA1RG5OlbEGf9QxtaGB0s9jxqnYQgv/iiWge8em318oaRNncDK93jiORP kb7bYrbGJFbOljYZI2qm2ZaEY9S3a4pJ5PMD6MO99d7j0aWPghpOcsa1XyQ7H5jUql jyAby27BeHzkn9XRhfDNUvvwz/dQZYHJoUgOLmEhWZihxk8q5bcYcVY2Quc37ZpwNS ImoDGXT6vpHyw== Message-ID: Date: Sun, 22 Oct 2023 11:50:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests:net change ifconfig with ip command Content-Language: en-US To: Swarup Laxman Kotiaklapudi , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, shuah@kernel.org, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org References: <20231022113148.2682-1-swarupkotikalapudi@gmail.com> From: David Ahern In-Reply-To: <20231022113148.2682-1-swarupkotikalapudi@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Sun, 22 Oct 2023 10:51:15 -0700 (PDT) On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: > diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh > index 116bfeab72fa..3ab9beb4462c 100755 > --- a/tools/testing/selftests/net/route_localnet.sh > +++ b/tools/testing/selftests/net/route_localnet.sh > @@ -18,8 +18,10 @@ setup() { > ip route del 127.0.0.0/8 dev lo table local > ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local > > - ifconfig veth0 127.25.3.4/24 up > - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up > + ip a add 127.25.3.4/24 dev veth0 ip addr add ... > + ip link set dev veth0 up > + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1 ip addr add ... > + ip netns exec "${PEER_NS}" ip link set dev veth1 up > > ip route flush cache > ip netns exec "${PEER_NS}" ip route flush cache