Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20231020161217.255765-1-ak@linux.intel.com>
In-Reply-To: <20231020161217.255765-1-ak@linux.intel.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Mon, 23 Oct 2023 02:54:27 +0900
Message-ID: <CAK7LNAR4Z3O+qZwhc6w7MGEbJsd6B8QZtz1p4_F7OO3jK+aigA@mail.gmail.com>
Subject: Re: [PATCH] kbuild: Add inline-account tool
To:     Andi Kleen <ak@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Oct 21, 2023 at 1:12=E2=80=AFAM Andi Kleen <ak@linux.intel.com> wro=
te:
>
> A common cause of binary code bloat is excessive inlining. Traditional
> tools (like nm --size-sort -t d) don't address that directly because
> they only see the final functions, but don't know about inlines.
>
> This patch adds inline-account that makes it easy to track that down
> by accounting code bytes to all functions visible in the debug informatio=
n,
> as well as code lines.
>
> Here are some examples:
>
> Show all inlines that increase code size by >1K in the core scheduler:
>
> $ inline-account.py --min-bytes=3D1000 kernel/sched/core.o


How to use this tool?

I did not get any output.


masahiro@zoe:~/workspace/linux-kbuild(a)$ ./scripts/inline-account.py
--min-bytes=3D1000   kernel/sched/core.o
Total code bytes seen 0

Code bytes by functions:
Function                                           Total          Avg   Num

Code bytes by nearby source line blocks:
prefix
Line                                               Total
masahiro@zoe:~/workspace/linux-kbuild(a)$ ./scripts/inline-account.py
  kernel/sched/core.o
Total code bytes seen 0

Code bytes by functions:
Function                                           Total          Avg   Num

Code bytes by nearby source line blocks:
prefix
Line                                               Total
masahiro@zoe:~/workspace/linux-kbuild(a)$ ./scripts/inline-account.py
  lib/maple_tree.o
Total code bytes seen 0

Code bytes by functions:
Function                                           Total          Avg   Num

Code bytes by nearby source line blocks:
prefix
Line                                               Total


I do not think this patch is mature enough
regarding the coding style.

Please polish the code.


--=20
Best Regards
Masahiro Yamada