Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
MIME-Version: 1.0
References: <20231020170225.3632933-1-robh@kernel.org> <20231022201748.GA32105@pendragon.ideasonboard.com>
In-Reply-To: <20231022201748.GA32105@pendragon.ideasonboard.com>
From:   Rob Herring <robh@kernel.org>
Date:   Sun, 22 Oct 2023 15:59:16 -0500
Message-ID: <CAL_Jsq+UFZBM2bon3qogsq1az4fD0PW3-O2LJgLZ7Uf0zVsw6Q@mail.gmail.com>
Subject: Re: [PATCH] media: dt-bindings: ti,ds90ub960: Add missing type for "i2c-alias"
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Oct 22, 2023 at 3:17=E2=80=AFPM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Fri, Oct 20, 2023 at 12:02:24PM -0500, Rob Herring wrote:
> > Every DT property needs a type defined, but "i2c-alias" is missing any
> > type definition. It's a "uint32", so add a type reference.
> >
> > Fixes: 313e8b32c616 ("media: dt-bindings: media: add TI DS90UB960 FPD-L=
ink III Deserializer")
> > Signed-off-by: Rob Herring <robh@kernel.org>
>
> This is something I should have paid more attention when reviewing the
> bindings. I'll try to keep it in mind for the future.

No need, the tools will check for you now. :)

But the same property defined multiple times is not yet checked

> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks.

Rob