Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Sun, 22 Oct 2023 18:47:51 -0500
From:   Jeff LaBundy <jeff@labundy.com>
To:     Anshul Dalal <anshulusr@gmail.com>
Cc:     linux-input@vger.kernel.org, devicetree@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        linux-kernel-mentees@lists.linuxfoundation.org,
        linux-kernel@vger.kernel.org,
        Conor Dooley <conor.dooley@microchip.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v5 1/2] dt-bindings: input: bindings for Adafruit Seesaw
 Gamepad
Message-ID: <ZTW0p2WG3/m1Tx+Z@nixie71>
References: <20231017034356.1436677-1-anshulusr@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231017034356.1436677-1-anshulusr@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ntw+NENxfilzNNI6SE3DIPf9ywrjESvBtArqKi7JSghUkvTcxr7dkN4oPlvC?=
 =?us-ascii?Q?ygyvNhJNDh32KLWN9ljML3D7zoz44ZXCIUr0G4PtGxto3NhzbDwPZDxP4IhQ?=
 =?us-ascii?Q?VXUPX3y3nZgBDgBYWhcNwC16GvXLJhQXP1e+gBDpfCComwtLoLGmSaoDQReY?=
 =?us-ascii?Q?IQh3Pdj0OBF8p7p4Kl/LqKdtcUqqUrb+gN6H1wXzJNshvZrLIlOJvlPKXEEj?=
 =?us-ascii?Q?JK112YTknTaZMd0awgcFz3Lt6DeLQsvuSS/3ZzM0G+l9dtm4oNUl9trmqfsY?=
 =?us-ascii?Q?mbCkrq0zgY3VCmzgSVZmijd6xlUua1EjbXKPG0Pw4Q1XBOABLlJcJ6f61xaF?=
 =?us-ascii?Q?9P3Tca0S/oEk6Q0C3Sc20+EznCvEyBM4Necn5phL/8jUgwcefdsQTb282f/6?=
 =?us-ascii?Q?urKz1eCVFd14zSdvibANQLt6jniBge3bNtSDOORypzUecL9/bXz4aVG3hNbN?=
 =?us-ascii?Q?TkFjlmFTtt2gDfWjO5J2ox33qYEzCiETHm0dDMIYIhYanCgG9rBbvhMtuVT+?=
 =?us-ascii?Q?B3joVlHw171eiga9wqr6HyKiUTqi+pswiYxS6NN3KatnM907T+54fOqI8UM0?=
 =?us-ascii?Q?3SFjbGklfIzkcKU/uNel7MsuS2jgwpgrlfvPNuEVMWjufs3DaUCB3csOD3MR?=
 =?us-ascii?Q?ESnRF7R9xkg8z4ctcDCNmwu35IDpxhOc+597BZidQ6QeZ9SKZ3tlNYo/K8Qu?=
 =?us-ascii?Q?n/CPwDdOSsKC3oG4ZyBtTJMP5NeUEniILCaeuBzDS5MqV4VjgPCyXdRz6ENL?=
 =?us-ascii?Q?LTKVu+i3crAhAJdAEuwRc7pgF2BpH+62QCBl38t+RNtjeEJX2fFWB5D7/PSu?=
 =?us-ascii?Q?7M601SCHDrmiJJuxUQkAYPzXPBR1v8ZAvrLT8ZYBE0vDx2aJouAAZgCKluJ4?=
 =?us-ascii?Q?qw6mCcUsgXEXY+3HtCv9ShY2SnUPT99DTIYxA7D4Lhg19ArbYbgddGG3N0to?=
 =?us-ascii?Q?tWemTxNtmsI7zJkm4q3Go8KC1TxoBBPFMEs8VcoUdsIBeOW+URZROL7kpyBC?=
 =?us-ascii?Q?YAkSPgDN3bRIhl4+MZrg+ACzcYWtScyBCVJXPgTFUfu0uzOmorsgufyfCz6Y?=
 =?us-ascii?Q?/JVEN6BJLXAYHgNJaokTehWFsj3h7MKKI6Xycqjj4xsRp7soDGtkRzs2i7FV?=
 =?us-ascii?Q?mmYfs4hR/Q2vb+K+iyDxBtXXi3s9J+4GKuRt9jpQ3+PJ/0JidRzPjjhCNSBm?=
 =?us-ascii?Q?zSTPiVqSo6mmYbot/3n4YHmDp543Xdis/h+68VBpHV+ZfZ0acaOD5W0QiKkj?=
 =?us-ascii?Q?/PkQ/2ElQaq/BTAWAjM/rAt/S3dsSgNgCwbAJNCLxENd+RVAA0tDshPZBtF+?=
 =?us-ascii?Q?V5+cIvI0Cm+lhE5z8TRlz6SeB9DX7uXUWHFVcbqRyL0RPfc0k3ESWbOPIvZF?=
 =?us-ascii?Q?lTKXyYe7QCHW+7mKr0JuVMeQx2Mr7TBJ5akFmVqlgixESksrgaayuV5cVimI?=
 =?us-ascii?Q?QCHmEl4JCX8gx0gs5oPtaVO+3VwblBGjucMb9pxNucvnc43irjNgjCY+I2zH?=
 =?us-ascii?Q?tTy6+Hk3ShZnE2r7afwrRPk7HgD0q6FvzjmgZo98aSW7AaaZtKcoVG7I0D/l?=
 =?us-ascii?Q?dxL1sbZfOEERT5M5gi75dcXFuRvkvdYvKo97a6nI?=
X-OriginatorOrg: labundy.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34487936-e89c-4ef7-92be-08dbd3594fcb
X-MS-Exchange-CrossTenant-AuthSource: SN4PR0801MB3774.namprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2023 23:47:54.8339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 00b69d09-acab-4585-aca7-8fb7c6323e6f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gs6hUmugV4lgZC1Ff0NBguRDcnfoJ1uoJu4yb0ryB8e6ftgC6zVUI/pQUuqM/C9pDs7PP5Ij/Ljf88hqoKwMsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR08MB9286
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 22 Oct 2023 16:55:17 -0700 (PDT)

Hi Anshul,

On Tue, Oct 17, 2023 at 09:13:44AM +0530, Anshul Dalal wrote:
> Adds bindings for the Adafruit Seesaw Gamepad.
> 
> The gamepad functions as an i2c device with the default address of 0x50
> and has an IRQ pin that can be enabled in the driver to allow for a rising
> edge trigger on each button press or joystick movement.
> 
> Product page:
>   https://www.adafruit.com/product/5743
> Arduino driver:
>   https://github.com/adafruit/Adafruit_Seesaw
> 
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Anshul Dalal <anshulusr@gmail.com>

Perhaps this ship has sailed, but is there any reason this simple device
cannot be added to Documentation/devicetree/bindings/trivial-devices.yaml
as opposed to having its own binding?

It has no vendor-specific properties, and the only properties are the
standard properties already understood by the I2C core. In case I have
misunderstood, please let me know.

> ---
> 
> Changes for v5:
> - Added link to the datasheet
> 
> Changes for v4:
> - Fixed the URI for the id field
> - Added `interrupts` property
> 
> Changes for v3:
> - Updated id field to reflect updated file name from previous version
> - Added `reg` property
> 
> Changes for v2:
> - Renamed file to `adafruit,seesaw-gamepad.yaml`
> - Removed quotes for `$id` and `$schema`
> - Removed "Bindings for" from the description
> - Changed node name to the generic name "joystick"
> - Changed compatible to 'adafruit,seesaw-gamepad' instead of
>   'adafruit,seesaw_gamepad'
> 
>  .../input/adafruit,seesaw-gamepad.yaml        | 60 +++++++++++++++++++
>  1 file changed, 60 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
> new file mode 100644
> index 000000000000..3f0d1c5a3b9b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/adafruit,seesaw-gamepad.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/adafruit,seesaw-gamepad.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Adafruit Mini I2C Gamepad with seesaw
> +
> +maintainers:
> +  - Anshul Dalal <anshulusr@gmail.com>
> +
> +description: |
> +  Adafruit Mini I2C Gamepad
> +
> +    +-----------------------------+
> +    |   ___                       |
> +    |  /   \               (X)    |
> +    | |  S  |  __   __  (Y)   (A) |
> +    |  \___/  |ST| |SE|    (B)    |
> +    |                             |
> +    +-----------------------------+
> +
> +  S -> 10-bit percision bidirectional analog joystick
> +  ST -> Start
> +  SE -> Select
> +  X, A, B, Y -> Digital action buttons
> +
> +  Datasheet: https://cdn-learn.adafruit.com/downloads/pdf/gamepad-qt.pdf
> +  Product page: https://www.adafruit.com/product/5743
> +  Arduino Driver: https://github.com/adafruit/Adafruit_Seesaw
> +
> +properties:
> +  compatible:
> +    const: adafruit,seesaw-gamepad
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      The gamepad's IRQ pin triggers a rising edge if interrupts are enabled.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        joystick@50 {
> +            compatible = "adafruit,seesaw-gamepad";
> +            reg = <0x50>;
> +        };
> +    };
> -- 
> 2.42.0
> 

Kind regards,
Jeff LaBundy