Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   "Huang, Ying" <ying.huang@intel.com>
To:     Qi Zheng <zhengqi.arch@bytedance.com>
Cc:     akpm@linux-foundation.org, rppt@kernel.org, david@redhat.com,
        vbabka@suse.cz, mhocko@suse.com, willy@infradead.org,
        mgorman@techsingularity.net, mingo@kernel.org,
        aneesh.kumar@linux.ibm.com, hannes@cmpxchg.org, osalvador@suse.de,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 2/2] mm: memory_hotplug: drop memoryless node from
 fallback lists
In-Reply-To: <4bfa007c-a20f-9e68-4a9f-935dacf43222@bytedance.com> (Qi Zheng's
        message of "Fri, 20 Oct 2023 15:35:08 +0800")
References: <cover.1697711415.git.zhengqi.arch@bytedance.com>
        <9f1dbe7ee1301c7163b2770e32954ff5e3ecf2c4.1697711415.git.zhengqi.arch@bytedance.com>
        <87bkctg4f4.fsf@yhuang6-desk2.ccr.corp.intel.com>
        <4bfa007c-a20f-9e68-4a9f-935dacf43222@bytedance.com>
Date:   Mon, 23 Oct 2023 09:18:23 +0800
Message-ID: <8734y2f868.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Precedence: bulk

Qi Zheng <zhengqi.arch@bytedance.com> writes:

> Hi Ying,
>
> On 2023/10/20 15:05, Huang, Ying wrote:
>> Qi Zheng <zhengqi.arch@bytedance.com> writes:
>> 
>>> In offline_pages(), if a node becomes memoryless, we
>>> will clear its N_MEMORY state by calling node_states_clear_node().
>>> But we do this after rebuilding the zonelists by calling
>>> build_all_zonelists(), which will cause this memoryless node to
>>> still be in the fallback list of other nodes.
>> For fallback list, do you mean pgdat->node_zonelists[]?  If so, in
>> build_all_zonelists
>>    __build_all_zonelists
>>      build_zonelists
>>        build_zonelists_in_node_order
>>          build_zonerefs_node
>> populated_zone() will be checked before adding zone into zonelist.
>> So, IIUC, we will not try to allocate from the memory less node.
>
> Normally yes, but if it is the weird topology mentioned in [1], it's
> possible to allocate memory from it, it is a memoryless node, but it
> also has memory.
>
> In addition to the above case, I think it's reasonable to remove
> memory less node from node_order[] in advance. In this way it will
> not to be traversed in build_zonelists_in_node_order().
>
> [1]. https://lore.kernel.org/all/20230212110305.93670-1-zhengqi.arch@bytedance.com/

Got it!  Thank you for information.  I think that it may be good to
include this in the patch description to avoid potential confusing in
the future.

--
Best Regards,
Huang, Ying

> Thanks,
> Qi
>
>
>> --
>> Best Regards,
>> Huang, Ying
>> 
>>> This will incur
>>> some runtime overhead.
>>>
>>> To drop memoryless node from fallback lists in this case, just
>>> call node_states_clear_node() before calling build_all_zonelists().
>>>
>>> Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
>>> Acked-by: David Hildenbrand <david@redhat.com>
>> [snip]
>> --
>> Best Regards,
>> Huang, Ying