Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Mon, 23 Oct 2023 07:44:13 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Richard Weinberger <richard@nod.at>
Cc:     linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        vigneshr@ti.com, miquel.raynal@bootlin.com, joern@lazybastard.org,
        Christoph Hellwig <hch@lst.de>, stable@vger.kernel.org
Subject: Re: [PATCH] mtd: block2mtd: Add a valid holder to blkdev_put()
Message-ID: <20231023054413.GA11272@lst.de>
References: <20231021185832.25592-1-richard@nod.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231021185832.25592-1-richard@nod.at>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Sat, Oct 21, 2023 at 08:58:32PM +0200, Richard Weinberger wrote:
> Since commit 2736e8eeb0ccd ("block: use the holder as indication for exclusive opens")

Overly long line here.

> blkdev_put() requires a valid holder argument.
> So, do so also in block2mtd to unbreak bdev->bd_holder refcounting.


Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>