Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <2dc93e2b-61b4-943c-f938-296922fbece4@quicinc.com>
Date:   Mon, 23 Oct 2023 11:47:37 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 09/11] iio: adc: Update QCOM ADC drivers for bindings path
 change
Content-Language: en-US
To:     Jonathan Cameron <jic23@kernel.org>
CC:     <agross@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linus.walleij@linaro.org>,
        <Jonathan.Cameron@huawei.com>, <sboyd@kernel.org>,
        <dmitry.baryshkov@linaro.org>, <quic_subbaram@quicinc.com>,
        <quic_collinsd@quicinc.com>, <quic_kamalw@quicinc.com>,
        <marijn.suijten@somainline.org>,
        <andriy.shevchenko@linux.intel.com>,
        <krzysztof.kozlowski@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        <linux-arm-msm@vger.kernel.org>, <linux-iio@vger.kernel.org>,
        <linux-arm-msm-owner@vger.kernel.org>
References: <20230708072835.3035398-1-quic_jprakash@quicinc.com>
 <20230708072835.3035398-10-quic_jprakash@quicinc.com>
 <20230708162318.1e2b169f@jic23-huawei>
From:   Jishnu Prakash <quic_jprakash@quicinc.com>
In-Reply-To: <20230708162318.1e2b169f@jic23-huawei>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Jonathan,

On 7/8/2023 8:53 PM, Jonathan Cameron wrote:
> On Sat, 8 Jul 2023 12:58:33 +0530
> Jishnu Prakash <quic_jprakash@quicinc.com> wrote:
>
>> Update ADC dt-bindings file paths in QCOM ADC driver files to
>> match the dt-bindings change moving the files from 'iio' to
>> 'iio/adc' folder.
>>
>> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
> Do the move in one go.
>
> Diff rename detection will make the resulting patch more trivial
> to look at than this multistep version.
>
> Jonathan


Hi Jonathan,

Just to recap, in patches 8-11, the intention is to move the dt-binding 
files used for QCOM ADCs from /dt-bindings/iio folder to the 
/dt-bindings/iio/adc folder.

I'm just confirming, can we move the files and update documentation, 
bindings, driver and devicetree files all in one patch? Or you mean one 
patch for documentation, bindings and driver files and one patch for 
devicetree files (based on the comment from Krzysztof for the next patch 
10 in this series)?

Based on this patch series: 
https://lore.kernel.org/all/cover.1646388139.git.zong.li@sifive.com/, 
I'm wondering if I should add the files in the new location first, do 
the file path updates and then completely remove the files in the old 
path to avoid breaking the kernel.....or is it possible to get the 
devicetree changes picked along with the binding changes, to avoid any 
problems with bisectability?


>> ---
>>   drivers/iio/adc/qcom-spmi-adc5-gen3.c | 2 +-
>>   drivers/iio/adc/qcom-spmi-adc5.c      | 2 +-
>>   drivers/iio/adc/qcom-spmi-vadc.c      | 2 +-
>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>
Thanks,

Jishnu