Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1051370rda; Mon, 23 Oct 2023 00:12:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG58EfIVIuavzNIZoIVyCZG0hXbXKnmp+8J5defdSzm4vZufwBpPW36/jdgtV5aHle+C5R1 X-Received: by 2002:a05:6870:1394:b0:1e9:b08d:69f0 with SMTP id 20-20020a056870139400b001e9b08d69f0mr7399507oas.51.1698045171435; Mon, 23 Oct 2023 00:12:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698045171; cv=none; d=google.com; s=arc-20160816; b=Fkim6T38oZfF+cl1Y22+Iq5KJrcBt8okZW3Kny5lRTfO8F13xugLrQhgP94eV8HfUo 71vlOPw1CL4/ZyZGOkQbYwLsEjtQ/rCP3Oaf3ifTrWR4WP9SFa/1jAa24mFEZMknP8jQ HnyC01Fr14aJt+PpbAzABF3zbkPo+qT5sLMHyPV3F8mWH/2z7fi1/hP+DhDe4CFi1UmA 7dYzv2M0wu8r6QyT2LJmimNA9xfdB+LCDtYSxwhqwGi0Y1p9j39TPP+2SJC4VUezRGwA JLoW9Dp1vkZwbtHoAmrgueoR6tH1wnSas26P1G8wU4xOLrWmSrZ+WkCyiA4a+QoEuLl1 mOcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=SA+FViddg+h+OkESfY3howskZmPg7seGAUxWJSgOrIc=; fh=4M6F3iRcKldIn7dJv2oqbmslsR014tGnDzDEFBMDQZo=; b=oTkRCg6Uw4dhnwG+IRjIRHHuB+s5wKAMg/XyX4B8RhroFbsAHCOecS8Q08da9UEZ1c 4lobEAQt4hwFUh9+zatuOAi+xFc2V7A5xGGn03XtZW2BObLRB25avwQ/61JCgMPEHIfO aUbqoF8SaDQxlE3zYAo8eoBe1nUQ+zqVIWPZAp6Nv74sOpTlBHLBHSj57FZMBQibUKXN w6NYVnSJcLjTt4HoMTejq/2/It9tVSEPvJjOb4G8Vd4ryhpK3jU+lUA5zNB9RPOcg6la 0KLNVp4wb8qe8dyqkneBkl8BG8zZ/I/cYHNc39Ik1jp9Sl8XtCxJZDjtrTb4vgh/YD8V QD8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id s9-20020a637709000000b005aaab9e7bcfsi6211284pgc.388.2023.10.23.00.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 00:12:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E752B805B9C3; Mon, 23 Oct 2023 00:12:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233386AbjJWHMY (ORCPT + 99 others); Mon, 23 Oct 2023 03:12:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbjJWHMW (ORCPT ); Mon, 23 Oct 2023 03:12:22 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7FE50D5B for ; Mon, 23 Oct 2023 00:12:20 -0700 (PDT) Received: from dggpemm500009.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4SDRBt3rNcz15NT2; Mon, 23 Oct 2023 15:09:26 +0800 (CST) Received: from [10.174.178.209] (10.174.178.209) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 23 Oct 2023 15:12:15 +0800 Message-ID: <739480f1-4899-6da7-c9ac-9d4fd26c2474@huawei.com> Date: Mon, 23 Oct 2023 15:12:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v2] ubi: gluebi: Fix NULL pointer dereference caused by ftl notifier To: Richard Weinberger CC: chengzhihao1 , Miquel Raynal , Vignesh Raghavendra , dpervushin , Artem Bityutskiy , linux-mtd , linux-kernel , yi zhang , yangerkun References: <20231018121618.778385-1-wangzhaolong1@huawei.com> <1381458025.20897.1697747248632.JavaMail.zimbra@nod.at> <891e554b-c133-6378-3a65-836fc9147e54@huawei.com> <441107100.23734.1697904580252.JavaMail.zimbra@nod.at> <9b543be7-a858-c982-3fcf-408701ae4ac9@huawei.com> <1141312317.29142.1698043564332.JavaMail.zimbra@nod.at> From: ZhaoLong Wang In-Reply-To: <1141312317.29142.1698043564332.JavaMail.zimbra@nod.at> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.209] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 23 Oct 2023 00:12:49 -0700 (PDT) > ----- Ursprüngliche Mail ----- >> Von: "ZhaoLong Wang" >> An: "richard" , "chengzhihao1" >> CC: "Miquel Raynal" , "Vignesh Raghavendra" , "dpervushin" >> , "Artem Bityutskiy" , "linux-mtd" >> , "linux-kernel" , "yi zhang" , >> "yangerkun" >> Gesendet: Montag, 23. Oktober 2023 08:41:12 >> Betreff: Re: [PATCH v2] ubi: gluebi: Fix NULL pointer dereference caused by ftl notifier > >>> >>> IOW, no mtdblock (hence, also no FTLs) on top of gluebi. >>> >>> What do you guys think? >>> >>> Thanks, >>> //richard >>> >> >> >> JFFS2 needs to work on the block device, so the mtdblock needs to work >> on the top of gluebi. >> >> This is directly reflected in the jffs2 mount command, such as >> >> # mount -t jffs2 /dev/mtdblockX /mnt/jffs2 > > The limitation is long gone. It comes from the dark and old times > where Linux was only able to mount block devices. > > You can do: mount -t jffs2 mtdX /mnt/jffs2 > > Thanks, > //richard > Yes, I tried it and it worked. Thanks for the reminder. But this modification rejects this usage. and rejects other block device file systems (such as ext4) from working on gluebi. Thank you. Zhaolong