Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1059797rda; Mon, 23 Oct 2023 00:36:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlveBLU5ngsUiqQW6RDbErUnWJbDKett8dnJyXWkwsB3B4hopIbgahq67j5cjyDOob+qo3 X-Received: by 2002:a17:903:1252:b0:1c9:e774:58d9 with SMTP id u18-20020a170903125200b001c9e77458d9mr10176372plh.34.1698046619145; Mon, 23 Oct 2023 00:36:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698046619; cv=none; d=google.com; s=arc-20160816; b=bzcuIOnTUK2mRSoC+JhD71XejXECk608CeLCJQ2sapYTKLJLCx8/KFMc5YJWFYxzjD 3wW6U/3xRLK7XJeYRSM3+27MI4R1/pNt4TG07wQnCgYx6QJBm7DMYgN9b6cecTl3cUjK XYSUeNRZvxd8O+6ljwiuA/FXsvf99ZvWYW54Otx4kuksXDJVTsPB8ebqYeMBRCShjM4K vHD/qIO9MJU6xFa/PnPiWh3jxlC7RgWoLXg9GysJtdr004jAgI8Bgu+wuEhcToUjlFKL KeBmXnTUP7LmPxOLeeOt44fLWgNOhmviYOmXXWkpLifDyBE08TLKEATNyG1ltkaz/0p6 /JhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=iRxjh/z6OFSIIJrLM6+7wM6DBM74S+/hiLpL5gbzgaQ=; fh=hS8FnZAZ9OINvZSmU8bstjCHl/CMPLx205fs0npgqfQ=; b=z91Bpuld7AnfZkFGEk60epYwXbZP0h3bN8ulMmjmI4WcGlMm25Xaz0Fqx+xksCeVsP Ytpam3SV9XRg58P7BeDYnf8w+FZL6DLyW8UPp6ASkHVYd+ksF2lSElWXfH8fIcsty28z /6kcl0vsbNcO66j+KSsUTuVMpKSMwKOgt5DHgJSQtGAkVWtdnq7eO2OsrFWgwBuMSKVd M3uETvfhiGo/aBqnIS7U0P8b3EtyZE02Q0zs8kFW2aBG/1ocRgcFz4ftU4tKai5QZBX8 y/KsU1vICcgVIdpuT0hprINmsoMcKcvFYMCC+17B+ISpA+vI/JxXONQbvQDorvghtRU+ IyQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id bd1-20020a170902830100b001b86ddfd49bsi5768850plb.6.2023.10.23.00.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 00:36:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id BD7C28065E3E; Mon, 23 Oct 2023 00:36:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbjJWHgu (ORCPT + 99 others); Mon, 23 Oct 2023 03:36:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233529AbjJWHgr (ORCPT ); Mon, 23 Oct 2023 03:36:47 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26ED7D66 for ; Mon, 23 Oct 2023 00:36:44 -0700 (PDT) Received: from kwepemm000013.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SDRhl5q81zcdJs; Mon, 23 Oct 2023 15:31:51 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm000013.china.huawei.com (7.193.23.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 23 Oct 2023 15:36:41 +0800 Subject: Re: [PATCH v2] ubi: gluebi: Fix NULL pointer dereference caused by ftl notifier To: Richard Weinberger CC: ZhaoLong Wang , Miquel Raynal , Vignesh Raghavendra , dpervushin , Artem Bityutskiy , linux-mtd , linux-kernel , yi zhang , yangerkun References: <20231018121618.778385-1-wangzhaolong1@huawei.com> <1381458025.20897.1697747248632.JavaMail.zimbra@nod.at> <891e554b-c133-6378-3a65-836fc9147e54@huawei.com> <441107100.23734.1697904580252.JavaMail.zimbra@nod.at> <93b2d5ab-e36c-be08-7343-ef4ca16f991d@huawei.com> <879960555.29268.1698045341596.JavaMail.zimbra@nod.at> From: Zhihao Cheng Message-ID: <12400272-4449-040c-1ccd-6494a67f4da0@huawei.com> Date: Mon, 23 Oct 2023 15:36:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <879960555.29268.1698045341596.JavaMail.zimbra@nod.at> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm000013.china.huawei.com (7.193.23.81) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 00:36:56 -0700 (PDT) 在 2023/10/23 15:15, Richard Weinberger 写道: > ----- Ursprüngliche Mail ----- >> Von: "chengzhihao1" >>>> If we add new ioctls to control creation/destroying of gluebi, then >>>> gluebi mtd won't be automatically created when UBI volume is added. I'm >>>> not certain whether this change will effect existing startup process >>>> that depends on gluebi. >>> Let's take a stack back. The sole purpose of gluebi is providing >>> a way to run JFFS2 on top of UBI. >> Is it possible that someone runs ext4 on mtdblock based on gluebi, for >> the advantage of wear-leveling? > Unless they want to kill their NAND immediately, no. > UBIblock hat initially an RW-Mode but it was rejected because > UBI is not an FTL and will all dangerous setups. > > What I'm trying to say is, I'd like to avoid adding complicated solutions > or workarounds just to make artificial stacking of outdated MTD components > possible. > Let's keep the big picture in mind. Makes sense. Zhaolong and I didn't make clear the boundary between FTL and ubiblock/gluebi. Now, I believe that UBI needn't be responsible much for the extension mechanism(eg. mtdblock based on gluebi). So, let's pick your solution. > Thanks, > //richard > > .