Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <d5fba90c-24ab-4aff-8d6f-6d1443f4c10a@linux.intel.com>
Date:   Mon, 23 Oct 2023 09:50:41 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 12/13] ASoC: amd: acp: Add pci legacy driver support for
 acp7.0 platform
Content-Language: en-US
To:     Syed Saba Kareem <Syed.SabaKareem@amd.com>, broonie@kernel.org,
        alsa-devel@alsa-project.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, mario.limonciello@amd.com,
        venkataprasad.potturu@amd.com, arungopal.kondaveeti@amd.com,
        mastan.katragadda@amd.com, juan.martinez@amd.com,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
        V Sujith Kumar Reddy <vsujithkumar.reddy@amd.com>,
        Marian Postevca <posteuca@mutex.one>,
        Jarkko Nikula <jarkko.nikula@bitmer.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
        Yang Li <yang.lee@linux.alibaba.com>,
        Dan Carpenter <dan.carpenter@linaro.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20231021145110.478744-1-Syed.SabaKareem@amd.com>
 <20231021145110.478744-12-Syed.SabaKareem@amd.com>
From:   =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?= 
        <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <20231021145110.478744-12-Syed.SabaKareem@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/21/2023 4:50 PM, Syed Saba Kareem wrote:
> Add pci legacy driver support and create platform driver for
> acp7.0 platform.
> 
> Signed-off-by: Syed Saba Kareem <Syed.SabaKareem@amd.com>
> ---

...

> +
> +static struct snd_soc_dai_driver acp70_dai[] = {
> +{
> +	.name = "acp-i2s-sp",
> +	.id = I2S_SP_INSTANCE,
> +	.playback = {
> +		.stream_name = "I2S SP Playback",
> +		.rates = SNDRV_PCM_RATE_8000_96000,
> +		.formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
> +			   SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S32_LE,

Any reason to not go from lowest bit width to higher? Similarly in 
further definitions.

> +		.channels_min = 2,
> +		.channels_max = 8,
> +		.rate_min = 8000,
> +		.rate_max = 96000,
> +	},

...

> +
> +static int __maybe_unused acp70_pcm_resume(struct device *dev)
> +{
> +	struct acp_dev_data *adata = dev_get_drvdata(dev);
> +	struct acp_stream *stream;
> +	struct snd_pcm_substream *substream;
> +	snd_pcm_uframes_t buf_in_frames;
> +	u64 buf_size;
> +
> +	spin_lock(&adata->acp_lock);
> +	list_for_each_entry(stream, &adata->stream_list, list) {
> +		if (stream) {
> +			substream = stream->substream;
> +			if (substream && substream->runtime) {
> +				buf_in_frames = (substream->runtime->buffer_size);
> +				buf_size = frames_to_bytes(substream->runtime, buf_in_frames);
> +				config_pte_for_stream(adata, stream);
> +				config_acp_dma(adata, stream, buf_size);
> +				if (stream->dai_id)
> +					restore_acp_i2s_params(substream, adata, stream);
> +				else
> +					restore_acp_pdm_params(substream, adata);
> +			}
> +		}
> +	}
> +		spin_unlock(&adata->acp_lock);
> +		return 0;

Indentation is wrong in above two lines.

> +}
> +
> +static const struct dev_pm_ops acp70_dma_pm_ops = {
> +	SET_SYSTEM_SLEEP_PM_OPS(NULL, acp70_pcm_resume)
> +};
> +