Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759946AbXKTG4K (ORCPT ); Tue, 20 Nov 2007 01:56:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759596AbXKTGyf (ORCPT ); Tue, 20 Nov 2007 01:54:35 -0500 Received: from koto.vergenet.net ([210.128.90.7]:44518 "EHLO koto.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759503AbXKTGye (ORCPT ); Tue, 20 Nov 2007 01:54:34 -0500 Date: Tue, 20 Nov 2007 15:54:33 +0900 From: Simon Horman To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jes Sorensen , Tony Luck , linux-altix@sgi.com, linux-ia64@vger.kernel.org Subject: Re: [PATCH 01/59] arch/ia64: Add missing "space" Message-ID: <20071120065431.GC10490@verge.net.au> References: <1195523331-15303-1-git-send-email-joe@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: mutt-ng/devel-r804 (Debian) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 44 [snip] > diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c > index 5fd65d8..90518e4 100644 > --- a/arch/ia64/kernel/kprobes.c > +++ b/arch/ia64/kernel/kprobes.c > @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > qp = kprobe_inst & 0x3f; > if (is_cmp_ctype_unc_inst(template, slot, major_opcode, kprobe_inst)) { > if (slot == 1 && qp) { > - printk(KERN_WARNING "Kprobes on cmp unc" > - "instruction on slot 1 at <0x%lx>" > + printk(KERN_WARNING "Kprobes on cmp unc " > + "instruction on slot 1 at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > > @@ -221,8 +221,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > * bit 12 to be equal to 1 > */ > if (slot == 1 && qp) { > - printk(KERN_WARNING "Kprobes on test bit" > - "instruction on slot at <0x%lx>" > + printk(KERN_WARNING "Kprobes on test bit " > + "instruction on slot at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > } Is it really neccessary for this fragment to create a line that is greater than 80 characters long? Persumably the entire reason that the printk line was split in the first place was to avoid a long line. [snip] -- Horms - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/