Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Edward AD <twuufnxlz@gmail.com>,
        "syzbot+9704e6f099d952508943@syzkaller.appspotmail.com" 
        <syzbot+9704e6f099d952508943@syzkaller.appspotmail.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "reibax@gmail.com" <reibax@gmail.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>
Subject: RE: [PATCH] ptp: ptp_read should not release queue
Thread-Topic: [PATCH] ptp: ptp_read should not release queue
Thread-Index: AQHaBVsrlvNhSH7D/EuTcW5/4OFPb7BXEvjg
Date:   Mon, 23 Oct 2023 09:01:40 +0000
Message-ID: <MW4PR11MB57763BDD2770028003988D8AFDD8A@MW4PR11MB5776.namprd11.prod.outlook.com>
References: <0000000000002e8d4a06085267f3@google.com>
 <20231023024622.323905-2-twuufnxlz@gmail.com>
In-Reply-To: <20231023024622.323905-2-twuufnxlz@gmail.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jeDB+BWKDd1zU9GG6xMt0xE9ItBCcssBX1fikHoKxADY7wFdloxz3hxe3Tui?=
 =?us-ascii?Q?XwFAjScn0nxomYhIkHUSXodFPZhcIXS9cWiIeogarcqBxGbEKuCaf8LVRF0s?=
 =?us-ascii?Q?+NX4//azOoNJZt9AWs76xXT1odK43RiRxpPHa3ZtE/u612o7pzBB8quQGtDG?=
 =?us-ascii?Q?wFjGZnrXJaLe5faWYOgDskGQjtF6nSEdbBCwU4iAFq6gGo2tw/aK/Lsh9psu?=
 =?us-ascii?Q?I7G14lAv1h1KN+zxL2sI0dHgSxrkH/gzDtD+X+xoHnJrlMILAMIOnOO1ors3?=
 =?us-ascii?Q?c68Hk8Ze6kmy+rRFJxoC8M5jrlCzGdRUNesCEl9rOW0Mi/3KpYDDTzo5YBwu?=
 =?us-ascii?Q?uh2zoBBWoAIZY4fqn2OyIwcoa9su+mpiXXykaqNL3nwKuBeW7CQ71NJoTeUh?=
 =?us-ascii?Q?tycaDdrP/JoufjVYyM0bXP5QzWleHfP7oIC/PER1jR4Vi/24q2/FrT21F/VM?=
 =?us-ascii?Q?hAELl7z/bJeONABkrm2Xw1HZc8bBBVdW3NFpRhOHUmkek03paoO7htgSHZa3?=
 =?us-ascii?Q?gZflPDZrKwRLhtniQ6VJ8vcP5pmRu3TxOwBPAPA8ZaQ3fbe/Z3fJMFVeDzBK?=
 =?us-ascii?Q?GQBsBaWD5QWns2ooMEGIVbhv9Uc5nfs+azehLLcDcdNY4P787Xa+Z+MVQthw?=
 =?us-ascii?Q?BuTlMuuuh6XyYc4kphh5ts39sCdCvlu0F27JR/mx2vohQ0IBGeiWAtNinKTv?=
 =?us-ascii?Q?+NMkxzAaMsVKcGBecCm9Nw1wh7kbxaerU6x1lM+5tilLgNrXPQ16w7KEAMfT?=
 =?us-ascii?Q?agE7oBRUzoni4HkMbonPKa6qalUhJBn5CYmbL2lTuGavfKPFDbtaXyC0DZE4?=
 =?us-ascii?Q?T7TzOR4lUFo2itiTlB0/9ufZ3XZR4088q0JhThItvOPgPsKgdVlOOynZi8dd?=
 =?us-ascii?Q?IJnVyrECHMr/vouI3tpuWBvlLQHD4vcJe30qJf7Rs1qCHCVchsqX9Qxf7qEx?=
 =?us-ascii?Q?vNO3x3/09Fkmapsh5G/9eL0AVf1TEOw9lKo/J6O5SVinHotUFY8QOTaagypg?=
 =?us-ascii?Q?Q6OOyzv2U/hN4qg9+t/hTjZx+DL1yx4d1Atx7Ie1hl5GycDrmN2yh1ovvSy3?=
 =?us-ascii?Q?vnxpo1IHyBT/rKtzp5+5Bethopf1GL57zBkCwdx4pJmigr2EhkZiHw9g7fVx?=
 =?us-ascii?Q?2N3a2+3GAaJbOGk1k0HU5l2xUNYWHW8XrcneWlRXgWOhEfdEGkJv9s0WI0Pl?=
 =?us-ascii?Q?34n31rJP4Nudrqjrr9M6F6gi95lp6Adn5QpSp52YDO26y2SPWnCOmEvRDnWU?=
 =?us-ascii?Q?zjYeF96acjbM4++DXF4TqmSnxAzezwURUlw7qfKrar3N78OCuAL0Qpxh9Z1D?=
 =?us-ascii?Q?nDGVkrRX9JuCxHehrGgRDoEVlQJ67dRTPqBJYMkDZIIFg8lUwEnxhmE1b557?=
 =?us-ascii?Q?n0c2EwUbEXIY1Dna1eHm67qDJlmY2J+7HKH2U2eyhdgFU6nQHxKPS0yRszcI?=
 =?us-ascii?Q?Ych3G4b+2JD/67MlA1dXeUgbZG/lDwxmvXXtHcxDReTA3eaIk6JpUBUet59+?=
 =?us-ascii?Q?xF2OrzUSXD9bFRWJvS3Si8ZEIQQfoSRsYDwVl3tsin2cgYRif1kfxDB/ZnMA?=
 =?us-ascii?Q?E2n+ecGNAq4+4HMDYkPuFTF3A9dJD+sQ3fReDYIG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c3e210c-1bef-4020-eb33-08dbd3a6ac19
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 09:01:40.7992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x2g3GgxNyrCwnSi1egUx5Xwtu1V41lGedqq1WiIl1JYwzH65rWeE0Ux+CLf1hJeuA0cVJg/u9dWk206EJ2LMUzZHwJJKZMM+2YJDps8W/uA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7279
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 02:02:14 -0700 (PDT)


> -----Original Message-----
> From: Edward AD <twuufnxlz@gmail.com>
> Sent: Monday, October 23, 2023 4:46 AM
> To: syzbot+9704e6f099d952508943@syzkaller.appspotmail.com
> Cc: davem@davemloft.net; linux-kernel@vger.kernel.org; netdev@vger.kernel=
.org; reibax@gmail.com; richardcochran@gmail.com;
> syzkaller-bugs@googlegroups.com
> Subject: [PATCH] ptp: ptp_read should not release queue
>=20
> Firstly, queue is not the memory allocated in ptp_read;
> Secondly, other processes may block at ptp_read and wait for conditions t=
o be
> met to perform read operations.
>=20
> Reported-and-tested-by: syzbot+9704e6f099d952508943@syzkaller.appspotmail=
.com
> Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers")
> Signed-off-by: Edward AD <twuufnxlz@gmail.com>

Hi Edward,

Consider adding a target to the subject: [PATCH net] in this case

> ---
>  drivers/ptp/ptp_chardev.c | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
> index 282cd7d24077..27c1ef493617 100644
> --- a/drivers/ptp/ptp_chardev.c
> +++ b/drivers/ptp/ptp_chardev.c
> @@ -585,7 +585,5 @@ ssize_t ptp_read(struct posix_clock_context *pccontex=
t, uint rdflags,
>  free_event:
>  	kfree(event);
>  exit:
> -	if (result < 0)
> -		ptp_release(pccontext);
>  	return result;
>  }
> --
> 2.25.1
>=20