Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1093398rda; Mon, 23 Oct 2023 02:10:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhzbk8DIqti0v6CVoP8LfDTNNL84rsyn/l/shm7+h8IZ//wz0fHyrC/xXYZ2J9At4dW4Gf X-Received: by 2002:a17:902:f0d5:b0:1ca:18a3:a49b with SMTP id v21-20020a170902f0d500b001ca18a3a49bmr7479955pla.37.1698052230757; Mon, 23 Oct 2023 02:10:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698052230; cv=none; d=google.com; s=arc-20160816; b=ifIgDBZhZhIz6jmyX8zwmP0a/MPoiivTqIxlUlGb+KtWHxEsMM/1Mj4ujWG0KNoiFz vsH1kPdqNl5Hu8UwPOX57/hcv50QXmyJTnLekOEkwMiSY1d99Kv9q60hiPhklmkHIiIz eY/ULKqa4tMixpC8agxBUiKsgV5KgggHiGdMa/B3bQKsmCon0Ht0hlENb34a7ELCfYoR //RLHDVsDoAAP3HJAWuqSs7PVw7E3sQtvpGwJ0L/9TlmJo5dViHghi37onkRi67IqEk9 keFXdJxAsAJPtzUv8Gjl5pVF/oR4NIApmKPoYgvpoHTrdfhepxIX4xeNCPygVfY+1xmn MjOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=I9prQxPgmyE3xzWAyIMSdW1KLEhS2tX5PuKRMEYdlRA=; fh=xdCIhRk8w4HbXrnImHi2ms6aNH5JwSfRQzlOVFowVys=; b=kccQH3VjeDao3ksHuRgjfhZaK8T3977VwIZAQQOrZB1R5WSvnFYtAh5332/CrYMn3h QGsMQO9re2Kq6GKZJNB/Vz9n3ZFukJ96QvTlzMb1I+uXJz4lfmk0NqwVl7Zz40KDqnAW WE48yTfdRYh+OBjbuZ8YGi/RAXuLUoOvUPmJ0q1qPsy/rBZrOvjjqjIq8A2K20fXuTVn DIqudC6nSFfKtpfx1Jpskwum7Bo843G3dnb9HlIDQ+MRnxswdmJ3FU/XNcsM+0AOIpgW M1CRnIAyL4Vwt3hbhCWfBLtmjz6yv41FkN8TD9nWzCodL+d/uOJle8Z2c4ND2BwmEJHi pZpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=e2YcLTUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i8-20020a170902c94800b001bc74f6a951si6552099pla.250.2023.10.23.02.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 02:10:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=e2YcLTUO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 78D84806A952; Mon, 23 Oct 2023 02:10:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232823AbjJWJKU (ORCPT + 99 others); Mon, 23 Oct 2023 05:10:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232763AbjJWJKN (ORCPT ); Mon, 23 Oct 2023 05:10:13 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:242:246e::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C213910CF; Mon, 23 Oct 2023 02:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=I9prQxPgmyE3xzWAyIMSdW1KLEhS2tX5PuKRMEYdlRA=; t=1698052209; x=1699261809; b=e2YcLTUOka0p0YqRhSUXztdiwOYkcBVZ7InN4eXMV6N9Cc/ qJo+pPv9eDnMqAMcc74m3N/be9JORD66FAKb8sifBhQitFTh4hDzRDhoskrjfsrYSk/t2MLlREsPw wkWlsEBKASHN2mqh+YcuycN/hkznBbJOvX4B/5IlRQyl1zIFaP/j4A/xzfO0oah3isvpmop8wNeO5 a4IpnxUI99TjY3E1FybYjG5gTiYoXGRlJflMWI/2QBxEVt5uyMIubwZSaSvmnNg7I8j/VI1c4nmNt y+tWaqfqZ2osZS3MHSUYHhh7SaUrD2x/LNs1UY64ChCtR9IJZJCpF5ptmMIoGttw==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97-RC1) (envelope-from ) id 1quqwn-00000000BFA-3xSN; Mon, 23 Oct 2023 11:10:06 +0200 Message-ID: <433af526223619beabad96a9003cad05c5b6189b.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: iwlwifi: Add check for kmemdup From: Johannes Berg To: Kalle Valo , Chen Ni Cc: gregory.greenman@intel.com, mukesh.sisodiya@intel.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 23 Oct 2023 11:10:04 +0200 In-Reply-To: <87zg09zowv.fsf@kernel.org> References: <20231023064501.274599-1-nichen@iscas.ac.cn> <87zg09zowv.fsf@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 23 Oct 2023 02:10:28 -0700 (PDT) On Mon, 2023-10-23 at 12:08 +0300, Kalle Valo wrote: > Chen Ni writes: >=20 > > Since the kmemdup may return NULL pointer, > > it should be better to add check for the return value > > in order to avoid NULL pointer dereference. > >=20 > > Fixes: 5e31b3df86ec ("wifi: iwlwifi: dbg: print pc register data once > > fw dump occurred") >=20 > The fixes tag should be in one line. >=20 It's also irrelevant because (a) the fix is incorrect, and (b) we already have a (correct) fix :) johannes