Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Subject: Re: [PATCH v4 8/8] LoongArch: Add ORC stack unwinder support
To:     Xi Ruoyao <xry111@xry111.site>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Huacai Chen <chenhuacai@kernel.org>
References: <1698048691-19521-1-git-send-email-yangtiezhu@loongson.cn>
 <1698048691-19521-9-git-send-email-yangtiezhu@loongson.cn>
 <4d3363eb5f4d864cfd171d89b1a13da5ef8b784c.camel@xry111.site>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
        loongson-kernel@lists.loongnix.cn
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <1a06a70d-5dae-93a7-c200-c5b58f1241d5@loongson.cn>
Date:   Mon, 23 Oct 2023 17:21:38 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <4d3363eb5f4d864cfd171d89b1a13da5ef8b784c.camel@xry111.site>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/23/2023 04:43 PM, Xi Ruoyao wrote:
> On Mon, 2023-10-23 at 16:11 +0800, Tiezhu Yang wrote:
>> +ifdef CONFIG_OBJTOOL
>> +KBUILD_CFLAGS			+= -fno-optimize-sibling-calls -fno-jump-tables -falign-functions=4
>> +endif
>
> Why do we need to regress the code generation so much for objtool?

Add the above options is to avoid generating some intractable
instructions for objtool by now, I hope all of the extra options
can be removed if possible.

For example, without -fno-jump-tables, there exist many objtool
warnings like this:

"sibling call from callable instruction with modified stack frame"

If the enhanced special function about jump table is implemented
in objtool, -fno-jump-tables will be removed in the future.

Thanks,
Tiezhu