Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1100843rda; Mon, 23 Oct 2023 02:30:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQ9AQ0G2JqMl+UxU0fiXFGpp4XPKCS8gYj8i+udpqu7JvxVmXOvyuj5xQWoO90+jJ1+EM2 X-Received: by 2002:a05:6a20:8f27:b0:14d:6309:fc96 with SMTP id b39-20020a056a208f2700b0014d6309fc96mr7837563pzk.4.1698053421306; Mon, 23 Oct 2023 02:30:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698053421; cv=none; d=google.com; s=arc-20160816; b=lvaxuxrPqOjPojlkPUzfEHCU1zu63qY/C96OnoGN0+zEcM38Af76TDAFWD0+Lys79h 9egMMZ8R2/Vjc/G7mec1nc58dB5XPmWou6wKL+qYR3KUl0TIZ3PtcPAyyDGmkNG5ojc5 krw4/EmVuf/3z7F1O/7/rDvQ+D9BjFLKgtafUT+giEnCtNNr7owdypYk3nM9jcS0FkB/ zUoWa5sYFLqd8PtSA5nLnSizdYbBj+sufm/KV9+L8xRSV2F7KtiO238nWMJI+qwND+eh 649A0kf2YVC9iv8cKjlKEXhqp2jSkmpsn0J5F+AtzYsq57oTP/PI55CU7v/b+jhbFgFr 9vPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=tzbc4eG/qaPCBJHuI4nQtGU/B0+uO8x8gO5710LAtH8=; fh=QE9upPbR7qUXG67+f0oQ/N7I5OXHuf91xdZSksXNC+4=; b=wRz46FED9V+Un8sxi2i725WNfIH08AEGDVNGj/t7+qqET96svTyF7v7reQTJeSVX+R y1V7TON9YbOGPtEmRDJWwVzh2FsIHLQcEU2UPDM99l+dmnuue209sS247hWZe0PsYd9A gSutZcclLPCz4QQilhsVSoNiVNztswP/AhFy9duRsCVDNeigBonG+qlcdgy4xK4D0qOK Mx8YgJzM734hmNi+PCqZmiM62kADLkaMSt5cIgs90WN1tfeXTJcrImKR7GxZm/ZTP5rD wDj7N+EeAmUg4VtlRAjeS56lLv21CaKy1/hhbZf0MSTkzeEodyUoYxI6cVBObbLHhPaO urAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nBiXPsSM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id ga15-20020a17090b038f00b0027d0c32326asi6135696pjb.151.2023.10.23.02.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 02:30:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nBiXPsSM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EDA158068228; Mon, 23 Oct 2023 02:30:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbjJWJaB (ORCPT + 99 others); Mon, 23 Oct 2023 05:30:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233252AbjJWJ3y (ORCPT ); Mon, 23 Oct 2023 05:29:54 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A181DF for ; Mon, 23 Oct 2023 02:29:51 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-9be02fcf268so445925466b.3 for ; Mon, 23 Oct 2023 02:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698053390; x=1698658190; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tzbc4eG/qaPCBJHuI4nQtGU/B0+uO8x8gO5710LAtH8=; b=nBiXPsSMCaZ2voSGuAEWWxKq3kBAORTSVz/0Gs6Jp8vwLpaxCuE8quSiAQdpJp/r1N kAxblmoSMU+AhXri+lvSPZSfQ58/uMZnFL6vBnCG9arW8BRDAMtsjTITBFxzu3Mtg8hw O5H9t/YkJOr7vbD+MyBOQg8UUjCzmgyxtlLhmDFIXjjAAZ6Fm19UVIlafwENUqSjD5YA AozHGEelvf02LRBi0kGrPM7ixRR7G+Oj6n6QvejvDwhRtGQOeGbm2+qcwAosXTCJZXtW jkJ+nAx8+usGKCExN0UCK6nkYk+Z42YfiB3bDO7RktXl2ZzWGpEdLSVFZMBBfMguAJel Nirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698053390; x=1698658190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tzbc4eG/qaPCBJHuI4nQtGU/B0+uO8x8gO5710LAtH8=; b=d3/xY5AgOec1tY6LhCWYzmFKlscGBfzHHaWFFwxfirQyQNXyZq7DSC5ht9DG0ha4// xpOQSRu+wsZvC4gVVPXscZKo7X56XuxI+bK1ZWk/0PcAwBiNt4hb/6g3+yuLuXgeUGVA UrDWWnxmXnb9/tVbiyWQtmESNJ4osT+CnXyGI0lllqTX/Zeq6sHmzWIc5BwXqBLCNi+m CYIVNEYKh4d1pcurn/r+j1+SBTTNCRccQ3ZAhaynhFj1BSAzWLRe6rixFCGdHscuwzOE SZeLVVK73dNVKp1YyQeoXxJvkdbSVh6TkAz31ku5OWeMOKWVMjctX6kQEWaylQzDr8Tz G78A== X-Gm-Message-State: AOJu0YwtyProdik9TEF8rcF3Lc/1g1qMdbPuUPdwFM1X2yJLgBC8D1zO 6OwZb8QDPLnTrqXdAb1CmPU= X-Received: by 2002:a17:906:fe4a:b0:9c3:b3cb:29b2 with SMTP id wz10-20020a170906fe4a00b009c3b3cb29b2mr7225450ejb.42.1698053389767; Mon, 23 Oct 2023 02:29:49 -0700 (PDT) Received: from gmail.com (1F2EF1E7.nat.pool.telekom.hu. [31.46.241.231]) by smtp.gmail.com with ESMTPSA id a7-20020a1709062b0700b009932337747esm6206196ejg.86.2023.10.23.02.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 02:29:48 -0700 (PDT) Sender: Ingo Molnar Date: Mon, 23 Oct 2023 11:29:46 +0200 From: Ingo Molnar To: Uros Bizjak Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andy Lutomirski , Brian Gerst , Denys Vlasenko , "H . Peter Anvin" , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , Josh Poimboeuf , Nadav Amit Subject: Re: [PATCH -tip v2] x86/percpu: Introduce const-qualified const_pcpu_hot Message-ID: References: <20231021143739.843941-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231021143739.843941-1-ubizjak@gmail.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 23 Oct 2023 02:30:08 -0700 (PDT) * Uros Bizjak wrote: > DECLARE_PER_CPU_ALIGNED(struct pcpu_hot, pcpu_hot); > > +/* const-qualified alias to pcpu_hot, aliased by linker. */ > +DECLARE_PER_CPU_ALIGNED(const struct pcpu_hot __percpu_seg_override, > + const_pcpu_hot); I added the fix below - just like pcpu_hot, const_pcpu_hot needs to be exported too, as it's (indirectly) used by various kernel modules. Thanks, Ingo --- arch/x86/kernel/cpu/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 382d4e6b848d..4cc0ab0dfbb5 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2051,6 +2051,7 @@ DEFINE_PER_CPU_ALIGNED(struct pcpu_hot, pcpu_hot) = { .top_of_stack = TOP_OF_INIT_STACK, }; EXPORT_PER_CPU_SYMBOL(pcpu_hot); +EXPORT_PER_CPU_SYMBOL(const_pcpu_hot); #ifdef CONFIG_X86_64 DEFINE_PER_CPU_FIRST(struct fixed_percpu_data,