Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <5c49bc0f468e9fb5ae7ff7f53443fdb1fc3c77f2.camel@linuxfoundation.org>
Subject: Re: [PATCH] serial: core: Fix runtime PM handling for pending tx
From:   Richard Purdie <richard.purdie@linuxfoundation.org>
To:     Tony Lindgren <tony@atomide.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Andy Shevchenko <andriy.shevchenko@intel.com>,
        Dhruva Gole <d-gole@ti.com>,
        Ilpo =?ISO-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        John Ogness <john.ogness@linutronix.de>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        Bruce Ashfield <bruce.ashfield@gmail.com>,
        Mikko Rapeli <mikko.rapeli@linaro.org>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Randy MacLeod <randy.macleod@windriver.com>
Date:   Mon, 23 Oct 2023 10:40:54 +0100
In-Reply-To: <20231023074856.61896-1-tony@atomide.com>
References: <20231023074856.61896-1-tony@atomide.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-10-23 at 10:48 +0300, Tony Lindgren wrote:
> Richard reported that a serial port may end up sometimes with tx data
> pending in the buffer for long periods of time.
>=20
> Turns out we bail out early on any errors from pm_runtime_get(),
> including -EINPROGRESS. To fix the issue, we need to ignore -EINPROGRESS
> as we only care about the runtime PM usage count at this point. We check
> for an active runtime PM state later on for tx.
>=20
> Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to =
enable runtime PM")
> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Tested-by: Richard Purdie <richard.purdie@linuxfoundation.org>

Thanks, I can confirm that since we added this into our builds/tests
we've not seen the serial data go missing.

Cheers,

Richard

> Cc: Bruce Ashfield <bruce.ashfield@gmail.com>
> Cc: Mikko Rapeli <mikko.rapeli@linaro.org>
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Cc: Randy MacLeod <randy.macleod@windriver.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  drivers/tty/serial/serial_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial=
_core.c
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -146,7 +146,7 @@ static void __uart_start(struct uart_state *state)
> =20
>  	/* Increment the runtime PM usage count for the active check below */
>  	err =3D pm_runtime_get(&port_dev->dev);
> -	if (err < 0) {
> +	if (err < 0 && err !=3D -EINPROGRESS) {
>  		pm_runtime_put_noidle(&port_dev->dev);
>  		return;
>  	}