Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231023043751.17114-1-jason-jh.lin@mediatek.com> <20231023043751.17114-7-jason-jh.lin@mediatek.com>
In-Reply-To: <20231023043751.17114-7-jason-jh.lin@mediatek.com>
From:   Fei Shao <fshao@chromium.org>
Date:   Mon, 23 Oct 2023 17:41:33 +0800
Message-ID: <CAC=S1njt-esHwUEr4O5BVUmmgpB=Gm084h+tY-KsKp9LkPXNBQ@mail.gmail.com>
Subject: Re: [PATCH v2 6/9] mailbox: mediatek: Add CMDQ driver support for mt8188
To:     "Jason-JH.Lin" <jason-jh.lin@mediatek.com>
Cc:     Jassi Brar <jassisinghbrar@gmail.com>,
        Chun-Kuang Hu <chunkuang.hu@kernel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        Jeffrey Kardatzke <jkardatzke@google.com>,
        Jason-ch Chen <jason-ch.chen@mediatek.com>,
        Johnson Wang <johnson.wang@mediatek.com>,
        Singo Chang <singo.chang@mediatek.com>,
        Nancy Lin <nancy.lin@mediatek.com>,
        Shawn Sung <shawn.sung@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jason,

On Mon, Oct 23, 2023 at 12:58=E2=80=AFPM Jason-JH.Lin <jason-jh.lin@mediate=
k.com> wrote:
>
> Add CMDQ driver support for mt8188 by adding its compatible and
> driver data in CMDQ driver.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmd=
q-mailbox.c
> index 56fe01cd9731..3bdfb9a60614 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -704,12 +704,20 @@ static const struct gce_plat gce_plat_v7 =3D {
>         .gce_num =3D 1
>  };
>
> +static const struct gce_plat gce_plat_v8 =3D {
> +       .thread_nr =3D 32,
> +       .shift =3D 3,
> +       .control_by_sw =3D true,
> +       .gce_num =3D 2
> +};
> +
>  static const struct of_device_id cmdq_of_ids[] =3D {
>         {.compatible =3D "mediatek,mt8173-gce", .data =3D (void *)&gce_pl=
at_v2},
>         {.compatible =3D "mediatek,mt8183-gce", .data =3D (void *)&gce_pl=
at_v3},
>         {.compatible =3D "mediatek,mt8186-gce", .data =3D (void *)&gce_pl=
at_v7},
>         {.compatible =3D "mediatek,mt6779-gce", .data =3D (void *)&gce_pl=
at_v4},
>         {.compatible =3D "mediatek,mt8192-gce", .data =3D (void *)&gce_pl=
at_v5},
> +       {.compatible =3D "mediatek,mt8188-gce", .data =3D (void *)&gce_pl=
at_v8},
I guess I understand your intention here... but the ordering doesn't
make sense to most people. Put this line after mt8186.

It's up to you to ignore the outlier mt6779 for now or send a separate
patch to fully sort the list by the compatible strings.

Regards,
Fei


>         {.compatible =3D "mediatek,mt8195-gce", .data =3D (void *)&gce_pl=
at_v6},
>         {}
>  };
> --
> 2.18.0
>
>