Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Javier Carrasco <javier.carrasco@wolfvision.net>
Date:   Mon, 23 Oct 2023 11:50:02 +0200
Subject: [PATCH] iio: tmag5273: fix temperature offset
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20231023-topic-tmag5273x1_temp_offset-v1-1-983dca43292c@wolfvision.net>
To:     Gerald Loacker <gerald.loacker@wolfvision.net>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>
Cc:     linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Javier Carrasco <javier.carrasco@wolfvision.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGJ0OGtsYkZOWGs0bC93aDd0WmRvNVJ2cm0rVlY4cDlmYWRLeFpzcEs0eU16?=
 =?utf-8?B?dUd3YVdlMElxTmsxeDcrQVJtTSsxOHZ5MzdIVDBpNWRLOGhOaUJlc1NhRVJP?=
 =?utf-8?B?Q1A4Z1lPd0pUQTJ0M3I0QWRHekZ3VG9jMDdyRDBTWU02N0w4NUllUThqMDcz?=
 =?utf-8?B?WlQvYjNYdXl1cHZGb25vSDFhZWhyaGhKcU0yV01IYk5tUUorQmlGeEFVWXpz?=
 =?utf-8?B?b0tPRm9pMjdIQmh1SlQyc2l0dDM0SytmSFJFMGVPalVOdEx1QThDOGFtV3Bp?=
 =?utf-8?B?M1FsdjBUY3BueC9CQnA5L2xuazFBaFg2R0tsbzRTWUw1OEZEZFhHTHNpd1JX?=
 =?utf-8?B?aDJGOWlONDdDS0xWeFF0MDE0MDBKRlRIRVVIdjNUS2R4N3NOUHZkVkRnaXYw?=
 =?utf-8?B?Qkd5NmtMT0VyQTU5bVFlMTRsYmU5ZjVvYlJvU284VjcwWHA3STliVC9RZVlL?=
 =?utf-8?B?OVRFVHY4Z205WHYydk9TOU8wRWZ0ZGJKYVpkT3krVHo5dTl3bEFzeVF1U3Uy?=
 =?utf-8?B?cDlmQkFrN29SQ0hqeG5uVEdEVjMrT1dlcWhRSUF0ZTI0aWJieE5vdGxRWVMz?=
 =?utf-8?B?NmZ3NURabWFOU1hWVVQ5TFh4QU4rdEIvL3J0aUNMU1FsOUNsRXRpZms3c3Ft?=
 =?utf-8?B?UnNvT2NmdDlJcGI2MVl1ZC8zUlU1VlowdmV2NTVLVjc2Q3ZaRitoVzdHeG42?=
 =?utf-8?B?TjN5elJGMVlyYXV0WlJDWHVBdm1HdTM2b2pYa1JvRnhKb0o5elR2QkVuTVdr?=
 =?utf-8?B?RDlEZ2VlN3Q3UGJqMWY0clpOODNUaXhXSWpEMXdHdlUvaE1YSFoxOTlUUmZv?=
 =?utf-8?B?bEJEWS95Q1FJM0tMZENybldBUlZWSStJTndON21zbTRYbmdZOXMxTCs5V1E1?=
 =?utf-8?B?WnZNcGpjOXpNUlJlV29pWkh3L250Y0liTk5mZ1BzaWx2RFJidEp3eHZvaDNU?=
 =?utf-8?B?SzlqVGxIWmZaVkJUdkxkWmZibTZjUFlMdW96VFI3dkd6bDdRL29VVTdiY0p6?=
 =?utf-8?B?OVZoN0V0ak1LSUhVeU1rQVcwS3greGliR25EVjBQcEVidG0zQ0R1clRQSC9C?=
 =?utf-8?B?SXBmcGgzVEJ6SjZ0OVVxalFVbXduRVdteTJHSE9PUHB1RGNEeGJJbmZ1WTlM?=
 =?utf-8?B?RFJwMUtIQ2V2ZGhvVUJxeWg5UHJiN0FnaDRzcFRxYWNsNDllZllPczU4NXF2?=
 =?utf-8?B?bkF4SndHV0VMSWJJL2FDTy8yZTNsWUVqY01jdEpjMmJvL2VJSmhIdnlyMHM3?=
 =?utf-8?B?UUtreXlXVUJIOU45MkFmWlNnb0xtZk9FSEY1aWk1VUtNd0xpWjJKWWdqTmlk?=
 =?utf-8?B?REdMNnBjM0NvdU9GTkEvdm1sb01YSVBWdTM1WWtPWSsxTUdjSlhvWEpFQmhO?=
 =?utf-8?B?NVFJMk1WY2Y3Y0diRFNRWGJudVVNSERNY0cySTFjZTVmUmFyb1F6elM5bXI5?=
 =?utf-8?B?QkgrU09DRFdQUVJsang2TXNFR3RVc2EySHNxeE5XWEJWWklycVVBYmdiMmFN?=
 =?utf-8?B?eHQyb3A2LzNtRWdkeXJqOVNrMUk1cjdBNmVjVjVJUzdDdzFyMkVEU1NYemd3?=
 =?utf-8?B?U0lGend3dy9DTmc0UHZ1R1p4aTdPZVNhays1bjZGYm1WRUtWNHFNeUFvcnVW?=
 =?utf-8?B?MnVTWDhVbHdhSkdmbjVlK1ZNbERJa0VmRWNqNnl1eXlZSXE4WGlqWU9BOFlT?=
 =?utf-8?B?Ykg5NlpUVUdaNmYxbWdCMm9HaXR3Ly9NTzQ5UllWUWpDR2t5VjlJaXl4NW9E?=
 =?utf-8?B?VTN3TW14bmFvQ0o1SGZrKy90VHE3UDZ5bGFXUlNFb1FjK0YzNUw1Z0hHVnVM?=
 =?utf-8?B?UzRwK1dMZ1pyVFlVZ2x3NkhKajl2ODNuV0xnTzFYaWFLSDVDNGlHSGlsMXU1?=
 =?utf-8?B?SlREZEd2OVZMclVCdHFDZkxoN3lURnppNXpLUWRSbHNnOWVhdUJua0pGZjNG?=
 =?utf-8?B?Nzkvc3gwZzZTRFpJNzNuS1orWVduRjJvSHJITTNadDJBNUpsMkN5RmdpMTJC?=
 =?utf-8?B?dSs2Q2J0V1JzQ2szekVpL2hCUmpNWFNWSDIwRlhZTm16eHNrbEJ3cjZHa25v?=
 =?utf-8?B?VFQ1amIxbWlqY2dvTlcxYlZDMzl3NGZpNzZBL3YzTE90NFlKb0RYVTFKbGhQ?=
 =?utf-8?B?T3JHVlhCNURtZ0RyendHUkZnR1FHdzlyblRaTEp0VjZBSlNDY2VyQ2NtRjM0?=
 =?utf-8?Q?yWinNjZsHYAStvxI7UK28ZQ=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: f261093b-4d8f-4615-a93d-08dbd3ad7418
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 09:50:13.4925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CyH8+krpdFX5W7PXWYLJeOE4RFOn3yHX7qweA63GmnpKBCaBj8vx6wfgL6As5Gh+li2ToxgL1rQruMiYHtm7/vrS5zc4XSdjXbnhByWJYKI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5590
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 02:50:30 -0700 (PDT)

The current offset has the scale already applied to it. The ABI
documentation defines the offset parameter as "offset to be added
to <type>[Y]_raw prior to scaling by <type>[Y]_scale in order to
obtain value in the <type> units as specified in <type>[Y]_raw
documentation"

The right value is obtained at 0 degrees Celsius by the formula provided
in the datasheet:

T = Tsens_t0 + (Tadc_t - Tadc_t0) / Tadc_res

where:
T = 0 degrees Celsius
Tsens_t0 (reference temperature) = 25 degrees Celsius
Tadc_t0 (16-bit format for Tsens_t0) = 17508
Tadc_res = 60.1 LSB/degree Celsius

The resulting offset is 16605.5, which has been truncated to 16005 to
provide an integer value with a precision loss smaller than the 1-LSB
measurement precision.

Fix the offset to apply its value prior to scaling.

Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net>
---
 drivers/iio/magnetometer/tmag5273.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/magnetometer/tmag5273.c b/drivers/iio/magnetometer/tmag5273.c
index c5e5c4ad681e..d22ca39007b6 100644
--- a/drivers/iio/magnetometer/tmag5273.c
+++ b/drivers/iio/magnetometer/tmag5273.c
@@ -356,7 +356,7 @@ static int tmag5273_read_raw(struct iio_dev *indio_dev,
 	case IIO_CHAN_INFO_OFFSET:
 		switch (chan->type) {
 		case IIO_TEMP:
-			*val = -266314;
+			*val = -16605;
 			return IIO_VAL_INT;
 		default:
 			return -EINVAL;

---
base-commit: 05d3ef8bba77c1b5f98d941d8b2d4aeab8118ef1
change-id: 20231023-topic-tmag5273x1_temp_offset-17774cbce961

Best regards,
-- 
Javier Carrasco <javier.carrasco@wolfvision.net>