Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1135887rda; Mon, 23 Oct 2023 03:56:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkJMlsGgnUvC0JVzVOElLlyWZWoPoHUalKVQ+y0rH4DVKvjTCfZTFr/xzMgYJ/CU76C5Gj X-Received: by 2002:a05:6808:182a:b0:3b2:e95d:8b2 with SMTP id bh42-20020a056808182a00b003b2e95d08b2mr12170541oib.12.1698058601201; Mon, 23 Oct 2023 03:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698058601; cv=none; d=google.com; s=arc-20160816; b=h0fkdFXQfK7dDcSGKgRpj4yv9RyNyUC1mDAcxj754sXbhrw7Z06ElHeJWKZC4+LYUt 2XebJS+3g10rpfCkZXNOouWA6FYpzzBOzzXuGOVL8glOHSDKW9Y7JH48p7mn1QcGdg4U nKfWJqTKI4S/DY/Xk7ixs7ynXP8iyXU90UCQi6uul6JRYbLHO3wsj9Iu00LvhObxWm4M i3S7c2CEw+g+KhbgY8VhslSIn8+AtodLRkDIgOUhgw26ssiL+x9IrKP0BMCebd9x9oSh 3knJErg0q+CkuUPgJJhteKgcOzEny1FQVd3t3Rw/u3+yVeNnvq02/hTe2D1jAcQ6Hgn1 /xOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Vp9jWmYZpkvc16waNCb0NLyunTdwIkO5xOxb3mychHY=; fh=vJuql4DTq6KnxQZ/B563xy3AlrOr/OkDGOAqBtLkTrE=; b=QmPscPMyuqbMO/Du7QwfVa3OSbd95u6c6VHF0CpxYWlLxm13c/iF17fx2TvkboN+qh 1sLRNXHjYDhvqlH5OWjDBxwNIoUNUF1/0o/1HldYPYQ1OozzPq1KOQ4IF8TBfwO/7xIX AHqYN36aK5bJJDi29J7OzwgAtk0jAsVVI9qwyUp4C5QWFD+wiGYbUnmBCZplsxBmk4tF mv8jNNz0pF1GgbXmIjbE2Qoma7viRRX1uStfI5Zew4BO11Iu+gc5bkWYsSWDm3e/iS6n W9ZB8/A+jqpWpZKmlFEqsCs2Tu9Kxh4xtRziGQVkEmBL9l+UTX535O+raPAwj2+qmpxI 6GsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id w17-20020aa79551000000b0068fb95e5401si6221679pfq.65.2023.10.23.03.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 03:56:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id DA207807C860; Mon, 23 Oct 2023 03:56:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbjJWK4K (ORCPT + 99 others); Mon, 23 Oct 2023 06:56:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbjJWK4J (ORCPT ); Mon, 23 Oct 2023 06:56:09 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF17BD7C for ; Mon, 23 Oct 2023 03:56:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 143CCC433C8; Mon, 23 Oct 2023 10:56:01 +0000 (UTC) Date: Mon, 23 Oct 2023 11:55:59 +0100 From: Catalin Marinas To: Liu Shixin Cc: Patrick Wang , Andrew Morton , Kefeng Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] mm/kmemleak: move the initialisation of object to __link_object Message-ID: References: <20231023025125.90972-1-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023025125.90972-1-liushixin2@huawei.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 03:56:16 -0700 (PDT) On Mon, Oct 23, 2023 at 10:51:25AM +0800, Liu Shixin wrote: > Leave __alloc_object() just do the actual allocation and __link_object() > do the full initialisation. > > Suggested-by: Catalin Marinas > Signed-off-by: Liu Shixin It looks fine to me. Thanks. Reviewed-by: Catalin Marinas