Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1141769rda; Mon, 23 Oct 2023 04:07:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCfOnZuQQ1HZlvVYEWq1MglC9BNo/sAMa9/i1usxkYcHHGIH71KwOSWIGgOiv/75NeaFyZ X-Received: by 2002:a17:902:ce8d:b0:1ca:c490:8539 with SMTP id f13-20020a170902ce8d00b001cac4908539mr8210270plg.18.1698059242182; Mon, 23 Oct 2023 04:07:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698059242; cv=none; d=google.com; s=arc-20160816; b=dM574CDne6UT4DAidvfxqcaxu+/hjQs+sfIFMz8BzFGSG3YaE1hGHQuYSvBWvOyqkI M199+pTQ8FGV1piFz0M/3eT30DmIG6i1JhxVGZcZ08OxcAfrSFSxOQxhuG1Gzo4cSvbQ SfxWtklXvQKVyW5E/t41W3INt1hmQO30iRRKJ0s0abiJETeT9BDdLPLjY8gag18/x052 xHlLyzs2n8TAEmNdPw2DWyYO5yAX/NbhitqjozqOoBhE2k2XzxUiS5n6ZEC3L5VA/fnD vGKEvgcJ4JvR37gtAvijCizfDnyXZ9D+7ecl6JXwUsVTIxgsrRkxXXleHUNyDqOwiG/v ErsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=21aZOJb6JuMoq2tUtRbDCx8ZV6FPqFGSAXWbs6z++TU=; fh=qKTzptlUDzifbkhmmV2BF0eHk3Tq/g9QDYrt0FTkDTM=; b=C3g7Kr7HgYfKvTivzW1oCS05btv78fb00fMAje7wd92EZHTOAdBi/1l9rda4ASsySf oyR/ApKtYzFN0ElpDAhSU8XZRMH0G+D4SqGH/tALtb95XLlj1NmNP8d80U0TrPqcAXTE KtOyOSuFZt/DpbSvrtzdqplkzYJoSYkHJwmxceH4imwSbhrBBs93+TJ71heLqPUy39zO 8cKm+KQ4NlRNDabBYR8UMbCr3vzCQFQMh9gs9d+JpSTD6chOzO9wXYnUHPPzDliWfs9L lTSEdvI0sGzs4pZA08KaupvJsUeuoBvK6B7iw/5+MHFQzlwSwalXlxhRKTPnvKXht5hE jLhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TMmCx2aK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id d12-20020a170902cecc00b001ca81fa0660si6547243plg.496.2023.10.23.04.07.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 04:07:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=TMmCx2aK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id EC83F8042709; Mon, 23 Oct 2023 04:07:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbjJWLHL (ORCPT + 99 others); Mon, 23 Oct 2023 07:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233427AbjJWLHI (ORCPT ); Mon, 23 Oct 2023 07:07:08 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB78FD7E for ; Mon, 23 Oct 2023 04:07:06 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9D3796606F51; Mon, 23 Oct 2023 12:07:04 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698059225; bh=H1B9KGgQAiRUFMaOD7pDr+fGSwuRs81e04oqqbnXjZ0=; h=Date:Subject:To:References:From:In-Reply-To:From; b=TMmCx2aKkdcBER4WpXQVelH7qKmezHjQUJy5COnfDn6OHB3zqBVlTo9CVwPKEo3IS VpaTwSsPGsCPN6AiPa/NHfebcyOfP4awZmHhbZK/HcohNASZ0VyN51NhiSJ/qNyUAy OPklcHBMBhh+wadySMo+ufaI/n4ANhf5+q8SrQN52toT02g5dMVQi8xWCbRWgSXV4+ y9gJClwIYYgjwiRgylhJ8Y59IkUpeV+HoZskBcZYGF3HCewS9eR8L/6sFe4k2LC7Lj P7uBU41qCXV2IE3JvdBfsa8zfSJSaDzkLvu3UGtQTxWVjFMG6YnL3i6CXltevycI1V XAII2clCo2drA== Message-ID: <07af235a-c6d5-4d8d-9b44-ff7157e2a80c@collabora.com> Date: Mon, 23 Oct 2023 13:07:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] ASoC: mediatek: mt7986: remove redundant remove function Content-Language: en-US To: Maso Huang , Liam Girdwood , Mark Brown , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20231023095453.4860-1-maso.huang@mediatek.com> <20231023095453.4860-2-maso.huang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20231023095453.4860-2-maso.huang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 04:07:20 -0700 (PDT) Il 23/10/23 11:54, Maso Huang ha scritto: > Remove redundant remove function of mt7986-wm8960. > > Signed-off-by: Maso Huang You're doing more than what you're advertising; you are: 1. Dropping the remove callback; and 2. Removing the mt7986_wm8960_priv structure You can do that in one single commit if you really want to, but you have to use the appropriate commit title and description, saying exactly what you're doing. Regards, Angelo