Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <a01b914d-1ee6-4e48-a4d5-d36ad9435951@nvidia.com>
Date:   Mon, 23 Oct 2023 14:24:46 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH iproute2-next 2/3] rdma: Add an option to set privileged
 QKEY parameter
To:     David Ahern <dsahern@gmail.com>, Petr Machata <petrm@nvidia.com>
Cc:     jgg@ziepe.ca, leon@kernel.org, stephen@networkplumber.org,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linuxarm@huawei.com, linux-kernel@vger.kernel.org,
        huangjunxian6@hisilicon.com, michaelgur@nvidia.com
References: <20231019082138.18889-1-phaddad@nvidia.com>
 <20231019082138.18889-3-phaddad@nvidia.com> <87il72aiqm.fsf@nvidia.com>
 <c7c9562a-5c6d-eec5-3255-70238a13e96c@nvidia.com>
 <bc9f53d2-2d40-4c7e-85fa-cb9835df9159@gmail.com>
Content-Language: en-US
From:   Patrisious Haddad <phaddad@nvidia.com>
In-Reply-To: <bc9f53d2-2d40-4c7e-85fa-cb9835df9159@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bUlhSzBHV1RQaEp4NC9JWUR5bi8vRGJ0K2tHUk5abVVpSUczMHlIdmhBWVFR?=
 =?utf-8?B?SHVEeGlNcjlyekJ2NktmNllSVUZ0ZndWanEwRjNmNnhwL0JjTGliRWFKemtF?=
 =?utf-8?B?VFF0bEp2UFYrZXEvczZCVFVtMGFIYWR6MzNTNEJTSzdnMG9pVWFDam9zUm9x?=
 =?utf-8?B?bUxLeGdBVHVmYVc0NVA0S2oyS0hobVdNUWJLODRVK1BvNzhHMWYwczNXTlZl?=
 =?utf-8?B?WmFqSlVndWhvdDBiZVJnc0EwdnVXeVBMN2MvczN0RjdaTmVUc2xaUjA5Q0Ru?=
 =?utf-8?B?SEJGNndaQ0JLVGsyU0hnTDlPU1FMNm5jMmlPcmc0UGEvYjd5bEhRMjQ0OExX?=
 =?utf-8?B?cGxCbWpsd1RweFJqZkNCYTNvbUx4Q3k3bXJidFAxWTc1RjZwUHB6SU9nTWFj?=
 =?utf-8?B?Njd0ZXcxaFg0dFFkRDdrOEE2M0tDWEwvRk1JT0NnVEFUMlgrN3VwQkcxRmZD?=
 =?utf-8?B?dEE0d21PLzg5aHU5bEQybjR5K2VPVitTV3gwQkJiamptNk44Z1BNckFwcXgy?=
 =?utf-8?B?ckdDaHZxY2dvSTljZlYyaUVYRFUyUHMzT1dIRDZBK1JvaUZic0JpbkRmdm05?=
 =?utf-8?B?YkZ5eWFRL0JvUGxnWDRhb3huSGlyVVJvSi9JNTd6czY2Q2RyMmxXZXRhcFJ1?=
 =?utf-8?B?eTFrWE13Y2IrMzJNL20yQVZNeUlBZW1nWk4xaG00RlhjclFLSE1VZkYrUDlO?=
 =?utf-8?B?RmZQSS8rZlgycDhFamJOR0Jvd0x2enJQdmFKaXpmTXBMYkxvMTVMNTNzMGZM?=
 =?utf-8?B?aGZ6NnRlcTZrTFlqVFRNTUpyOExhVzBxY3hBS1NZb1lPRmxtaTIzUWtIcCs5?=
 =?utf-8?B?cjBOOTl3L1J0TDdVMmkvV3c3OUpkUUNFc0Q2NGtOZC9JMEhHZ2s2QURBaVJ6?=
 =?utf-8?B?NCtVQU41OTQ4TEM3V3RuZWxJV3lKOEdhNnlROGVIS1RKQzBwVVhUaE12WTZM?=
 =?utf-8?B?MDdYWU85aHIzYWU0MnNUbjdoMXFKYWtXYnFQNGEvZGJyelZ4eFdzajJmR1pu?=
 =?utf-8?B?MkpkSFNrdVBZbzVsR3NCa2RLa1YrOWk2WHJBbStENWc0SEVIM2I1Q3crY3hV?=
 =?utf-8?B?ZDNMY3J0anRvOVdIRTZFL2s0UTVnRG5nd1NmNnIwUWxhL09OMzZUNm9iczY0?=
 =?utf-8?B?Wm9ESTV3OXREUjF2VVBJUWdwL1dIdW55djZaTVhLamZPY3pNTTZHZ1Q2Z3Az?=
 =?utf-8?B?blNPMHNKNm9OOWNiL3hTdDF6Y0JuRUcrTmYvdjRqcm1TeE9aczhRNnRuRlA4?=
 =?utf-8?B?Vzl0bXYra1dvQ2dWUVUveUNkd1JYWUU3Rm5OWFRYenJRUHNyVGRCWHhOMlBh?=
 =?utf-8?B?M1VsY2RyYjlUbzI5UmtUSkJ1QmhPSWZjNVpRNGxhRW1uTEZESndWWjBjS0lr?=
 =?utf-8?B?OFNueVZob0J4UFNOM21QSWRpTHFoaDcvd3JvMDA1VTI1d2ZPT1N5bytpMEVN?=
 =?utf-8?B?NnF5am5RNG9OeFdnZ1JqaXU0YlV3dU5DNzRsRUNsbitjcCtPY1loWnMzU3Qw?=
 =?utf-8?B?QWJuVEFjemF3Mjd2aTJSaGtqclhkbDZ4eDRyUXJFeFBpV045OXVBM0ZGSEFM?=
 =?utf-8?B?Ui8yM0lWa3pncDJqcFVKUlZMejhNd3NMT2RvQ3AwN3c4eGV4VTJTWGtLdHM5?=
 =?utf-8?B?WkU5ZEN0cDhrMXA5RHN4UXRUTjhvMUszOTVLUG0wQmMvRGEwV3RmbGRzREhr?=
 =?utf-8?B?UWRCaDlvWFg5dTl5bStSb2lGU2xtakN2MEhPQUNvekk5aGZzd3FLdnBXS1VE?=
 =?utf-8?B?N2Jwbnh2LzdLMWV2QVJmVXQwcTRoUFpCNS9tNk50d3hiNEIvaGloSEUyNHNL?=
 =?utf-8?B?UEFzVW5Fb2ZFTHlsVFdjMDZtNFAxcmMxVS9ZVXgralB2UXUrL2V2RU5ZVjJG?=
 =?utf-8?B?ekdDakg0bkZ5b2FQcWhYQkNJMzBxaHIxMFBNSHhSUFVaR1o3REJjT29SWnRF?=
 =?utf-8?B?UzJscGw3b0Y4MG4vRjE4Z0kzWVc5dkJWZ3E0RFA0NHRZRytEMCtuOXdYT2Fu?=
 =?utf-8?B?WkFrQTJnUC9JS1pHSWNPMm9qZmM4OFBYU1o2NHN3TXZINWJkSXBZaStmMVE0?=
 =?utf-8?B?Zk4rVCtSQmI1T0lmQm5NVzZIME4zUjVwVG1xWlVEMkdiR3laYjlPMEk0UEwv?=
 =?utf-8?Q?DCextT8kDZgRGTxpFNeqaUgEO?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c2dfe58-0694-4f31-8237-08dbd3baace8
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6660.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 11:24:52.4391
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dv46sKz++YfJE+gLoU+6vGvdtolzhTeavURABy61Uv4UhNepb5twV/X4bCHlKR29qGwEC0ImUg0UxDdbJ9Lkew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6469
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 04:25:22 -0700 (PDT)


On 10/22/2023 7:48 PM, David Ahern wrote:
> External email: Use caution opening links or attachments
>
>
> On 10/22/23 1:41 AM, Patrisious Haddad wrote:
>> On 10/19/2023 1:38 PM, Petr Machata wrote:
>>> Patrisious Haddad <phaddad@nvidia.com> writes:
>>>
>>>> @@ -40,6 +45,22 @@ static int sys_show_parse_cb(const struct nlmsghdr
>>>> *nlh, void *data)
>>>>                       mode_str);
>>>>        }
>>>>    +    if (tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]) {
>>>> +        const char *pqkey_str;
>>>> +        uint8_t pqkey_mode;
>>>> +
>>>> +        pqkey_mode =
>>>> +
>>>> mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]);
>>>> +
>>>> +        if (pqkey_mode < ARRAY_SIZE(privileged_qkey_str))
>>>> +            pqkey_str = privileged_qkey_str[pqkey_mode];
>>>> +        else
>>>> +            pqkey_str = "unknown";
>>>> +
>>>> +        print_color_string(PRINT_ANY, COLOR_NONE, "privileged-qkey",
>>>> +                   "privileged-qkey %s ", pqkey_str);
>>>> +    }
>>>> +
>>> Elsewhere in the file, you just use print_color_on_off(), why not here?
>> The print_color_on_off was used for copy-on-fork which as you see has no
>> set function,
>>
>> I was simply trying to be consistent with this file convention & style,
>> whereas print_color_string was used for the other configurable value
>> ("netns"), I can obviously change that if you all see it as necessary.
>>
>>>>        if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
>>>>            cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]);
>>>>    @@ -111,10 +155,25 @@ static int sys_set_netns_args(struct rd *rd)
>>>>        return sys_set_netns_cmd(rd, cmd);
>>>>    }
>>>>    +static int sys_set_privileged_qkey_args(struct rd *rd)
>>>> +{
>>>> +    bool cmd;
>>>> +
>>>> +    if (rd_no_arg(rd) || !sys_valid_privileged_qkey_cmd(rd_argv(rd))) {
>>>> +        pr_err("valid options are: { on | off }\n");
>>>> +        return -EINVAL;
>>>> +    }
>>> This could use parse_on_off().
>> You are absolutely correct, but just as well was trying to maintain same
>> code style as the previous configurable value we have here, but I think
>> using parse_on_off here can save us some code.
>>>> +
>>>> +    cmd = (strcmp(rd_argv(rd), "on") == 0) ? true : false;
>>>> +
>>>> +    return sys_set_privileged_qkey_cmd(rd, cmd);
>>>> +}
>>>> +
>>>>    static int sys_set_help(struct rd *rd)
>>>>    {
>>>>        pr_out("Usage: %s system set [PARAM] value\n", rd->filename);
>>>>        pr_out("            system set netns { shared | exclusive }\n");
>>>> +    pr_out("            system set privileged-qkey { on | off }\n");
>>>>        return 0;
>>>>    }
>>>>    @@ -124,6 +183,7 @@ static int sys_set(struct rd *rd)
>>>>            { NULL,            sys_set_help },
>>>>            { "help",        sys_set_help },
>>>>            { "netns",        sys_set_netns_args},
>>>> +        { "privileged-qkey",    sys_set_privileged_qkey_args},
>>>>            { 0 }
>>>>        };
>>> The rest of the code looks sane to me, but I'm not familiar with the
>>> feature.
>> If no one else has any comments soon, and these two comments are
>> actually considered critical I can re-send my patches with those issues
>> fixed.
> tools packaged with iproute2 should use common code where possible.

Okay, good point, fixed both comments and sent a V2 , it actually 
resulted in a much cleaner code.

- Thanks.